From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479E0C63777 for ; Wed, 18 Nov 2020 12:52:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D57A924181 for ; Wed, 18 Nov 2020 12:52:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TlYBdSZz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbgKRMwv (ORCPT ); Wed, 18 Nov 2020 07:52:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgKRMwu (ORCPT ); Wed, 18 Nov 2020 07:52:50 -0500 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6380BC0613D4; Wed, 18 Nov 2020 04:52:50 -0800 (PST) Received: by mail-il1-x144.google.com with SMTP id y18so1836712ilp.13; Wed, 18 Nov 2020 04:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wzrnd7ru2kaBqfdd45rq9TddpeZGif2RVKPJRSLQI3s=; b=TlYBdSZzpaW2FiQluPWVvSNLkouu0qMkLKKotMHfTu5dwanD115LCVtGRmnM7tViyi dNqpq57hCD0IerxpBbQeEO+Ka10SeoQX5/3GWolmUlM2xJne/riLoYCfcgSTWG4t+xWJ 6vZo5LgtSRwRPeeHSOHWcdVK7PxlJyMoLsOEGydNb+uP5dSrW6jDv8SCaSsjBQ8AP5Ga QV5JPNk8Yr2nZfXJLRC4u+r54Im/D830HIdHbPqVKHc1TMwgLaRLKhZujC1MhTI2C/jn 6cZIZR6g3+2PB9+VoTmbU7Ot2ZJxnODHZ3TJns8Ey8Lb0gm4sVaS+ZId4sT66b5rMzmj Sx8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wzrnd7ru2kaBqfdd45rq9TddpeZGif2RVKPJRSLQI3s=; b=XP8cX1ioLbFfUpvz5Zy5wZ1ia6efwuw2BawYXG+vygpt78/SMMzdrnXv4y/lNNN8hQ l1MaAv2mwQnZIJQcx9HOU7JEtmTMFdMnYG46In5Wa8kTLS8zvAn45p2LKDMZa3aCtrgH AuaSBiebRK0OTSEHnFwE4af/XZQXLsk6XSLGUqG7JSiafCV5tQogZffOgjGUGKzTGzlj D5mqkz5ebRdWl1CikFMDn3a0Rvr9LRsZXOuOdgRRxqVBzVgxAB9vcy/bXlx5mh5fMzlX 4hPQQ8uF0P5TyK8SzmfQAC0RELtU2nkJz9bZKiH/xYUSqV7eXz8CQZXmA5abNedM3QU8 bgaQ== X-Gm-Message-State: AOAM532uha85CPPkwa+kdjX71y8ruJqDdh7dFMuKe+1BZ5doyJX+25EX 2LuB+g7MIMWG0NraXonoEjNtfIMdM0x4YvP4Hr6G/Thkuh1Arw== X-Google-Smtp-Source: ABdhPJy0fX+lcmmXzIlqfNie1TanUYv4qa3GgtyYnMvOyW5qYXKut25OlReiNtNCQIHAvDYyZBL5zpZaYK4HMiOlZ5o= X-Received: by 2002:a92:d90c:: with SMTP id s12mr17061620iln.100.1605703969800; Wed, 18 Nov 2020 04:52:49 -0800 (PST) MIME-Version: 1.0 References: <20201117075254.4861-1-alexandru.ardelean@analog.com> <20201117104126.00000516@Huawei.com> In-Reply-To: From: Alexandru Ardelean Date: Wed, 18 Nov 2020 14:52:38 +0200 Message-ID: Subject: Re: [PATCH 1/3] iio: adc: ad7887: convert dual-channel mode to DT/ACPI To: Andy Shevchenko Cc: Jonathan Cameron , Alexandru Ardelean , linux-iio , devicetree , Linux Kernel Mailing List , Jonathan Cameron , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 1:10 PM Andy Shevchenko wrote: > > On Tue, Nov 17, 2020 at 12:42 PM Jonathan Cameron > wrote: > > > > On Tue, 17 Nov 2020 09:52:52 +0200 > > Alexandru Ardelean wrote: > > > > > This change converts the configuration of the dual-channel mode from the > > > old platform-data, to the device_property_present() function, which > > > supports both device-tree and ACPI configuration setups. > > > > > > With this change the old platform_data include of the driver can be > > > removed. > > > > > > Signed-off-by: Alexandru Ardelean > > Hi Alex, > > > > I'm a bit in too minds about device_property_present() > > vs device_property_read_bool() which are the same thing under the hood. > > > > Not sure which one conveys the correct semantics here. > > I don't feel strongly enough about it though to do more than raise > > eyebrows (i.e. not blocking this series). > > The idea as I understand it is that the 'present' can be run against > any type of property, while 'bool' is specifically for boolean (the > similarities is a detail of implementation). Yeah, I'm also not sure which to use here. I guess I got used to using device_property_present() a bit more. They're both pretty used around other drivers. I guess I'll leave it as is for now, unless other complaints. > > -- > With Best Regards, > Andy Shevchenko