Re: [PATCH v4 0/6] iio: Add output buffer support and DAC example

From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Mihail Chindris <mihail.chindris@analog.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Bogdan, Dragos" <dragos.bogdan@analog.com>,
	"Alexandru Ardelean" <alexandru.ardelean@analog.com>
Subject: Re: [PATCH v4 0/6] iio: Add output buffer support and DAC example
Date: Wed, 25 Aug 2021 10:35:53 +0300	[thread overview]
Message-ID: <CA+U=DsqfxUVJ6e_09wWBqP2XMgYrsq0ggOmgFWKzrru45oWZYQ@mail.gmail.com> (raw)
In-Reply-To: <20210820165927.4524-1-mihail.chindris@analog.com>

On Fri, Aug 20, 2021 at 8:01 PM Mihail Chindris
<mihail.chindris@analog.com> wrote:
>

My only note about this series [as a whole] is that I would have
chosen an existing DAC to which to add kfifo output support.
To make things smooth for this new mechanism.

A new driver usually takes more effort to review/introduce than a
change to an existing one.

> Changelog v3 -> v4:
>   * https://lore.kernel.org/linux-iio/20210219124012.92897-1-alexandru.ardelean@analog.com
>   * Remove DMA related commits
>   * Test and add fixies to the previous version
>     - Add write function to iio_buffer_fileops in industrialiio-core
>     - In iio_kfifo_remove_from change number of samples to 1 instead of
>       r->bytes_per_datum otherwise n square samples are removed.
>     - In iio_buffer_remove_sample replace move buffer->access->write
>       check to first if an replace with remove_from. Checkpatch was
>       complaining about returning -ENOSYS
>   * Add ad3552r example
>
> Alexandru Ardelean (1):
>   iio: triggered-buffer: extend support to configure output buffers
>
> Lars-Peter Clausen (2):
>   iio: Add output buffer support
>   iio: kfifo-buffer: Add output buffer support
>
> Mihail Chindris (3):
>   Documentation:ABI:testing:add doc for AD3552R ABI
>   dt-bindings: iio: dac: Add adi,ad3552r.yaml
>   drivers:iio:dac: Add AD3552R driver support
>
>  .../ABI/testing/sysfs-bus-iio-dac-ad3552r     |   10 +
>  .../bindings/iio/dac/adi,ad3552r.yaml         |  185 +++
>  drivers/iio/accel/adxl372.c                   |    1 +
>  drivers/iio/accel/bmc150-accel-core.c         |    1 +
>  drivers/iio/adc/at91-sama5d2_adc.c            |    4 +-
>  .../buffer/industrialio-triggered-buffer.c    |    8 +-
>  drivers/iio/buffer/kfifo_buf.c                |   50 +
>  .../cros_ec_sensors/cros_ec_sensors_core.c    |    5 +-
>  .../common/hid-sensors/hid-sensor-trigger.c   |    5 +-
>  drivers/iio/dac/Kconfig                       |   10 +
>  drivers/iio/dac/Makefile                      |    1 +
>  drivers/iio/dac/ad3552r.c                     | 1419 +++++++++++++++++
>  drivers/iio/iio_core.h                        |    4 +
>  drivers/iio/industrialio-buffer.c             |  133 +-
>  drivers/iio/industrialio-core.c               |    1 +
>  include/linux/iio/buffer.h                    |    7 +
>  include/linux/iio/buffer_impl.h               |   11 +
>  include/linux/iio/triggered_buffer.h          |   11 +-
>  18 files changed, 1854 insertions(+), 12 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dac-ad3552r
>  create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
>  create mode 100644 drivers/iio/dac/ad3552r.c
>
>
> base-commit: 94a853eca720ac9e385e59f27e859b4a01123f58
> --
> 2.27.0
>