From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0201CC4167D for ; Mon, 28 Nov 2022 13:53:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232191AbiK1Nxk (ORCPT ); Mon, 28 Nov 2022 08:53:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232163AbiK1Nxh (ORCPT ); Mon, 28 Nov 2022 08:53:37 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A657FB1B; Mon, 28 Nov 2022 05:53:36 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id x2so15540282edd.2; Mon, 28 Nov 2022 05:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0nL99pZ4RJUpEgtFxI8B3xt54A7EJNAJ95lZjHVoXWY=; b=IlllHOn1t+t9xZag64u0/1YYZn03G5hHGRpVDnEm1W1mmFCuy6Wuze9IQLww1vBDaW EKIqfhWuQLIRMbRDFsylpDVxC2YjuAliZin1UO1p7/YBn1+ewkq7OksjK5eRXhGA37Kz 4kkzONCWruYEICysU69EOTdEeQxpa/ExoAoqtnw+upL/LGcXH0nAV738oH01aaGRvqOy q3nW20LVbRhLcLDZHShp8+fVwOevcTF3sHTEV2Wg768stiKWQAL0WTEQ3KQbzqJ5uJkv lf3ZTg1xSWGPaGZQEQNGbrw45ImJWS187drEtSfcYFe43qSZ6YYSnEOJJLJkBsrtYG2g Aw6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0nL99pZ4RJUpEgtFxI8B3xt54A7EJNAJ95lZjHVoXWY=; b=fBFA6xJ7r0RoQIOSuBP0DA8kIQbE6zlVCzokdx+z5IE/cvLTId4D3DZ8aZH+cP75Ho Kd7PIi9MB9ELbllN3cQIkfajDeMUo2LjaoLkfsYuufP4cjJMjGnJ/DmkNmmMGofd+v7/ f5oKWV7h/kzKZA03tCdD6PrlJzQw/PQ9R73+mHzZ5wiWFvrs5QzghKDtcjtqHq0C8Rzg O+rdHNnUrJNq5peQQF48cOD0hScJ42chqfCETDzNDPzD2B59rx4GA4+LOtETSrCAMkYK r87scm/XZSdJXKrGSLH7CoIZYs+vxNGCcuJk6JWRy+zahJ/PcCTarWbSpn4iSdFvux5F 66dw== X-Gm-Message-State: ANoB5pmttUcqxs6OHtZjWO5s+rsqwu3ysBX5je9gJE05OBBUoLBQcIob 6jayPMb+teYO7oncfBVrjD7AM3i/vA5G7YPq9nM= X-Google-Smtp-Source: AA0mqf6MsS6kpVG7psn8SeuxEJiQ96AvHYPpr1XaJsJLgR8FGLibjVbju+H0gGWJSdpRxacxXeEN9ES49KS+b44uNRM= X-Received: by 2002:a05:6402:1f87:b0:468:7df:c38c with SMTP id c7-20020a0564021f8700b0046807dfc38cmr46515406edc.150.1669643615154; Mon, 28 Nov 2022 05:53:35 -0800 (PST) MIME-Version: 1.0 References: <20221031232202.131945-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20221031232202.131945-7-prabhakar.mahadev-lad.rj@bp.renesas.com> <738a2461-7a6a-286b-89e8-d46a26ec6506@xs4all.nl> In-Reply-To: <738a2461-7a6a-286b-89e8-d46a26ec6506@xs4all.nl> From: "Lad, Prabhakar" Date: Mon, 28 Nov 2022 13:53:08 +0000 Message-ID: Subject: Re: [PATCH v4 6/9] media: i2c: ov5645: Use runtime PM To: Hans Verkuil Cc: Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Geert Uytterhoeven , Magnus Damm , Shawn Tu , Jacopo Mondi , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Biju Das , Lad Prabhakar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On Mon, Nov 28, 2022 at 1:49 PM Hans Verkuil wrote: > > > +exit: > > + ov5645_set_power_off(dev); > > return ret; > > smatch gives this warning: > > drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687. > > Can you take a look? > Sure I'll have a look at it. Cheers, Prabhakar