From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CE1ECDFB6 for ; Tue, 1 Oct 2019 06:04:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B63621783 for ; Tue, 1 Oct 2019 06:04:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dKO9OGS6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729435AbfJAGEY (ORCPT ); Tue, 1 Oct 2019 02:04:24 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:38965 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbfJAGEY (ORCPT ); Tue, 1 Oct 2019 02:04:24 -0400 Received: by mail-oi1-f196.google.com with SMTP id w144so13363130oia.6; Mon, 30 Sep 2019 23:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYmn1RGpgg8VX1Qo6oYxvE2WRpsEQOwyM+oN3U5uqPU=; b=dKO9OGS6n6NHI19X5QQZOgCB2CmwoBrOiayocRnmAfKT+TpDXslM8sLq52LhvFwmbz ONq9PeS91UAcQsZrGarGYwjsoNQuzOOtL3mvnmghjfcXseb6sy/KBM6CJILY0rQmzBVX 8PHomgLfMORCESn6cO7HzMraB57miUlJEZV0j7RzBVfvsf3NxXJNVgt/mvUehGrCp/mR VY5MWXaoKKjaFgNBWQHPB+YZHJ/YlHl1DiTVqbJvok3VrgYuAISBmafqEjGFcdgeA9qN ACEXumyrd+20kb7/gFsDGtnPiqRPeOdddzvpPA4+fq32A+UIpjHfpf+BK6NUq1oXL26O N7aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYmn1RGpgg8VX1Qo6oYxvE2WRpsEQOwyM+oN3U5uqPU=; b=ashnj9+t3gOfjZsNJAkLCe4wrSOLHxFnthDiQAlnS/yQ9lMMW25kE7+JUpYePKvgXs 3swfEVKqkC/DDIh4W1hOTnEo3xLZOtT4iWXFaXRAkfiSGGRk8JQ1t1d+JcwD03dQqwDH /kXoFNAI/5sFYZ8vh9kfjEfeFvjb9o4G8f2YpqaScnh6IcbE8yU1+ubI7sNzgSdV1xgw as4WF3XlRh+sgi74w3FK/DbSSdkEsm3YfAnLeQc+19by9TxGKXALa4uGVLcrFS3p0+jb 9DOjv1c7/fSEUSlwjw+HqdAkRrs6Fv8+9sCdOSP576aEq1D6n21g17yG7xhzmMs+HEm3 iuwA== X-Gm-Message-State: APjAAAXoqVvm02cyoNem8K+xRfgORcm9PtaNjrpXbta6cWD52CLIOehl YbOs2xIBzNIt0ZgXfCYjtjhby7IKe2SaUAciDGh4v3qqmvQ= X-Google-Smtp-Source: APXvYqyzIoo6y1z96MAvy9Vq3wOI7NcCyES7Y/qTcv7jqyqUe+KnvjYeBfb5JG4hNh43puvYj95uMe9vXQ4MFNMofpk= X-Received: by 2002:aca:f444:: with SMTP id s65mr2391783oih.71.1569909863014; Mon, 30 Sep 2019 23:04:23 -0700 (PDT) MIME-Version: 1.0 References: <20190930130644.8704-1-bparrot@ti.com> <20190930130644.8704-7-bparrot@ti.com> In-Reply-To: <20190930130644.8704-7-bparrot@ti.com> From: "Lad, Prabhakar" Date: Tue, 1 Oct 2019 07:03:56 +0100 Message-ID: Subject: Re: [Patch v5 6/8] media: i2c: ov2659: Add powerdown/reset gpio handling To: Benoit Parrot Cc: Hans Verkuil , Sakari Ailus , linux-media , devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 30, 2019 at 2:07 PM Benoit Parrot wrote: > > On some board it is possible that the sensor 'powerdown' and or 'reset' > pin might be controlled by gpio instead of being tied. > > To implement we add pm_runtime support which will handle the power > up/down sequence when it is available otherwise the sensor will be > powered on at module insertion/probe and powered off at module removal. > > Now originally the driver assumed that the sensor would always stay > powered and keep its register setting. We cannot assume this anymore, so > every time we "power up" we need to re-program the initial registers > configuration first. This was previously done only at probe time. > > Signed-off-by: Benoit Parrot > --- > drivers/media/i2c/Kconfig | 2 +- > drivers/media/i2c/ov2659.c | 86 +++++++++++++++++++++++++++++++++++++- > 2 files changed, 85 insertions(+), 3 deletions(-) > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 7eee1812bba3..315c1d8bdb7b 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -634,7 +634,7 @@ config VIDEO_OV2640 > config VIDEO_OV2659 > tristate "OmniVision OV2659 sensor support" > depends on VIDEO_V4L2 && I2C > - depends on MEDIA_CAMERA_SUPPORT > + depends on MEDIA_CAMERA_SUPPORT && GPIOLIB > select V4L2_FWNODE > help > This is a Video4Linux2 sensor driver for the OmniVision > diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > index da181a13cf44..80de2e35aeca 100644 > --- a/drivers/media/i2c/ov2659.c > +++ b/drivers/media/i2c/ov2659.c > @@ -22,9 +22,11 @@ > > #include > #include > +#include > #include > #include > #include > +#include > > #include > #include > @@ -218,6 +220,10 @@ struct ov2659 { > struct sensor_register *format_ctrl_regs; > struct ov2659_pll_ctrl pll; > int streaming; > + /* used to control the sensor PWDN pin */ > + struct gpio_desc *pwdn_gpio; > + /* used to control the sensor RESETB pin */ > + struct gpio_desc *resetb_gpio; > }; > > static const struct sensor_register ov2659_init_regs[] = { > @@ -1184,10 +1190,19 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int on) > /* Stop Streaming Sequence */ > ov2659_set_streaming(ov2659, 0); > ov2659->streaming = on; > + pm_runtime_put(&client->dev); > goto unlock; > } > > - ret = ov2659_set_pixel_clock(ov2659); > + ret = pm_runtime_get_sync(&client->dev); > + if (ret < 0) { > + pm_runtime_put_noidle(&client->dev); > + goto unlock; > + } > + > + ret = ov2659_init(sd, 0); > + if (!ret) > + ret = ov2659_set_pixel_clock(ov2659); > if (!ret) > ret = ov2659_set_frame_size(ov2659); > if (!ret) > @@ -1229,12 +1244,18 @@ static int ov2659_s_ctrl(struct v4l2_ctrl *ctrl) > { > struct ov2659 *ov2659 = > container_of(ctrl->handler, struct ov2659, ctrls); > + struct i2c_client *client = ov2659->client; > + > + /* V4L2 controls values will be applied only when power is already up */ > + if (!pm_runtime_get_if_in_use(&client->dev)) > + return 0; > > switch (ctrl->id) { > case V4L2_CID_TEST_PATTERN: > return ov2659_set_test_pattern(ov2659, ctrl->val); > } > > + pm_runtime_put(&client->dev); > return 0; > } > > @@ -1247,6 +1268,39 @@ static const char * const ov2659_test_pattern_menu[] = { > "Vertical Color Bars", > }; > > +static int ov2659_power_off(struct device *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > + struct ov2659 *ov2659 = to_ov2659(sd); > + > + dev_dbg(&client->dev, "%s:\n", __func__); > + > + gpiod_set_value(ov2659->pwdn_gpio, 1); > + > + return 0; > +} > + > +static int ov2659_power_on(struct device *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > + struct ov2659 *ov2659 = to_ov2659(sd); > + > + dev_dbg(&client->dev, "%s:\n", __func__); > + > + gpiod_set_value(ov2659->pwdn_gpio, 0); > + > + if (ov2659->resetb_gpio) { > + gpiod_set_value(ov2659->resetb_gpio, 1); > + usleep_range(500, 1000); > + gpiod_set_value(ov2659->resetb_gpio, 0); > + usleep_range(3000, 5000); > + } > + > + return 0; > +} > + > /* ----------------------------------------------------------------------------- > * V4L2 subdev internal operations > */ > @@ -1327,7 +1381,6 @@ static int ov2659_detect(struct v4l2_subdev *sd) > ret = -ENODEV; > } else { > dev_info(&client->dev, "Found OV%04X sensor\n", id); > - ret = ov2659_init(sd, 0); > } > } > > @@ -1404,6 +1457,18 @@ static int ov2659_probe(struct i2c_client *client) > ov2659->xvclk_frequency > 27000000) > return -EINVAL; > > + /* Optional gpio don't fail if not present */ > + ov2659->pwdn_gpio = devm_gpiod_get_optional(&client->dev, "powerdown", > + GPIOD_OUT_LOW); > + if (IS_ERR(ov2659->pwdn_gpio)) > + return PTR_ERR(ov2659->pwdn_gpio); > + > + /* Optional gpio don't fail if not present */ > + ov2659->resetb_gpio = devm_gpiod_get_optional(&client->dev, "reset", > + GPIOD_OUT_HIGH); > + if (IS_ERR(ov2659->resetb_gpio)) > + return PTR_ERR(ov2659->resetb_gpio); > + > v4l2_ctrl_handler_init(&ov2659->ctrls, 2); > ov2659->link_frequency = > v4l2_ctrl_new_std(&ov2659->ctrls, &ov2659_ctrl_ops, > @@ -1449,6 +1514,8 @@ static int ov2659_probe(struct i2c_client *client) > ov2659->frame_size = &ov2659_framesizes[2]; > ov2659->format_ctrl_regs = ov2659_formats[0].format_ctrl_regs; > > + ov2659_power_on(&client->dev); > + > ret = ov2659_detect(sd); > if (ret < 0) > goto error; > @@ -1462,10 +1529,15 @@ static int ov2659_probe(struct i2c_client *client) > > dev_info(&client->dev, "%s sensor driver registered !!\n", sd->name); > > + pm_runtime_set_active(&client->dev); > + pm_runtime_enable(&client->dev); > + pm_runtime_idle(&client->dev); > + > return 0; > > error: > v4l2_ctrl_handler_free(&ov2659->ctrls); > + ov2659_power_off(&client->dev); > media_entity_cleanup(&sd->entity); > mutex_destroy(&ov2659->lock); > return ret; > @@ -1481,9 +1553,18 @@ static int ov2659_remove(struct i2c_client *client) > media_entity_cleanup(&sd->entity); > mutex_destroy(&ov2659->lock); > > + pm_runtime_disable(&client->dev); > + if (!pm_runtime_status_suspended(&client->dev)) > + ov2659_power_off(&client->dev); > + pm_runtime_set_suspended(&client->dev); > + > return 0; > } > > +static const struct dev_pm_ops ov2659_pm_ops = { > + SET_RUNTIME_PM_OPS(ov2659_power_off, ov2659_power_on, NULL) > +}; > + > static const struct i2c_device_id ov2659_id[] = { > { "ov2659", 0 }, > { /* sentinel */ }, > @@ -1501,6 +1582,7 @@ MODULE_DEVICE_TABLE(of, ov2659_of_match); > static struct i2c_driver ov2659_i2c_driver = { > .driver = { > .name = DRIVER_NAME, > + .pm = &ov2659_pm_ops, > .of_match_table = of_match_ptr(ov2659_of_match), > }, > .probe_new = ov2659_probe, > -- > 2.17.1 >