From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF7AC433E2 for ; Tue, 23 Jun 2020 08:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE0DD206D4 for ; Tue, 23 Jun 2020 08:35:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ij3LAsP9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731805AbgFWIfL (ORCPT ); Tue, 23 Jun 2020 04:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731567AbgFWIfL (ORCPT ); Tue, 23 Jun 2020 04:35:11 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1935CC061573; Tue, 23 Jun 2020 01:35:11 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id 18so1104434otv.6; Tue, 23 Jun 2020 01:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=goSzzxDsgzxsQuY6F1h0SsNpCeO6nw7HQJbzXsVCZxo=; b=ij3LAsP9p1irjc88wp1/WWNHRrwz3UZn4dmSUurQcPXlkh41m+MnezeltpEXliOxCt 3kxSCX/4mPnFXq4aU057VjYSGpTGZrzzbJh5hHQi7dNdKWoa+CeUDBGmwvYnMD0T0e7g Zf3DMSrWTgKKz2RUHr6MjNXLPC7iat4GzmFDvoGBlMzY8c1YInfnPOGF2SOjDI/FkzUB jGgTDY0j5xpx3tobTOPpKWUnG8uoy3BLAWFeis2vjxDOhRP25kXrtnKqd/ZB1ALr1kuQ xX+XKpRAYJioif5IWq6jAiewZ4Oky2moCN/xQsOeuFpvjGUzrMMsAoCqh4Elq8QWcRD6 ZuXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=goSzzxDsgzxsQuY6F1h0SsNpCeO6nw7HQJbzXsVCZxo=; b=PpfK3U8zyxd2buZJtox4W0jSmc1M1wMSeixVekqgfcqTyaH2ge/bkb2W0aQ2S2utaQ nhaQoFsNlmorw8nKC3EWA0CLs7ZhZ1w4U9/4UB7kR+NXvjuTkaQBbp7dQ8+monyn1wr8 zmX+JhBejofPrLP7XMG7QAwzzVNWEqTY17mbLUL/neBdRyxTWkcMw8errylzRr38iv0M rICWE9WP0FkNgP8i2W73otecrkzNAoDv3nc7rjg14nC3URZp9g8RNBM3LqV6zvdn9yNC YIQ8c1lyX4tCxn6vYFTL+hzIhFdkWvWDIQl+n3f+AbcL1ezvqwctLKTg2nr+40gcSMOK bmRw== X-Gm-Message-State: AOAM5317u/5teCkY10D2Q8VVweDdmDysQogfDgUzLTDFpMPSPfeMHzdE 70Qb1tzR9egnVvtZ0ze4TBRL9YPChizRtpePSvo= X-Google-Smtp-Source: ABdhPJwffdh0M4nKESM3uobBBa2UiPZNyiH0quaHQH7SdqqFBJmq9vJwUIlp8hKAj1M9RkRbx/6mjjn2BU9Qv+N0dQQ= X-Received: by 2002:a9d:6546:: with SMTP id q6mr16850481otl.365.1592901310350; Tue, 23 Jun 2020 01:35:10 -0700 (PDT) MIME-Version: 1.0 References: <1591555267-21822-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1591555267-21822-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Tue, 23 Jun 2020 09:34:44 +0100 Message-ID: Subject: Re: [PATCH 03/11] arm64: dts: renesas: hihope-common: Separate out Rev.2.0 specific into hihope-common-rev2.dtsi file To: Geert Uytterhoeven Cc: Lad Prabhakar , Magnus Damm , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Tue, Jun 23, 2020 at 9:14 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, Jun 23, 2020 at 9:51 AM Lad, Prabhakar > wrote: > > On Mon, Jun 8, 2020 at 3:59 PM Lad, Prabhakar > > wrote: > > > On Mon, Jun 8, 2020 at 3:47 PM Geert Uytterhoeven wrote: > > > > On Sun, Jun 7, 2020 at 8:41 PM Lad Prabhakar > > > > wrote: > > > > > Separate out Rev.2.0 specific hardware changes into > > > > > hihope-common-rev2.dtsi file so that hihope-common.dtsi can be used > > > > > by all the variants for RZ/G2M[N] boards. > > > > > > > > > > Signed-off-by: Lad Prabhakar > > > > > Reviewed-by: Marian-Cristian Rotariu > > > > > > @@ -0,0 +1,101 @@ > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > +/* > > > > > + * Device Tree Source for the HiHope RZ/G2[MN] main board Rev.2.0 common > > > > > + * parts > > > > > + * > > > > > + * Copyright (C) 2020 Renesas Electronics Corp. > > > > > + */ > > > > > + > > > > > +#include > > > > > + > > > > > +/ { > > > > > + leds { > > > > > + compatible = "gpio-leds"; > > > > > + > > > > > + bt_active_led { > > > > > + label = "blue:bt"; > > > > > + gpios = <&gpio7 0 GPIO_ACTIVE_HIGH>; > > > > > + linux,default-trigger = "hci0-power"; > > > > > + default-state = "off"; > > > > > + }; > > > > > + > > > > > + led0 { > > > > > + gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>; > > > > > + }; > > > > > + > > > > > + led1 { > > > > > + gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; > > > > > + }; > > > > > + > > > > > + led2 { > > > > > + gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>; > > > > > + }; > > > > > + > > > > > + led3 { > > > > > + gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>; > > > > > + }; > > > > > > > > led1, led2, and led3 are present on both, so I'd keep them in > > > > hihope-common.dtsi. > > > > > > > The leds defined in hihope-common-rev4.dtsi are as per the label names > > > on the schematics/board so that it's easier to identify the LED's by > > > name. > > > > > I was waiting on the above to be confirmed. > > I can confirm the naming of the LEDs on the rev4 board. > However, following the same reasoning, the rev2 LEDs should be renamed > led2201, led2202, led2203, and led2402 ;-) I didn't want to change any behaviour if some was using the LED's with names. > Does anyone rely on the names? If not, it may make sense to use the > rev4 names for both, in the common file? > Not sure, but I'll take your suggestion and just name them as per rev4 naming. > Not even considering the switches... > Seems they forgot to rename switches SW220[123] when renaming LED220[123]. > Worse, on rev2, you have SW220_2_/LED220_1_ sharing a GPIO, and > SW220_1_/LED220_2_ sharing another one. > > And on rev4, GP6_11/GP_LED/TSW_0_ is driving LED_4_ and SW220_2_? > > Conclusion: I don't care how you name them ;-) > :) Cheers, --Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds