From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: vpss: fix the order of resource clean up
Date: Mon, 1 Apr 2019 08:25:40 +0100 [thread overview]
Message-ID: <CA+V-a8tXq2CjZ+LmOzyg_Jr9Mc0MevjYBFfQ+FJwsW+UDd60_g@mail.gmail.com> (raw)
In-Reply-To: <1553602674-531-1-git-send-email-mojha@codeaurora.org>
On Tue, Mar 26, 2019 at 12:18 PM Mukesh Ojha <mojha@codeaurora.org> wrote:
>
> Clean up of resources should be in reverse order of vpss_init().
> Fix this inside vpss_exit().
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> ---
> drivers/media/platform/davinci/vpss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
--Prabhakar Lad
> diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c
> index 19cf685..e380fd3 100644
> --- a/drivers/media/platform/davinci/vpss.c
> +++ b/drivers/media/platform/davinci/vpss.c
> @@ -507,9 +507,9 @@ static int vpss_resume(struct device *dev)
>
> static void vpss_exit(void)
> {
> + platform_driver_unregister(&vpss_driver);
> iounmap(oper_cfg.vpss_regs_base2);
> release_mem_region(VPSS_CLK_CTRL, 4);
> - platform_driver_unregister(&vpss_driver);
> }
>
> static int __init vpss_init(void)
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
> Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2019-04-01 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 12:17 [PATCH] media: vpss: fix the order of resource clean up Mukesh Ojha
2019-04-01 7:25 ` Lad, Prabhakar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8tXq2CjZ+LmOzyg_Jr9Mc0MevjYBFfQ+FJwsW+UDd60_g@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mojha@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).