From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings
Date: Thu, 13 Aug 2020 12:20:58 +0100 [thread overview]
Message-ID: <CA+V-a8toVwB+_=RmQ4DjhRaTyHoMOPHW2a42NTEUqW+FSv1tmg@mail.gmail.com> (raw)
In-Reply-To: <20200813111123.GD6057@pendragon.ideasonboard.com>
Hi Laurent,
On Thu, Aug 13, 2020 at 12:11 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Prabhakar,
>
> On Thu, Aug 13, 2020 at 12:08:58PM +0100, Lad, Prabhakar wrote:
> > On Thu, Aug 13, 2020 at 11:59 AM Laurent Pinchart wrote:
> > > On Thu, Aug 13, 2020 at 11:38:03AM +0100, Lad, Prabhakar wrote:
> > >> On Thu, Aug 13, 2020 at 10:05 AM Geert Uytterhoeven wrote:
> > >>> On Wed, Aug 12, 2020 at 4:02 PM Lad Prabhakar wrote:
> > >>>> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > >>>>
> > >>>> Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU bindings.
> > >>>>
> > >>>> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > >>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >>>> ---
> > >>>> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> > >>>> 1 file changed, 2 insertions(+)
> > >>>>
> > >>>> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
> > >>>> index 51cd4d162770..67cded5ad827 100644
> > >>>> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> > >>>> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> > >>>> @@ -10,6 +10,7 @@ Required Properties:
> > >>>> - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
> > >>>> - "renesas,du-r8a774b1" for R8A774B1 (RZ/G2N) compatible DU
> > >>>> - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
> > >>>> + - "renesas,du-r8a774e1" for R8A774E1 (RZ/G2H) compatible DU
> > >>>> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> > >>>> - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> > >>>> - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> > >>>> @@ -75,6 +76,7 @@ corresponding to each DU output.
> > >>>> R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
> > >>>> R8A774B1 (RZ/G2N) DPAD 0 HDMI 0 LVDS 0 -
> > >>>> R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
> > >>>> + R8A774E1 (RZ/G2H) DPAD 0 HDMI 0 LVDS 0 -
> > >>>
> > >>> As LVDS 0 is the fourth channel (DU3), should it be listed under port 3
> > >>> instead of port 2?
> > >>>
> > >>> I know we did it the same for R-Car M3-N and RZ/G2N.
> > >>> But my main worry is adding support for R-Car H3-N later.
> > >
> > > Why should we do so ? The port number here isn't tied to the DU channel
> > > number. It only identifies the output port. Many DUs can route DU
> > > channel outputs to different output ports.
> > >
> > The binding document (renesas,du.txt) does state that "The following
> > table lists for each supported model the port number corresponding to
> > each DU output.", hence the confusion.
>
> It can be a bit confusing indeed. "DU output" here refers to the output
> of the whoel DU, made of individual DU channels. Each DU channel is
> listed as a DU device in the datasheet, and collectively they are the DU
> device that Linux handles.
>
Thanks for the clarification, that clears up the confusion.
Cheers,
Prabhakar
next prev parent reply other threads:[~2020-08-13 11:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:02 [PATCH 0/9] r8a774e1 add support for DU, HDMI and LVDS Lad Prabhakar
2020-08-12 14:02 ` [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings Lad Prabhakar
2020-08-12 16:09 ` Laurent Pinchart
2020-08-13 9:05 ` Geert Uytterhoeven
2020-08-13 10:38 ` Lad, Prabhakar
2020-08-13 10:59 ` Laurent Pinchart
2020-08-13 11:08 ` Lad, Prabhakar
2020-08-13 11:11 ` Laurent Pinchart
2020-08-13 11:20 ` Lad, Prabhakar [this message]
2020-08-12 14:02 ` [PATCH 2/9] drm: rcar-du: Add support for R8A774E1 SoC Lad Prabhakar
2020-08-12 16:13 ` Laurent Pinchart
2020-08-12 14:02 ` [PATCH 3/9] arm64: dts: renesas: r8a774e1: Populate DU device node Lad Prabhakar
2020-08-12 16:16 ` Laurent Pinchart
2020-08-13 9:08 ` Geert Uytterhoeven
2020-08-12 14:02 ` [PATCH 4/9] dt-bindings: display: renesas,lvds: Document r8a774e1 bindings Lad Prabhakar
2020-08-12 16:17 ` Laurent Pinchart
2020-08-12 16:18 ` Laurent Pinchart
2020-08-13 9:09 ` Geert Uytterhoeven
2020-08-24 23:20 ` [PATCH 4/9] dt-bindings: display: renesas, lvds: " Rob Herring
2020-08-12 14:02 ` [PATCH 5/9] dt-bindings: display: renesas,dw-hdmi: Add r8a774e1 support Lad Prabhakar
2020-08-12 16:20 ` Laurent Pinchart
2020-08-13 9:10 ` Geert Uytterhoeven
2020-08-24 23:20 ` [PATCH 5/9] dt-bindings: display: renesas, dw-hdmi: " Rob Herring
2020-08-12 14:02 ` [PATCH 6/9] arm64: dts: renesas: r8a774e1: Populate HDMI encoder node Lad Prabhakar
2020-08-12 16:28 ` Laurent Pinchart
2020-08-13 9:14 ` Geert Uytterhoeven
2020-08-12 14:02 ` [PATCH 7/9] drm: rcar-du: lvds: Add support for R8A774E1 SoC Lad Prabhakar
2020-08-12 16:29 ` Laurent Pinchart
2020-08-12 14:02 ` [PATCH 8/9] arm64: dts: renesas: r8a774e1: Add LVDS device node Lad Prabhakar
2020-08-12 16:31 ` Laurent Pinchart
2020-08-13 9:17 ` Geert Uytterhoeven
2020-08-12 14:02 ` [PATCH 9/9] arm64: dts: renesas: r8a774e1-hihope-rzg2h: Setup DU clocks Lad Prabhakar
2020-08-12 16:36 ` Laurent Pinchart
2020-08-13 12:57 ` Laurent Pinchart
2020-08-13 9:19 ` Geert Uytterhoeven
2020-08-12 16:38 ` [PATCH 0/9] r8a774e1 add support for DU, HDMI and LVDS Laurent Pinchart
2020-08-12 16:43 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+V-a8toVwB+_=RmQ4DjhRaTyHoMOPHW2a42NTEUqW+FSv1tmg@mail.gmail.com' \
--to=prabhakar.csengg@gmail.com \
--cc=Chris.Paterson2@renesas.com \
--cc=airlied@linux.ie \
--cc=biju.das.jz@bp.renesas.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).