From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Rob Herring <robh+dt@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>
Subject: Re: [PATCH v3 04/10] ata: pata_platform: Use platform_get_irq_optional() to get the interrupt
Date: Tue, 4 Jan 2022 19:42:03 +0000 [thread overview]
Message-ID: <CA+V-a8uEALwWXhsBZB6ct482W6iexuGaguVT5zxJiGQ6nL7hYg@mail.gmail.com> (raw)
In-Reply-To: <25bf8893-7369-954e-bd5b-f3d592af5b09@omp.ru>
Hi Sergey,
Thank you for the review.
On Mon, Dec 27, 2021 at 7:58 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> On 12/24/21 4:12 PM, Lad Prabhakar wrote:
>
> > To be consistent with pata_of_platform driver use
> > platform_get_irq_optional() instead of
> > platform_get_resource(pdev, IORESOURCE_IRQ, 0).
>
> But why can't we be consistent with the unpatched pata_of_platfrom(), and then
> convert to platform_get_irq_optional() after merging both drivers?
> I'd like to avoid patching the driver to be gone if possible...
>
Basically to have members of struct pata_platform_priv{} in one shot,
instead of changing them again and again. btw you are OK with patching
for 06/10.
Cheers,
Prabhakar
next prev parent reply other threads:[~2022-01-04 19:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 13:12 [PATCH v3 00/10] ata: pata_platform: Refurbish the driver Lad Prabhakar
2021-12-24 13:12 ` [PATCH v3 01/10] ata: pata_platform: Make use of platform_get_mem_or_io() Lad Prabhakar
2021-12-24 17:56 ` Sergey Shtylyov
2021-12-24 18:01 ` Lad, Prabhakar
2021-12-24 13:12 ` [PATCH v3 02/10] ata: pata_platform: Drop use of unlikely() in pata_platform_probe Lad Prabhakar
2021-12-24 17:54 ` Sergey Shtylyov
2021-12-24 18:02 ` Lad, Prabhakar
2021-12-26 11:56 ` Damien Le Moal
2021-12-26 14:21 ` Lad, Prabhakar
2021-12-24 13:12 ` [PATCH v3 03/10] ata: pata_of_platform: Use platform_get_irq_optional() to get the interrupt Lad Prabhakar
2021-12-25 17:01 ` Andy Shevchenko
2021-12-25 17:13 ` Lad, Prabhakar
2021-12-27 19:48 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 04/10] ata: pata_platform: " Lad Prabhakar
2021-12-27 19:58 ` Sergey Shtylyov
2021-12-28 9:33 ` Sergey Shtylyov
2022-01-04 19:42 ` Lad, Prabhakar [this message]
2021-12-24 13:12 ` [PATCH v3 05/10] ata: pata_platform: Drop checking IRQ number Lad Prabhakar
2021-12-27 20:03 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 06/10] ata: pata_of_platform: Make use of platform_get_mem_or_io() Lad Prabhakar
2021-12-27 20:05 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 07/10] ata: pata_platform: Merge pata_of_platform into pata_platform Lad Prabhakar
2021-12-25 17:16 ` Andy Shevchenko
2021-12-25 17:25 ` Lad, Prabhakar
2021-12-25 17:37 ` Andy Shevchenko
2021-12-27 20:54 ` Sergey Shtylyov
2021-12-27 20:55 ` Sergey Shtylyov
2021-12-27 20:36 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 08/10] ata: pata_platform: Drop validating num_resources count Lad Prabhakar
2021-12-27 20:38 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 09/10] ata: pata_platform: Sort the #includes alphabetically Lad Prabhakar
2021-12-27 20:40 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 10/10] ata: pata_platform: Make use of GENMASK() macro Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8uEALwWXhsBZB6ct482W6iexuGaguVT5zxJiGQ6nL7hYg@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).