From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74FEC76191 for ; Wed, 24 Jul 2019 10:47:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF7D3229ED for ; Wed, 24 Jul 2019 10:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EK8m57GW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727323AbfGXKrq (ORCPT ); Wed, 24 Jul 2019 06:47:46 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:32790 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfGXKrq (ORCPT ); Wed, 24 Jul 2019 06:47:46 -0400 Received: by mail-ot1-f65.google.com with SMTP id q20so47310235otl.0; Wed, 24 Jul 2019 03:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c/u6Ul6eSGfqr/SaYhCYPb/PuuVt6oryQFyHXq1Lw6M=; b=EK8m57GWsorqR6PN8Fc1QeDOA+iyhHouiH0L7g4Brjxe4bNV0GK1HJ++2mdbcK3QP2 dzKo0BaHn/mLCoXfbgS+IopyHEHSt6xditsw2HDjZfPHCcqSyeP4MgJoUVKlAyjxkPHO 9JPLKaHM9xp2FtoiB5CO//8r31Ju5aaAKVM5fSBkm3Y7/IRMVbRNMqkiALqwdvvZe3xT 4TzTCIPeiLGVc2WpWx1XZTarUUqm4cGEtm1cU7JzrhD51J16YS4unIMTA07WwY+nwb9b N0/b6qi18o9lZcwJF0tKSUvE00WrZEMZarAsxD/ARIBL8ANiloNL4gxYOWB+jWJ0W6vG gSfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c/u6Ul6eSGfqr/SaYhCYPb/PuuVt6oryQFyHXq1Lw6M=; b=DIwVWuiNlzVEyuvR8RG5oCLJj2hWErFAJgr68iqOLLB78/6XeZw0kHG34oIy5XjDTk iTWTfL9lFIqvtx12r0fcLoZGGLllt+PSJLCMqaYR0px+y96VXhd4jhzFIN4NRnrzKQpJ kewA4lXfcU1TLi3aKBHPt0dZV3tdT7GMDuH+iBbSUGW/tiWtj4KjzGZ863e3QYTpKmpp HBZqyr44vIyoCB/mUwExCtlrx1b4QiBskGSKCHcbuIAufpaVOA8Eo1lS9I2pDs8k+V1P d4rqrKcf7zZomQMr6AFHN1kURyyIc3RSfjZ8xKsj92p4XBuGS9ZP+nHI0PT/X5SVrMJR QIRA== X-Gm-Message-State: APjAAAWfBnGIQiifINx3y28rygh0Mg+j4CKGLP/R+xvu1cN2niOWDHcM itrOtq7Z7gfDAsMYbAM1VzgQWkUliAnTBVBhaic= X-Google-Smtp-Source: APXvYqz9QA6BCf/a/Wq0ly9dhpDoTP4VWgL7lYOSAzAslHP6ajhVOITUuZlJh+mqz4Al7PbxDBDxMiZxoUsC6o+NTws= X-Received: by 2002:a05:6830:157:: with SMTP id j23mr36863462otp.198.1563965264852; Wed, 24 Jul 2019 03:47:44 -0700 (PDT) MIME-Version: 1.0 References: <20190723104602.3215243-1-arnd@arndb.de> In-Reply-To: <20190723104602.3215243-1-arnd@arndb.de> From: "Lad, Prabhakar" Date: Wed, 24 Jul 2019 11:47:17 +0100 Message-ID: Subject: Re: [PATCH] media: staging: davinci: remove vpfe driver To: Arnd Bergmann Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Laurent Pinchart , Sekhar Nori , Greg Kroah-Hartman , Hans Verkuil , Sakari Ailus , LKML , OSUOSL Drivers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2019 at 11:46 AM Arnd Bergmann wrote: > > The davinci_vpfe driver was merged into staging back in 2012 by Manjunath > Hadli from TI, with a long TODO list. > > For all I can tell, since then it has only seen fixes for compile-time > issues and global cleanups, but nobody has actually worked on the items > on the TODO list. > > To make things worse, the driver in its current form is incompatible with > the platform code in arch/arm/mach-davinci, i.e. the driver expects to > get its platform_data passed to the device as a 'struct vpfe_config', > but uses a differnet definition for that structure compared to what the s/differnet/different > platform uses. > > Finally, there is another driver for the same device in > drivers/media/platform/davinci/vpfe_capture.c. From all I can tell, the > staging version was originally a copy of a more featureful driver in TI's > downstream kernels. However, that kernel no longer supports dm365 after > linux-2.6.37, and the mainline version moved in a different direction. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/media/Kconfig | 2 - > drivers/staging/media/Makefile | 1 - > drivers/staging/media/davinci_vpfe/Kconfig | 13 - > drivers/staging/media/davinci_vpfe/Makefile | 11 - > drivers/staging/media/davinci_vpfe/TODO | 38 - > .../media/davinci_vpfe/davinci-vpfe-mc.txt | 154 -- > .../media/davinci_vpfe/davinci_vpfe_user.h | 1287 ---------- > .../staging/media/davinci_vpfe/dm365_ipipe.c | 1852 --------------- > .../staging/media/davinci_vpfe/dm365_ipipe.h | 174 -- > .../media/davinci_vpfe/dm365_ipipe_hw.c | 1038 -------- > .../media/davinci_vpfe/dm365_ipipe_hw.h | 556 ----- > .../media/davinci_vpfe/dm365_ipipeif.c | 1070 --------- > .../media/davinci_vpfe/dm365_ipipeif.h | 228 -- > .../media/davinci_vpfe/dm365_ipipeif_user.h | 90 - > .../staging/media/davinci_vpfe/dm365_isif.c | 2097 ----------------- > .../staging/media/davinci_vpfe/dm365_isif.h | 200 -- > .../media/davinci_vpfe/dm365_isif_regs.h | 291 --- > .../media/davinci_vpfe/dm365_resizer.c | 1995 ---------------- > .../media/davinci_vpfe/dm365_resizer.h | 241 -- > drivers/staging/media/davinci_vpfe/vpfe.h | 83 - > .../media/davinci_vpfe/vpfe_mc_capture.c | 716 ------ > .../media/davinci_vpfe/vpfe_mc_capture.h | 90 - > .../staging/media/davinci_vpfe/vpfe_video.c | 1646 ------------- > .../staging/media/davinci_vpfe/vpfe_video.h | 150 -- > 24 files changed, 14023 deletions(-) > delete mode 100644 drivers/staging/media/davinci_vpfe/Kconfig > delete mode 100644 drivers/staging/media/davinci_vpfe/Makefile > delete mode 100644 drivers/staging/media/davinci_vpfe/TODO > delete mode 100644 drivers/staging/media/davinci_vpfe/davinci-vpfe-mc.txt > delete mode 100644 drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe.c > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe.h > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipeif.c > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipeif.h > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipeif_user.h > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_isif.c > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_isif.h > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_isif_regs.h > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_resizer.c > delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_resizer.h > delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe.h > delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c > delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_mc_capture.h > delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_video.c > delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_video.h > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad