From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72880C4320E for ; Thu, 12 Aug 2021 08:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5443960F21 for ; Thu, 12 Aug 2021 08:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235173AbhHLI0H (ORCPT ); Thu, 12 Aug 2021 04:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233921AbhHLI0F (ORCPT ); Thu, 12 Aug 2021 04:26:05 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 549AEC061765; Thu, 12 Aug 2021 01:25:40 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id p4so10170420yba.3; Thu, 12 Aug 2021 01:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x/U+rWN+j9s5n6sG47stTzPJLVQ6JGcCvmKcR9Yt9yo=; b=UgnsKX7TLNzzF/9+WS3sfIEn6o2OljDdMjYuQ5msxZD+6I2cjv7AmD/zELORSzSftC asByK0KSSRLNdqLCN4k+A7M1UPcU6jd94ASgCl93MwmN9l6tbo5hgWSWQZ0k+41tDJbY qFH0TeDsqW03NKi9NKIg1m6xuYeqZ94xSyR2mo7altRYDRT5uZ+KhSnqQoUpQtLf++ib FxXM7Ps/nxG7vUXLVtTtvQi7+Jz/vUYh/Lashy0oRURTy7Q4y8DDUihUonqY/T46T2jW JnLZg/Vxu3CE6tOziASVdCURMMyNJG05KEVyW9yVLZ4Jp3PGbk71DiMVfqRvYprjXjqF iIXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x/U+rWN+j9s5n6sG47stTzPJLVQ6JGcCvmKcR9Yt9yo=; b=ZCUliyC8S1t/tnfHdX++jTLn5+zR5Zc/qs+dGqaPE4qXue7QLATsihklM+fbi99TK6 E3uFx3zckvibShNuWyWnbyreGgU0Q1D81b4o6FO8xig0vOSVbyutglmKx4BNgXegOj8R UTrHINvbB6ZdpsMUkTDpgewlYBp/dAEeoG0ebXOWLGaRShGbKVYFHEfyjZHq0CthsJoC fGRsxiFrtj8GmpOdXBFGAYVyMjdP2F5W/u8I7fSVwkvwP6SvwzIORiF7FAgbd4YW7yEC yv4S+7OBe8fgLllDYUEc+DfgaHiVr2VVBZVC7icDrr5QtFq8WigE4xMEraZ9LSGVtHye nAew== X-Gm-Message-State: AOAM532WdWEgf84Y7Z5AHQEus2wm5oZsFpviHFgIjcJyVuUkzzKaq1do lsVF77xURb1RrOaI9731UgfuCuc/XbXG0ZJQvYc= X-Google-Smtp-Source: ABdhPJzShcvdNPe4dEbFW/Cw7BUKpb3CUwW1dyJcLF6u+HxW9DDMR6aMvCZoKTdlZvWdgdqMF5xGYiCytbTEUrkW4pc= X-Received: by 2002:a5b:d45:: with SMTP id f5mr2930306ybr.179.1628756739522; Thu, 12 Aug 2021 01:25:39 -0700 (PDT) MIME-Version: 1.0 References: <20210727112328.18809-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210727112328.18809-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 12 Aug 2021 09:25:13 +0100 Message-ID: Subject: Re: [PATCH v4 2/4] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver To: Geert Uytterhoeven Cc: Lad Prabhakar , Rob Herring , Linus Walleij , Magnus Damm , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , Linux Kernel Mailing List , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the review. On Tue, Aug 10, 2021 at 10:13 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, Jul 27, 2021 at 1:23 PM Lad Prabhakar > wrote: > > Add support for pin and gpio controller driver for RZ/G2L SoC. > > > > Based on a patch in the BSP by Hien Huynh . > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Biju Das > > Thanks for your patch! > > > --- /dev/null > > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > > > +static void rzg2l_pinctrl_clk_disable(void *data) > > +{ > > + struct clk *clk = data; > > No need for the intermediate variable. > Agreed. > > + > > + clk_disable_unprepare(clk); > > +} > > + > > +static int rzg2l_pinctrl_probe(struct platform_device *pdev) > > +{ > > + struct rzg2l_pinctrl *pctrl; > > + int ret; > > + > > + pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > > + if (!pctrl) > > + return -ENOMEM; > > + > > + pctrl->dev = &pdev->dev; > > + > > + pctrl->data = of_device_get_match_data(&pdev->dev); > > + if (!pctrl->data) > > + return -EINVAL; > > + > > + pctrl->base = devm_platform_ioremap_resource(pdev, 0); > > + if (IS_ERR(pctrl->base)) > > + return PTR_ERR(pctrl->base); > > + > > + pctrl->clk = devm_clk_get(pctrl->dev, NULL); > > + if (IS_ERR(pctrl->clk)) { > > + ret = PTR_ERR(pctrl->clk); > > + dev_err(pctrl->dev, "failed to get GPIO clk : %i\n", ret); > > + return ret; > > + }; > > + > > + spin_lock_init(&pctrl->lock); > > + > > + platform_set_drvdata(pdev, pctrl); > > + > > + ret = clk_prepare_enable(pctrl->clk); > > + if (ret) { > > + dev_err(pctrl->dev, "failed to enable GPIO clk: %i\n", ret); > > + return ret; > > + }; > > + > > + ret = devm_add_action_or_reset(&pdev->dev, rzg2l_pinctrl_clk_disable, pctrl->clk); > > This line is a bit long. > > > + if (ret) { > > + dev_err(pctrl->dev, "failed to register pinctrl clk disable devm action, %i\n", > > Elsewhere, this is called the "GPIO clk". > This line is a bit long. > agreed. > > + ret); > > + return ret; > > + } > > + > > + ret = rzg2l_pinctrl_register(pctrl); > > + if (ret) > > + return ret; > > + > > + dev_info(pctrl->dev, "%s support registered\n", DRV_NAME); > > + return 0; > > +} > > Reviewed-by: Geert Uytterhoeven > i.e. will queue in renesas-pinctrl-for-v5.15, with the above fixed, so no need > to resend. > Thank you. Cheers, Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds