From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH] clk: renesas: cpg-mssr: Add clk entry for VSPR
Date: Mon, 31 Aug 2020 15:18:29 +0100 [thread overview]
Message-ID: <CA+V-a8v-KP95VXN84JzS5tJd6=ONy0+Pvse57PqgpWp20nNRxA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVcGz_C+e49pgNM=ui8bTu6Vg0A7pZY6nq7n3RdAJObgg@mail.gmail.com>
Hi Geert,
Thank you for your review.
On Mon, Aug 31, 2020 at 1:38 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> Thanks for your patch!
>
> On Tue, Aug 25, 2020 at 3:48 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > Add clock entry 130 for VSPR module, so that this module can be used
>
> VSPR ("VSP for Resizing")
>
> > on R8A7742 (RZ/G1H) SoC.
> >
> > Note: The entry for VSPR clock was accidentally dropped from RZ/G manual
> > when all the information related to RT were removed.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > Similar details can be seen in commit 79ea9934b8df ("ARM: shmobile:
> > r8a7790: Rename VSP1_(SY|RT) clocks to VSP1_(S|R)") for R-Car H2
>
> Indeed. And R-Car H2 and other related soCs are still affected, as that
> fix never made it to the new clock drivers ;-(
>
> > --- a/drivers/clk/renesas/r8a7742-cpg-mssr.c
> > +++ b/drivers/clk/renesas/r8a7742-cpg-mssr.c
> > @@ -97,6 +97,7 @@ static const struct mssr_mod_clk r8a7742_mod_clks[] __initconst = {
> > DEF_MOD("tmu0", 125, R8A7742_CLK_CP),
> > DEF_MOD("vsp1du1", 127, R8A7742_CLK_ZS),
> > DEF_MOD("vsp1du0", 128, R8A7742_CLK_ZS),
> > + DEF_MOD("vspr", 130, R8A7742_CLK_ZS),
> > DEF_MOD("vsp1-sy", 131, R8A7742_CLK_ZS),
>
> While at it, can you please replace "vsp1-sy" by "vsps" (VSPS = "VSP
> Standard"), and fix the other drivers, too?
>
Sure i'll get that done in v2.
Cheers,
Prabhakar
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
prev parent reply other threads:[~2020-08-31 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 13:48 [PATCH] clk: renesas: cpg-mssr: Add clk entry for VSPR Lad Prabhakar
2020-08-31 12:38 ` Geert Uytterhoeven
2020-08-31 14:18 ` Lad, Prabhakar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+V-a8v-KP95VXN84JzS5tJd6=ONy0+Pvse57PqgpWp20nNRxA@mail.gmail.com' \
--to=prabhakar.csengg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).