From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] watchdog: s3c2410: Use platform_get_irq() to get the interrupt
Date: Thu, 16 Dec 2021 21:42:58 +0000 [thread overview]
Message-ID: <CA+V-a8v6-zO6rYDHyFsPZ15YyjVaoP9A=WWNLXaVfY=Kkgrr+g@mail.gmail.com> (raw)
In-Reply-To: <3733aa67-8606-58de-69cb-f7a167713da4@roeck-us.net>
Hi Guenter,
Thank you for the review.
On Thu, Dec 16, 2021 at 7:01 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 12/16/21 10:36 AM, Lad Prabhakar wrote:
> > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> > allocation of IRQ resources in DT core code, this causes an issue
> > when using hierarchical interrupt domains using "interrupts" property
> > in the node as this bypassed the hierarchical setup and messed up the
> > irq chaining.
> >
> > In preparation for removal of static setup of IRQ resource from DT core
> > code use platform_get_irq().
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > drivers/watchdog/s3c2410_wdt.c | 13 ++++++-------
> > 1 file changed, 6 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
> > index 2395f353e52d..f5aced344b7b 100644
> > --- a/drivers/watchdog/s3c2410_wdt.c
> > +++ b/drivers/watchdog/s3c2410_wdt.c
> > @@ -513,9 +513,9 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > struct s3c2410_wdt *wdt;
> > - struct resource *wdt_irq;
> > unsigned int wtcon;
> > int started = 0;
> > + int wdt_irq;
> > int ret;
> >
> > wdt = devm_kzalloc(dev, sizeof(*wdt), GFP_KERNEL);
> > @@ -536,10 +536,9 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
> > }
> > }
> >
> > - wdt_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> > - if (wdt_irq == NULL) {
> > - dev_err(dev, "no irq resource specified\n");
> > - ret = -ENOENT;
> > + wdt_irq = platform_get_irq(pdev, 0);
> > + if (wdt_irq < 0) {
> > + ret = wdt_irq;
> > goto err;
>
> All those "goto err;" statements in this function are pointless since they
> just return ret. Since this is the first of those goto statements, please
> replace it with "return wdt_irq;".
>
Sure will do and post a v2.
> Thanks,
> Guenter
>
> > }
> >
> > @@ -592,8 +591,8 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
> > dev_info(dev, "default timer value is out of range, cannot start\n");
> > }
> >
> > - ret = devm_request_irq(dev, wdt_irq->start, s3c2410wdt_irq, 0,
> > - pdev->name, pdev);
> > + ret = devm_request_irq(dev, wdt_irq, s3c2410wdt_irq, 0,
> > + pdev->name, pdev);
> > if (ret != 0) {
> > dev_err(dev, "failed to install irq (%d)\n", ret);
> > goto err_cpufreq;
> >
>
Cheers,
Prabhakar
prev parent reply other threads:[~2021-12-16 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 18:36 [PATCH] watchdog: s3c2410: Use platform_get_irq() to get the interrupt Lad Prabhakar
2021-12-16 19:01 ` Guenter Roeck
2021-12-16 21:42 ` Lad, Prabhakar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+V-a8v6-zO6rYDHyFsPZ15YyjVaoP9A=WWNLXaVfY=Kkgrr+g@mail.gmail.com' \
--to=prabhakar.csengg@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).