From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB327C4332F for ; Mon, 19 Dec 2022 11:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231945AbiLSLVe (ORCPT ); Mon, 19 Dec 2022 06:21:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbiLSLVa (ORCPT ); Mon, 19 Dec 2022 06:21:30 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CD9A2AFB; Mon, 19 Dec 2022 03:21:29 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id b69so12367200edf.6; Mon, 19 Dec 2022 03:21:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UQqA7ygsto6xaIwShunauCg+8P+zPr4dDwx6z8aEPXk=; b=Qecx+b4KPAd9/b+nHyGpQdY6ioSxL7WtnO/O8BKN3xlRrLDu4JKdWez/YZqgCM1pkU oHF+aaw7v+iHBPAflj8s1AqvmZPQf9WosqgePDkQqSAMQsZRl9uS6MDOBkJs4qLTdjLN SQApEspVNLNaQtalgfWwNv3X2bW2/XQSKHnQdyEIWc6AMe/ah26IgFYyZZGzVZxVlSit jxESMo2+x+rGcJsXCPmlVQUoUOJvFjEOzZ6pxPwjXk6pLb/8BuVYiftWXsCQRuk8IkRI 8229+/qKrVwOXwHsVskI6ZwbVklg1K/bbTEOgTzVO6ge0EC+UYkPwu05a4ta3BUOzrb8 Piwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UQqA7ygsto6xaIwShunauCg+8P+zPr4dDwx6z8aEPXk=; b=1UnEeDlM2CUgN3U1AjnZhyqKKAZv0ZDqWCq/BSLbecm/cIKWaEq2qN2Xpavmn0Y8ge QdZYlHirFXagIpZCbur3+jtbDQC3Bs/oYqZ+0B5m8hLyvD+CfNJYjW0fA8VXJjBG09rl B5709zhjZ24QmpjkNbjHPk0X7s3cUaS0DgTYFaov63sfIPXgsy7ZazEU7fUtNHtMybce ligx4YfusKz7CQSJBwdYt9mB7qVnBXS2L7XxXiHUwzKc+75x/SYgMwDuHX+kESV9DZ9e pN3dPzclp5yCWEIDKyW0Qc+8v6JlvhtHXcckJ5ubQA30IGJ20lv+aoL8Iv14NH9M/2/a v1Ow== X-Gm-Message-State: ANoB5plqBtxolRC+6dGyXsJ6G8UL9tvzYmjV2UTwlsbsA/cYwdGsM7ma hmnMr74kFtld1sAyNEtmawjmzZNez+aE8AW9xIBG2u2NSVr7tA== X-Google-Smtp-Source: AA0mqf4MJzdQeHVxrr4jU2yyYqIoZSH1BCgma3gnh1/Vinrzu8kFrTI3pr7SAtSy6Z9epAityEv24oeSY2sHT6rbsPM= X-Received: by 2002:aa7:cc08:0:b0:461:8a43:e93 with SMTP id q8-20020aa7cc08000000b004618a430e93mr10171686edt.275.1671448887967; Mon, 19 Dec 2022 03:21:27 -0800 (PST) MIME-Version: 1.0 References: <20221212115505.36770-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20221212115505.36770-5-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Mon, 19 Dec 2022 11:21:01 +0000 Message-ID: Subject: Re: [PATCH v5 4/6] riscv: mm: dma-noncoherent: Pass direction and operation to ALT_CMO_OP() To: Conor Dooley Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Conor Dooley , Samuel Holland , Guo Ren , Rob Herring , Krzysztof Kozlowski , Jisheng Zhang , Atish Patra , Anup Patel , Andrew Jones , Nathan Chancellor , Philipp Tomsich , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Lad Prabhakar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Conor, Thank you for the review. On Sat, Dec 17, 2022 at 8:52 PM Conor Dooley wrote: > > Hey Prabhakar, > > On Mon, Dec 12, 2022 at 11:55:03AM +0000, Prabhakar wrote: > > From: Lad Prabhakar > > > > Pass direction and operation to ALT_CMO_OP() macro. > > > > Vendors might want to perform different operations based on the direction > > and callbacks (arch_sync_dma_for_device/arch_sync_dma_for_cpu/ > > arch_dma_prep_coherent) so to handle such cases pass the direction and > > operation to ALT_CMO_OP() macro. This is in preparation for adding errata > > for the Andes CPU core. > > This patch seems to break the build on top of the most recent > linux-next: > ......./stuff/linux/arch/riscv/mm/pmem.c:13:53: error: too few arguments provided to function-like macro invocation > ALT_CMO_OP(clean, addr, size, riscv_cbom_block_size); > ^ > /stuff/linux/arch/riscv/include/asm/errata_list.h:127:9: note: macro 'ALT_CMO_OP' defined here > #define ALT_CMO_OP(_op, _start, _size, _cachesize, _dir, _ops) \ > ^ > .. CC block/partitions/sgi.o > .+...+/stuff/linux/arch/riscv/mm/pmem.c:13:2: error: use of undeclared identifier 'ALT_CMO_OP' > ALT_CMO_OP(clean, addr, size, riscv_cbom_block_size); > ^ > /stuff/linux/arch/riscv/mm/pmem.c:19:53: error: too few arguments provided to function-like macro invocation > ALT_CMO_OP(inval, addr, size, riscv_cbom_block_size); > ^ > /stuff/linux/arch/riscv/include/asm/errata_list.h:127:9: note: macro 'ALT_CMO_OP' defined here > #define ALT_CMO_OP(_op, _start, _size, _cachesize, _dir, _ops) \ > ^ > ........... AR lib/math/built-in.a > ./stuff/linux/arch/riscv/mm/pmem.c:19:2: .error: use of undeclared identifier 'ALT_CMO_OP' > ALT_CMO_OP(inval, addr, size, riscv_cbom_block_size); > ^ > ..4 errors generated. > > The pmem stuff is new so that'd be why it has not come up before. > > (FWIW, clang allmodconfig) > Yes I need to rebase my changes on Palmer's branch. Cheers, Prabhakar