From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3E04C3F2D1 for ; Mon, 2 Mar 2020 12:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BF532173E for ; Mon, 2 Mar 2020 12:10:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=typeblog-net.20150623.gappssmtp.com header.i=@typeblog-net.20150623.gappssmtp.com header.b="AxpP11wT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727797AbgCBMK3 (ORCPT ); Mon, 2 Mar 2020 07:10:29 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:43152 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727749AbgCBMK2 (ORCPT ); Mon, 2 Mar 2020 07:10:28 -0500 Received: by mail-lj1-f193.google.com with SMTP id e3so11449181lja.10 for ; Mon, 02 Mar 2020 04:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=typeblog-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lf5revSpm3qfJv2nXZJRbS1f7fWl78G2borqCkC/EVs=; b=AxpP11wTXpvVI79tk/T3EKzaj9yqhaWb1BUaqiCFFAo1t1sWGWC0fA+987M/VI6zSB qjuNesM2TgfdnBRH9Y9Vq+q9vp42qWrfRKPLkpfqnPiFqJniV0WFMwEtNJqQzzk5tTsY oUzAqfahRkpDxW+YTMgvsufiyvVBIxVeVw/DQ0rTw++oBvx5OLbPtqxPpjgJHddUwzF9 hV2G0nnLUBXpU+JuEA//RTFVsOfSeg+2BVuJTTjVpW257+nGRtpIgX7qIqKZsoMcRwkS gxcmSKqCoKC09KcZAUgRdcCHitAXU4657+it0pmURd3HEg90RT8n2iHxqHI4SoABNOn/ QENw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lf5revSpm3qfJv2nXZJRbS1f7fWl78G2borqCkC/EVs=; b=Yhi2J+FPNt5N6WXPCDK1EAYHxlMSv7DQ65oyL9lNhHD/XihD5oEqczEsZ+aAgYqZ/K aYDtwRzvho5bSGNBRf3FuLGLAELGBRN1YFx0EVXw+l5wzsZFkm/qLRKjuR3qfxf7qwIN TTHwERlIp/SIOImaF5jtrTA6oSB/2k9GXZgyqgxPi81fxvzzKm3x6CZceWdzhFWjJCbq nQQyarnZMkD1mM+g55ip2bu2/NzO1WWtr7A5pNgcJ1Xgo5QbNIPyMQq+nI24nXumLy4K 3cwdSPKntfPdums8BYtXKOeNztorVApGWMcxGS+obPTjNeJPLoUUTg6EdenToHf1vyVG N1cQ== X-Gm-Message-State: ANhLgQ3gUrIysyMYENKiiaDZIUZVq6fBAmRrxCdqLoyJLDf3oBKgpfpY xoTb7NtIWT6LHZJfDI7wKx/lOookPD6WvOfDV50quQ== X-Google-Smtp-Source: ADFU+vsXy4SeIjKrwpbs1vqbQniY8JnehYm6c42utMHH2tPR0dqlr+JpbkMZNot8feBlGkvR3fDWhwBRjY8nV0xQgtA= X-Received: by 2002:a2e:884c:: with SMTP id z12mr11440314ljj.55.1583151024920; Mon, 02 Mar 2020 04:10:24 -0800 (PST) MIME-Version: 1.0 References: <20190831030916.13172-1-peter@typeblog.net> <20190902124352.12291-1-peter@typeblog.net> <20190902124352.12291-2-peter@typeblog.net> In-Reply-To: From: Peter Cai Date: Mon, 2 Mar 2020 20:10:13 +0800 Message-ID: Subject: Re: [PATCH v3 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max To: Bastien Nocera Cc: Hans de Goede , Andy Shevchenko , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 2, 2020 at 7:57 PM Bastien Nocera wrote: > > On Mon, 2019-09-02 at 20:43 +0800, Peter Cai wrote: > > The firmware of GPD P2 Max could not handle panel resets although > > code > > is present in DSDT. The kernel needs to take on this job instead, but > > the DSDT does not provide _DSD, rendering kernel helpless when trying > > to > > find the respective GPIO pins. > > > > Fortunately, this time GPD has proper DMI vendor / product strings > > that > > we could match against. We simply apply an acpi_gpio_mapping table > > when > > GPD P2 Max is matched. > > > > Additionally, the DSDT definition of the irq pin specifies a wrong > > polarity. The new quirk introduced in the previous patch > > (ACPI_GPIO_QUIRK_OVERRIDE_POLARITY) is applied to correct this. > > Hans has posted a patchset which reworks GPIO access for ACPI devices. > > Could you please check whether you could rebase your patch on top of > that? > > I also think the comment in "Input: goodix - Add support for getting > IRQ + reset GPIOs on Cherry Trail devices" might also be of use: > > + case irq_pin_access_acpi_gpio: > + /* > + * The IRQ pin triggers on a falling edge, so its gets > marked > + * as active-low, use output_raw to avoid the value > inversion. > + */ > > Cheers > Sorry I forgot to notify you earlier, but it turned out that the manufacturer of the device has already applied a fix in their ACPI table after this patch was submitted and discussed. This patch is no longer needed.