From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752001AbdG1L6v (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Jul 2017 07:58:51 -0400
Received: from mail-wm0-f54.google.com ([74.125.82.54]:35134 "EHLO
        mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751697AbdG1L6t (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Jul 2017 07:58:49 -0400
MIME-Version: 1.0
In-Reply-To: <CAMi1Hd0MzZzEv5eO6OwhiB2_Q9Dczfe_nv5DGTfNbPAT8ObbxA@mail.gmail.com>
References: <20170629190211.16927-1-tkjos@google.com> <20170629190211.16927-3-tkjos@google.com>
 <CANcMJZCnDLGvm+RaN5-JwNhCNA82D3t9T6idtZTzS8+iquyukw@mail.gmail.com>
 <CANcMJZDkxZ+bOnT0Otzd+FJVmd8_+aQaMSn7=qh3ex3xwaQj1w@mail.gmail.com>
 <CA+_MTtzcVGnsF6QKiJOViFxzPttoepyrB_Osa825SWMeta5r=A@mail.gmail.com>
 <CAMi1Hd0rT8Q92DiiS0h=TZ2uK07V43NSuzN6m6aM9KtRYJhNhA@mail.gmail.com>
 <20170727132354.GA24745@kroah.com> <CAMi1Hd0MzZzEv5eO6OwhiB2_Q9Dczfe_nv5DGTfNbPAT8ObbxA@mail.gmail.com>
From: Martijn Coenen <maco@google.com>
Date: Fri, 28 Jul 2017 13:58:47 +0200
Message-ID: <CA+_MTtzeB_0XNE1m0jLUiKucMcokn=-kpTn9RGpmvb-fxmekAg@mail.gmail.com>
Subject: Re: [PATCH 02/37] binder: use group leader instead of open thread
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        John Stultz <john.stultz@linaro.org>, Todd Kjos <tkjos@android.com>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        devel@driverdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Todd Kjos <tkjos@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I took the time to look at what else is different between common and
upstream, and just sent 3 patches to LKML to reconcile. One of the 3
fixes this particular problem.

On Thu, Jul 27, 2017 at 3:42 PM, Amit Pundir <amit.pundir@linaro.org> wrote:
> On 27 July 2017 at 18:53, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>> On Thu, Jul 27, 2017 at 02:38:30PM +0530, Amit Pundir wrote:
>>> Hi,
>>>
>>> On 25 July 2017 at 14:43, Martijn Coenen <maco@google.com> wrote:
>>> > Hi John,
>>> >
>>> > On Mon, Jul 24, 2017 at 11:07 PM, John Stultz <john.stultz@linaro.org> wrote:
>>> >>
>>> >> 12-31 16:00:36.632  2518  2584 E hw-ProcessState: Using /dev/hwbinder
>>> >> failed: unable to mmap transaction memory.
>>> >
>>> > This doesn't look right. Is there anything in the kernel log?
>>>
>>> There is a slight difference in this patch and the one that got pushed
>>> in android-4.9[1]. I cherry-picked those changes and got BT/WiFi
>>> working again on Hikey with mainline tracking (4.13-rc2) tree.
>>>
>>> Regards,
>>> Amit Pundir
>>> [1] https://android.googlesource.com/kernel/common/+/872c26eb0776ef160447d8703779e2bce0b7230a%5E%21/#F0
>>
>> And what is that difference?
>
> These couple of lines of change:
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index f7665c31feca..d7291a5a13e1 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -3362,7 +3362,7 @@ static int binder_mmap(struct file *filp, struct
> vm_area_struct *vma)
>         const char *failure_string;
>         struct binder_buffer *buffer;
>
> -       if (proc->tsk != current)
> +       if (proc->tsk != current->group_leader)
>                 return -EINVAL;
>
>         if ((vma->vm_end - vma->vm_start) > SZ_4M)
> @@ -3466,6 +3466,7 @@ static int binder_open(struct inode *nodp,
> struct file *filp)
>                 return -ENOMEM;
>         get_task_struct(current->group_leader);
>         proc->tsk = current->group_leader;
> +       proc->vma_vm_mm = current->group_leader->mm;
>         INIT_LIST_HEAD(&proc->todo);
>         init_waitqueue_head(&proc->wait);
>         proc->default_priority = task_nice(current);
>
> John reported hw_binder mmap failure in his logcat. So I'm assuming
> that the check in binder_mmap is where the binder failed and returned.
>
> Regards,
> Amit Pundir