Re: [PATCH] pnfs: Automatically select blocks & objects layouts

From: Peng Tao <bergwolf@gmail.com>
To: Jim Rees <rees@umich.edu>, Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@tonian.com>,
	Sorin Faibish <sfaibish@emc.com>,
	peter honeyman <honey@citi.umich.edu>,
	tao.peng@emc.com, torvalds@linux-foundation.org,
	rdunlap@xenotime.net, Trond.Myklebust@netapp.com,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org, "Welch, Brent" <welch@panasas.com>
Subject: Re: [PATCH] pnfs: Automatically select blocks & objects layouts
Date: Fri, 12 Aug 2011 07:47:20 +0800	[thread overview]
Message-ID: <CA+a=Yy5dgW99H8pTokUZDTJaS_uDS_vKfUeR+i8QNcCwtdFCAQ@mail.gmail.com> (raw)
In-Reply-To: <20110811221305.GA8608@merit.edu>

On Fri, Aug 12, 2011 at 6:13 AM, Jim Rees <rees@umich.edu> wrote:
> Boaz Harrosh wrote:
>
>  What about the below? based on v3.1-rc1
>
>  ----
>  From: Boaz Harrosh <bharrosh@panasas.com>
>  Subject: [PATCH] pnfs: Automatically select blocks & objects layouts
>
>  Just like files-layout, blocks & objects layouts are part of the
>  NFS 4.1 protocol and should be automatically selected if NFS_4_1
>  is selected. The small problem is that these depend on other
>  Kernel support being present, while files only depends on NFS
>  itself.
>
>  This patch removes from the user choice the presence of objects
>  and blocks layout. But makes sure these are selected only if
>  the depended subsystems are present in the Kernel.
>
>  Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>
> Acked-by: Jim Rees <rees@umich.edu>
>
> I think this is what we want.  There is no point allowing the user to pick
> and choose various layout drivers.  If they have selected nfs4.1 they should
> get all the layout drivers their kernel will support, based on the
> dependencies.
>
I agree automatically selecting is more reasonable.
Acked-by: Peng Tao <peng_tao@emc.com>


-- 
Thanks,
-Bergwolf