From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752735AbcGIHgS (ORCPT <rfc822;w@1wt.eu>);
	Sat, 9 Jul 2016 03:36:18 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35041 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750716AbcGIHgF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 9 Jul 2016 03:36:05 -0400
MIME-Version: 1.0
In-Reply-To: <CA+aCy1ExM1HWpwTf95_7g3U4+Y72Ge3BcHCsPNc0fF1=5JdUwA@mail.gmail.com>
References: <1467284524-15676-1-git-send-email-pranjas@gmail.com>
 <1467284524-15676-2-git-send-email-pranjas@gmail.com> <CA+aCy1ExM1HWpwTf95_7g3U4+Y72Ge3BcHCsPNc0fF1=5JdUwA@mail.gmail.com>
From: Pranay Srivastava <pranjas@gmail.com>
Date: Sat, 9 Jul 2016 13:06:02 +0530
Message-ID: <CA+aCy1ETRiwzF_kmthSMY-R4Mvp4hjwhf2-vX1f=ZEv1P=yuSQ@mail.gmail.com>
Subject: Re: [PATCH v4 1/5]nbd: cleanup nbd_set_socket
To: Markus Pargmann <mpa@pengutronix.de>, nbd-general@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Cc: "Pranay Kr. Srivastava" <pranaykumar.srivastava@cognizant.com>,
        "Pranay Kr . Srivastava" <pranjas@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 7, 2016 at 8:26 PM, Pranay Srivastava <pranjas@gmail.com> wrote:
> On Thu, Jun 30, 2016 at 4:32 PM, Pranay Kr. Srivastava
> <pranjas@gmail.com> wrote:
>> From: "Pranay Kr. Srivastava" <pranaykumar.srivastava@cognizant.com>
>>
>> This patch
>> 1) uses spin_lock instead of irq version.
>>
>> 2) removes the goto statement in case a socket
>>    is already assigned with simple if-else statement.
>>
>> Signed-off-by: Pranay Kr. Srivastava <pranjas@gmail.com>
>> ---
>>  drivers/block/nbd.c | 15 +++++----------
>>  1 file changed, 5 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
>> index 56f7f5d..766c401 100644
>> --- a/drivers/block/nbd.c
>> +++ b/drivers/block/nbd.c
>> @@ -643,17 +643,12 @@ static int nbd_set_socket(struct nbd_device *nbd, struct socket *sock)
>>  {
>>         int ret = 0;
>>
>> -       spin_lock_irq(&nbd->sock_lock);
>> -
>> -       if (nbd->sock) {
>> +       spin_lock(&nbd->sock_lock);
>> +       if (nbd->sock)
>>                 ret = -EBUSY;
>> -               goto out;
>> -       }
>> -
>> -       nbd->sock = sock;
>> -
>> -out:
>> -       spin_unlock_irq(&nbd->sock_lock);
>> +       else
>> +               nbd->sock = sock;
>> +       spin_unlock(&nbd->sock_lock);
>>
>>         return ret;
>>  }
>> --
>> 1.9.1
>>
>
> Hi Markus,
>
> Did you get a chance to review V4 of this series.
>
> --
>         ---P.K.S

Ping ?

-- 
        ---P.K.S