From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753650AbcE3Dft (ORCPT ); Sun, 29 May 2016 23:35:49 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35461 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbcE3Dfs (ORCPT ); Sun, 29 May 2016 23:35:48 -0400 MIME-Version: 1.0 In-Reply-To: <1464089188-6155-1-git-send-email-pranjas@gmail.com> References: <1464089188-6155-1-git-send-email-pranjas@gmail.com> Date: Mon, 30 May 2016 09:05:46 +0530 Message-ID: Subject: Re: [PATCH 0/4]nbd: fixes for nbd From: Pranay Srivastava To: Markus Pargmann , nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: "Pranay Kr. Srivastava" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Tue, May 24, 2016 at 4:56 PM, Pranay Kr. Srivastava wrote: > This patch series fixes the following > > 1) fix might_sleep warning on socket shutdown: > Fix sock_shutdown to avoid calling kernel_sock_shutdown > while holding spin_lock. > > 2)fix various coding standard warnings > Make shutdown get called in a process context instead, using > system_wq. > > 3) make nbd device wait for its users. > When a timeout or error occurs then nbd driver simply kills > the block device. Many filesystem(s) example ext2/ext3 don't > expect their buffer heads to disappear like that. Fix this > by making nbd device wait for its users. > > 4) use device_attr macros for sysfs attribute > use DEVICE_ATTR_RO for sysfs pid attribute. > > Pranay Kr. Srivastava (4): > fix might_sleep warning on socket shutdown. > fix various coding standard warnings > make nbd device wait for its users. > use device_attr macros for sysfs attribute > > drivers/block/nbd.c | 150 +++++++++++++++++++++++++++++++++++---------------- > 1 file changed, 105 insertions(+), 45 deletions(-) > > -- > 1.7.9.5 > Can anyone review this? -- ---P.K.S