From: Jason Dillaman <jdillama@redhat.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: KAMEI Hitoshi <hitoshi.kamei.xm@hitachi.com>,
Sage Weil <sage@redhat.com>, Alex Elder <elder@kernel.org>,
Ceph Development <ceph-devel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] rbd: thick-provision image support
Date: Wed, 21 Mar 2018 06:31:20 +0800 [thread overview]
Message-ID: <CA+aFP1AunD_KvE5JkFAzzEtu+D5dKS_nhEbyvS9COQM2PXuDCw@mail.gmail.com> (raw)
In-Reply-To: <CAOi1vP8qz9GeP0Beypq1N8XFwzkPieEE1Qf6gJafPnngjNG86g@mail.gmail.com>
There isn't currently an option to disable discards in librbd.
However, given that's the intent of this change, why not name the
option along the lines of "discard_disbled"?
On Tue, Mar 20, 2018 at 10:06 PM, Ilya Dryomov <idryomov@gmail.com> wrote:
> On Mon, Mar 19, 2018 at 1:00 PM, KAMEI Hitoshi
> <hitoshi.kamei.xm@hitachi.com> wrote:
>> This patch series adds the thick-provision image support to
>> /drivers/block/rbd.c relating to https://github.com/ceph/ceph/pull/18317.
>> The rbd will not issue the discard operation to thick-provision
>> images, if applied.
>>
>> The rbd should not discard any allocated blocks of thick-provision
>> image to ensure writing data to rbd images. So this patch
>> prevents from discarding allocated blocks on thick-provision
>> image.
>>
>> This patch series creates sysfs file to manipulate thick-provision
>> status. If users write "1" to /sys/bus/rbd/devices/<dev-id>/thick,
>> then the image is changed to thick-provision image. And if users
>> write "0" to it, then the image is changed to thin-provision
>> image. I will add the code changing status for the rbd map command.
>
> Hi Hitoshi,
>
> I think it should be a map time option -- e.g. rbd map -o thick.
> I don't see any reason for allowing tweaking this setting on a mapped
> image.
>
> I looked through https://github.com/ceph/ceph/pull/18317 and I don't
> see an equivalent functionality there. rbd_discard_on_zeroed_write_same
> set to false makes the actual zeroes go on the wire, but I don't see
> anything for ignoring discard requests. Can you point me at that?
>
> Thanks,
>
> Ilya
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jason
next prev parent reply other threads:[~2018-03-20 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 12:00 [PATCH 0/2] rbd: thick-provision image support KAMEI Hitoshi
2018-03-20 14:06 ` Ilya Dryomov
2018-03-20 22:31 ` Jason Dillaman [this message]
2018-03-22 11:59 ` 亀井仁志 / KAMEI,HITOSHI
2018-03-22 11:58 ` 亀井仁志 / KAMEI,HITOSHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+aFP1AunD_KvE5JkFAzzEtu+D5dKS_nhEbyvS9COQM2PXuDCw@mail.gmail.com \
--to=jdillama@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dillaman@redhat.com \
--cc=elder@kernel.org \
--cc=hitoshi.kamei.xm@hitachi.com \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).