From: Philip Chen <philipchen@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace
Date: Wed, 13 Jan 2021 21:48:31 -0800 [thread overview]
Message-ID: <CA+cxXhnzKG8G9+gdAp32VC-aWBgdteUFVq2YknrowuMMtP6BfQ@mail.gmail.com> (raw)
In-Reply-To: <161058839125.3661239.15252566946929589144@swboyd.mtv.corp.google.com>
On Wed, Jan 13, 2021 at 5:39 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Philip Chen (2021-01-13 17:29:05)
> > On Wed, Jan 13, 2021 at 3:14 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > Quoting Philip Chen (2021-01-13 14:47:18)
> > > > On Tue, Jan 12, 2021 at 10:49 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > > > >
> > > > > Quoting Philip Chen (2021-01-12 15:55:28)
> > > > > > On Mon, Jan 11, 2021 at 6:24 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > > > > > >
> > > > > > > Is it documented in Documentation/ABI/?
> > > > > > Not yet.
> > > > > > Is it proper to add the documentation to `testing/sysfs-driver-input-keyboard`?
> > > > >
> > > > > Somewhere in testing is fine. I'm not sure if it is a generic proprty
> > > > > for all keyboards though? What's the path in sysfs?
> > > > I wouldn't say it's generic.
> > > > It is available in the keyboard device node only when the board has a
> > > > custom top-row keyboard design.
> > > > The path in sysfs is something like:
> > > > /sys/class/input/input0/device/function_row_physmap, where input0 is
> > > > cros_ec.
> > >
> > > I see that atkbd already has this so at least it would be common to some
> > > sort of keyboard device. I'm not sure where to document it though. I see
> > > that atkbd has a handful of undocumented sysfs attributes so adding all
> > > of those may lead to a common path. At the least it sounds OK to have a
> > > sysfs-driver-input-keyboard file if input folks are OK with it.
> > Since there are other undocumented sysfs attributes for input/keyboard
> > anyway, we should probably leave the documentation to another patch?
> > For now, let's move to patch v5, where I've addressed all of the
> > comments so far.
>
> Please document this one that's being introduced. We should document all
> the sysfs attributes but we don't always do a good job at it.
OK, will do!
next prev parent reply other threads:[~2021-01-14 5:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 23:42 [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-07 23:42 ` [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace Philip Chen
2021-01-12 2:24 ` Stephen Boyd
2021-01-12 23:55 ` Philip Chen
2021-01-13 6:49 ` Stephen Boyd
2021-01-13 22:47 ` Philip Chen
2021-01-13 23:14 ` Stephen Boyd
2021-01-14 1:29 ` Philip Chen
2021-01-14 1:39 ` Stephen Boyd
2021-01-14 5:48 ` Philip Chen [this message]
2021-01-12 2:10 ` [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Stephen Boyd
2021-01-12 23:29 ` Philip Chen
2021-01-13 6:52 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+cxXhnzKG8G9+gdAp32VC-aWBgdteUFVq2YknrowuMMtP6BfQ@mail.gmail.com \
--to=philipchen@chromium.org \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).