From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbdAYIz7 (ORCPT ); Wed, 25 Jan 2017 03:55:59 -0500 Received: from mail-yb0-f175.google.com ([209.85.213.175]:33444 "EHLO mail-yb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbdAYIz6 (ORCPT ); Wed, 25 Jan 2017 03:55:58 -0500 MIME-Version: 1.0 In-Reply-To: <1485272668.1236.5.camel@sipsolutions.net> References: <1485272531-11587-1-git-send-email-amadeusz.slawinski@tieto.com> <1485272531-11587-2-git-send-email-amadeusz.slawinski@tieto.com> <1485272668.1236.5.camel@sipsolutions.net> From: Amadeusz Slawinski Date: Wed, 25 Jan 2017 09:55:57 +0100 Message-ID: Subject: Re: [PATCH 2/2] mac80211: use accessor functions to set sta->_flags To: Johannes Berg Cc: linux-wireless@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 X-DomainID: tieto.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0P8uCMh018037 And yes I did. Somehow managed to ignore those warnings though, sorry about that. Rechecked with just first patch and it should still be good. Please ignore this one ;) On 24 January 2017 at 16:44, Johannes Berg wrote: > On Tue, 2017-01-24 at 16:42 +0100, Amadeusz Sławiński wrote: >> cleanup patch to make use of set_sta_flag()/clear_sta_flag() in >> places >> where we access sta->_flags >> >> Signed-off-by: Amadeusz Sławiński >> --- >> net/mac80211/sta_info.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c >> index b6cfcf0..6c9cc2f 100644 >> --- a/net/mac80211/sta_info.c >> +++ b/net/mac80211/sta_info.c >> @@ -1855,13 +1855,13 @@ int sta_info_move_state(struct sta_info *sta, >> switch (new_state) { >> case IEEE80211_STA_NONE: >> if (sta->sta_state == IEEE80211_STA_AUTH) >> - clear_bit(WLAN_STA_AUTH, &sta->_flags); >> + clear_sta_flag(sta, WLAN_STA_AUTH); > > You should try to run this patch sometime :) > > johannes