From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB753C6FA82 for ; Tue, 20 Sep 2022 19:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbiITTVN (ORCPT ); Tue, 20 Sep 2022 15:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiITTVL (ORCPT ); Tue, 20 Sep 2022 15:21:11 -0400 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35FF8286E7 for ; Tue, 20 Sep 2022 12:21:10 -0700 (PDT) Received: by mail-qv1-xf2d.google.com with SMTP id w4so2791271qvp.2 for ; Tue, 20 Sep 2022 12:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=2fFnFfvF7l44JixGUwp4lrsIFX8DjQoBBv2Lr/mkNP0=; b=DaxAZMRn+z6gfdx54XhmmOabl6/upL90LxgL1FK8rbacRTFR0nR/b0jkn9rQuqcNHH VC03c8be4EAT+gxtRTYGpq/z445948cfhsxbH5A8EQJEZc/RTUad0n/6cbCtNUcq2JK7 p6/35WU4J8P+6ntQuZc8Q2UR2Tk27B4azbT1QB1D6b42M2KtFfbYkwOrxqbSRCq0LzsJ OFHXCOX1WGRaga6kEXKt/Upm+J1AlLJvwAnEOmfB8NuKUUY9qT6PoL4kl3QRtfJaP+HF YMEprrDWix/vV1KLF1B3e/tWYv2KldXwXDMbVeS11Z9d9AjM2TKArxgE/2VhEyufhKbM JtWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2fFnFfvF7l44JixGUwp4lrsIFX8DjQoBBv2Lr/mkNP0=; b=ogJ338S4idhssZR2aFfnz9iOwcZrnGPOXDimGdUfmt9ozj6x+6QnO3SSvh3V8qLCtD AFerOpiTeOl+ui3DC8rqf2mUzsSxHpnWwx/7F53GHWMYFaJDqmycMriiyFqrqnScTJJO DiVhaoIQofezBvZDBMg9nC8WMFYbmeL01RfNBxQkPdpxhXCiuneBeIhqeYrgdYlqAoUO XfMSz7kkOugVCBbffUzyCAw+ecejvecmTcPJjFwXE3VlDfhUWaurb2svTRIv8HnZviuC dQfoJs758H/jLwAVvDMTjdyJ7yhsz5zP/+zjcuSbqIA2bJTF2IDbLNjEVq9cmAYPFyl8 K8Eg== X-Gm-Message-State: ACrzQf1/LfyL4WkroqB/3CEbo/KBx5OTufmICMWqbD4k8wRNPSmgJxx3 uHVUywAVaLx2oyk6QLS+DrvS6rQc4fO3jJpi/og= X-Google-Smtp-Source: AMsMyM6nElpG8fYLz4yWt+NdcHYGKiIqfT0ZO7yO5Telew+swSrzQgXJVCjrR9Ry4q2bGmgXHWltSuDRcKorZaXIG5o= X-Received: by 2002:a05:6214:c48:b0:4ac:b18d:c101 with SMTP id r8-20020a0562140c4800b004acb18dc101mr20513445qvj.107.1663701669341; Tue, 20 Sep 2022 12:21:09 -0700 (PDT) MIME-Version: 1.0 References: <20220913065423.520159-1-feng.tang@intel.com> <20220913065423.520159-4-feng.tang@intel.com> In-Reply-To: <20220913065423.520159-4-feng.tang@intel.com> From: Andrey Konovalov Date: Tue, 20 Sep 2022 21:20:58 +0200 Message-ID: Subject: Re: [PATCH v6 3/4] mm: kasan: Add free_meta size info in struct kasan_cache To: Feng Tang Cc: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Dmitry Vyukov , Jonathan Corbet , Dave Hansen , Linux Memory Management List , LKML , kasan-dev , kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 8:54 AM Feng Tang wrote: > > When kasan is enabled for slab/slub, it may save kasan' free_meta > data in the former part of slab object data area in slab object's > free path, which works fine. > > There is ongoing effort to extend slub's debug function which will > redzone the latter part of kmalloc object area, and when both of > the debug are enabled, there is possible conflict, especially when > the kmalloc object has small size, as caught by 0Day bot [1] > > For better information for slab/slub, add free_meta's data size > into 'struct kasan_cache', so that its users can take right action > to avoid data conflict. > > [1]. https://lore.kernel.org/lkml/YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020/ > Reported-by: kernel test robot > Signed-off-by: Feng Tang > Acked-by: Dmitry Vyukov > --- > include/linux/kasan.h | 2 ++ > mm/kasan/common.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index b092277bf48d..49af9513e8ed 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -100,6 +100,8 @@ static inline bool kasan_has_integrated_init(void) > struct kasan_cache { > int alloc_meta_offset; > int free_meta_offset; > + /* size of free_meta data saved in object's data area */ > + int free_meta_size; > bool is_kmalloc; > }; > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 69f583855c8b..0cb867e92524 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -201,6 +201,8 @@ void __kasan_cache_create(struct kmem_cache *cache, unsigned int *size, > cache->kasan_info.free_meta_offset = KASAN_NO_FREE_META; > *size = ok_size; > } > + } else { > + cache->kasan_info.free_meta_size = sizeof(struct kasan_free_meta); Hi Feng, I just realized that we already have a function that exposes a similar functionality: kasan_metadata_size. However, this function returns the size of metadata that is stored in the redzone. I think, instead of adding free_meta_size, a better approach would be to: 1. Rename kasan_metadata_size to kasan_metadata_size_in_redzone (or something like that). 2. Add kasan_metadata_size_in_object with appropriate implementation and use that in your patches. This allows avoiding exposing KASAN-internal details such as what kind of fields the kasan_cache struct has to the common code. Sorry for nor realizing this straight away. (Note that there's an upcoming patch that fixes a bug in kasan_metadata_size' implementation [1].) Thanks! [1] https://lore.kernel.org/linux-mm/c7b316d30d90e5947eb8280f4dc78856a49298cf.1662411799.git.andreyknvl@google.com/ > } > > /* Calculate size with optimal redzone. */ > -- > 2.34.1 >