From: Andrey Konovalov <andreyknvl@gmail.com>
To: Alexander Potapenko <glider@google.com>
Cc: andrey.konovalov@linux.dev, Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH 1/3] kasan: clean up comments in internal kasan.h
Date: Mon, 9 May 2022 17:49:53 +0200 [thread overview]
Message-ID: <CA+fCnZfkKwYRTn+oK71c89jJG9CKAUqrURxq=g6z7EJXrr_Pzw@mail.gmail.com> (raw)
In-Reply-To: <CAG_fn=XFOA-qsvPwjwJ0iZH1Wy54aS7QtD4ETVdp9L-yvOkiWg@mail.gmail.com>
On Thu, Apr 28, 2022 at 6:42 PM Alexander Potapenko <glider@google.com> wrote:
>
> On Thu, Apr 28, 2022 at 6:21 PM <andrey.konovalov@linux.dev> wrote:
> >
> > From: Andrey Konovalov <andreyknvl@google.com>
> >
> > Clean up comments in mm/kasan/kasan.h: clarify, unify styles, fix
> > punctuation, etc.
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
>
> Reviewed-by: Alexander Potapenko <glider@google.com>
>
> >
> > +/* alloca redzone size. Compiler's ABI, do not change. */
> s/Compiler's/Compiler ?
>
> > #define KASAN_ALLOCA_REDZONE_SIZE 32
> >
> > -/*
> > - * Stack frame marker (compiler ABI).
> > - */
> > +/* Stack frame marker. Compiler's ABI, do not change. */
> Ditto
>
> >
> > -/* The layout of struct dictated by compiler */
> > +/* Do not change the struct layout: compiler's ABI. */
> Ditto
>
> > -/* The layout of struct dictated by compiler */
> > +/* Do not change the struct layout: compiler's ABI. */
> Ditto
>
> > - unsigned long has_dynamic_init; /* This needed for C++ */
> > + unsigned long has_dynamic_init; /* This needed for C++. */
> "is needed"?
>
>
> > - * is accepted since SLAB redzones aren't enabled in production builds.
> > + * is accepted since slab redzones aren't enabled in production builds.
> s/accepted/acceptable ?
Will fix all in v2, thanks!
prev parent reply other threads:[~2022-05-09 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 16:21 [PATCH 1/3] kasan: clean up comments in internal kasan.h andrey.konovalov
2022-04-28 16:21 ` [PATCH 2/3] kasan: use tabs to align shadow values andrey.konovalov
2022-04-28 16:21 ` [PATCH 3/3] kasan: give better names to " andrey.konovalov
2022-04-28 16:44 ` Alexander Potapenko
2022-04-28 16:42 ` [PATCH 1/3] kasan: clean up comments in internal kasan.h Alexander Potapenko
2022-05-09 15:49 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+fCnZfkKwYRTn+oK71c89jJG9CKAUqrURxq=g6z7EJXrr_Pzw@mail.gmail.com' \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).