From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9E3C00454 for ; Tue, 10 Dec 2019 17:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84EE02077B for ; Tue, 10 Dec 2019 17:05:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="urIFH+zO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727789AbfLJRFW (ORCPT ); Tue, 10 Dec 2019 12:05:22 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:37337 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727482AbfLJRFW (ORCPT ); Tue, 10 Dec 2019 12:05:22 -0500 Received: by mail-ed1-f65.google.com with SMTP id cy15so16626767edb.4; Tue, 10 Dec 2019 09:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V/m7GvYpg3asIPZhHfNwzAdY+b/5CfIU9R9Z7IpYwiU=; b=urIFH+zO4UZfF2rCurnwpzVDpFNMAqb2rWMAIdXu58p8ugm6svnzZ31UqKn+Rtbu5e PQsO/BsQcZt/HKR9Hv4vG658oKEceiGQQVzZQcDCEEuiMdWZbPa8u31fvChGoYyihI6Y sl5fkWptMuptcHYYYeXRZneQVLiNZmRg52kmHZy2nFsGvceMwwa1MKoOeZ7HkVSFiCzK nuD7lyyY/3F2R8aVkID44KN0loAp/QQCgWhn4yFIKm+V7Jbnun8WnKWqmVo4Ntm+41Z5 P+iwzzCI7ibvAAnmmMzUWCsPVXjIo3en5FfaJIT/ttoJaq9exR3GPS32l+UhFoQca0lg 2mTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V/m7GvYpg3asIPZhHfNwzAdY+b/5CfIU9R9Z7IpYwiU=; b=dLQCvLvKcvZY8c3Bl29HYB9hejgb4ngDKjrvWsVJokR6aJKEyHpbtKl2bqS9LSO6vb cEI1tK1lCtzquyzn8bQUrdQfuy1cmjWobRX5emuMJ/LnUDsv9ipQXyiNCDyLW20AWOm3 tjftByKCqehd27YsRHklzytUYdOAPRz56Ee7iR8TClyANDcUoYFdgrgp3IzevbvXHZ+U Z09KIBcZbq5Xd9DthvQkKikv/j/1e6JLbSCpkMnojn1Qb575HcCDEGgNvqmHzVub4tCB dvvJbQlV65XnI5IAcMZvApehrH7P9noXT054kjOglV2WwyKfQId50yezGy0bCIEqnbwj jcRw== X-Gm-Message-State: APjAAAX+fqbonNqu8TixMR8DFHNuf7kQ3ixXPmyPRmQPUkh5xug+LIys ggznIfKfp9RW7St8f6uAXOEM0s7moQ+jdsWwuVg= X-Google-Smtp-Source: APXvYqzyHbVIEY/8yAXTbmWOCmJY+Np2u+GYL67HEkNJeOc5mAbpPhpBS37Z+eeJdlRiZHSgZ7qlEoQyRL9kKTMTrHc= X-Received: by 2002:a17:907:11cc:: with SMTP id va12mr4844106ejb.164.1575997520215; Tue, 10 Dec 2019 09:05:20 -0800 (PST) MIME-Version: 1.0 References: <6d608dd024edc90b09ba4fe35417b693847f973c.1575914275.git.landen.chao@mediatek.com> <20191210163557.GC27714@lunn.ch> In-Reply-To: <20191210163557.GC27714@lunn.ch> From: Vladimir Oltean Date: Tue, 10 Dec 2019 19:05:08 +0200 Message-ID: Subject: Re: [PATCH net-next 4/6] net: dsa: mt7530: Add the support of MT7531 switch To: Andrew Lunn Cc: Landen Chao , Florian Fainelli , Vivien Didelot , matthias.bgg@gmail.com, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, netdev , lkml , linux-mediatek@lists.infradead.org, "David S. Miller" , sean.wang@mediatek.com, =?UTF-8?Q?Ren=C3=A9_van_Dorst?= , frank-w@public-files.de Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Landen, Andrew, On Tue, 10 Dec 2019 at 18:36, Andrew Lunn wrote: > > On Tue, Dec 10, 2019 at 04:14:40PM +0800, Landen Chao wrote: > > Add new support for MT7531: > > > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > > 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu > > port 6 only supports HSGMII interface. Cpu port 5 supports either RGMII > > or HSGMII in different HW sku. > > Hi Landen > > Looking at the code, you seem to treat HSGMII as 2500Base-X. Is this > correct? Or is it SGMII over clocked to 2.5Gbps? > > Andrew I think the better question is: what is being understood by HSGMII? What does the AN base page look like? Do you support AN with the 2500 baud speed? Do you support AN with lower speeds? Do you support lower speeds at all? What PHYs do you interoperate with in this mode? If you don't support AN, then what's so SGMII about it? And for that matter, if you don't support AN, what's so 2500Base-X (802.3z) about it? I see you unconditionally force the speed and disable AN in this mode. Do you have any reference for what SerDes protocol your hardware implements in this mode? Thanks, -Vladimir