From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA63C35672 for ; Sat, 22 Feb 2020 12:25:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5196520656 for ; Sat, 22 Feb 2020 12:25:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NhTbOsAt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727278AbgBVMZv (ORCPT ); Sat, 22 Feb 2020 07:25:51 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:35841 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbgBVMZu (ORCPT ); Sat, 22 Feb 2020 07:25:50 -0500 Received: by mail-ed1-f67.google.com with SMTP id j17so5903038edp.3; Sat, 22 Feb 2020 04:25:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/Y50RHD2QGihstG7fjd8c2NdZnfKYGCwsRvJsD3a51U=; b=NhTbOsAtlr89Xk/roSZUnzFyZi5buN3T9l38N0HrufP0cibwbgBJAtd3Y6AwlCm2H4 RhzUVdn6aK6roKwiZuRD6a6mQ6b6K7MdCI3UGhk/0trmFnf9vnNzDjFhTo2wsFgy1l8x yujA86FhM08935s665nOaSZB5pgb3+HjNlnPQyCseTvVPOldvQgQmuxY0/C4syo+Qlmw SvpcKC832vgrQLLbEHYpP7qUChKzkzBlizGq9uAQonHYQCdyulva0IyA/SOW51d01veR /KRKZxsBRRM9cfuODq3hZH+O3r/UI/1dSDADAkxc7imMvh9rjJ1GMoca0tHYb+y4k7kP 19ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Y50RHD2QGihstG7fjd8c2NdZnfKYGCwsRvJsD3a51U=; b=n5NMSLPTHvhAAWTobjpYP5hVN/T5s909xLXuJc/dBfXB4+8t6orAobukmh0waxn1N3 QjxBhr72KzC/5pc5knNWT4fxHkR/HBNsjLVpoytRdwfp90/k0O0wdOUxFj53zhjjQHAM s6dUydgVCzyo2i9t6HZvxIZmvqkRX+tBWjWIh/IV19ekQJDPOv7rEai4IN7b6iNI3Qp3 XeM9I06pQOmf1p2JQKthk/lN7nT3aoPuif7K7/tJUm9izRXUsHxtsC8BpUy0Yhtu+0+W 50Munqyh/62Ejb/T+JDApdL0yqB4+Xe5cNMI2nN0DVVz1k5fi4XhH9pNHlgYa3mZvlOR vDCw== X-Gm-Message-State: APjAAAWpGSDD9r6qGy7Hp/l1stZn0beV4BsCa3EyWq80TxGQ8DgN5r0/ e6yByTbAaVCvnn1ew1ZLleYBwwFvUUWu/Vki9ms= X-Google-Smtp-Source: APXvYqzhOH4Kn2D97bedbpm09NJOhnwoJKeOv6yPa5hiGs62R53VqNZ52MVlBTpVEDOAJf57+r1mHqsaj9Z6lZAengs= X-Received: by 2002:a05:6402:3132:: with SMTP id dd18mr38997644edb.118.1582374346881; Sat, 22 Feb 2020 04:25:46 -0800 (PST) MIME-Version: 1.0 References: <20200219151259.14273-5-olteanv@gmail.com> <20200222113829.32431-1-michael@walle.cc> In-Reply-To: <20200222113829.32431-1-michael@walle.cc> From: Vladimir Oltean Date: Sat, 22 Feb 2020 14:25:36 +0200 Message-ID: Subject: Re: [PATCH v2 net-next/devicetree 4/5] arm64: dts: fsl: ls1028a: add node for Felix switch To: Michael Walle Cc: Andrew Lunn , "David S. Miller" , devicetree@vger.kernel.org, Florian Fainelli , lkml , Mark Rutland , netdev , Rob Herring , Shawn Guo , Vivien Didelot Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Sat, 22 Feb 2020 at 13:38, Michael Walle wrote: > > Hi, > > > + > > + enetc_port2: ethernet@0,2 { > > + compatible = "fsl,enetc"; > > + reg = <0x000200 0 0 0 0>; > > + phy-mode = "gmii"; > Can we disable this port by default in this dtsi? As mentioned in the other > mail, I'd prefer to have all ports disabled because it doesn't make sense > to have this port while having all the external ports disabled. > Ok. What would you want to happen with the "ethernet" property? Do you want the board dts to set that too? > > + /* Internal port with DSA tagging */ > > + mscc_felix_port4: port@4 { > > + reg = <4>; > > + phy-mode = "internal"; > > + ethernet = <&enetc_port2>; > Likewise, I'd prefer to have this disabled. > Ok. > > + enetc_port3: ethernet@0,6 { > > + compatible = "fsl,enetc"; > > + reg = <0x000600 0 0 0 0>; > > + status = "disabled"; > > + phy-mode = "gmii"; > shouldn't the status be after the phy-mode property? Why? > > -michael > Regards, -Vladimir