From: Vladimir Oltean <olteanv@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: felix: fix link error
Date: Wed, 8 Jan 2020 20:51:01 +0200 [thread overview]
Message-ID: <CA+h21hqy6mK-Cy0VyXtDUtPqvqbTPGZ45aJ2eko+VQFzjDbtKg@mail.gmail.com> (raw)
In-Reply-To: <20200108124844.1348395-1-arnd@arndb.de>
Thanks Arnd!
On Wed, 8 Jan 2020 at 14:59, Arnd Bergmann <arnd@arndb.de> wrote:
>
> When the enetc driver is disabled, the mdio support fails to
> get built:
>
> drivers/net/dsa/ocelot/felix_vsc9959.o: In function `vsc9959_mdio_bus_alloc':
> felix_vsc9959.c:(.text+0x19c): undefined reference to `enetc_hw_alloc'
> felix_vsc9959.c:(.text+0x1d1): undefined reference to `enetc_mdio_read'
> felix_vsc9959.c:(.text+0x1d8): undefined reference to `enetc_mdio_write'
>
> Change the Makefile to enter the subdirectory for this as well.
>
> Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
I agree the patch is only seen with the commit you pointed to, but the
problem is also introduced by:
Fixes: 6517798dd343 ("enetc: Make MDIO accessors more generic and
export to include/linux/fsl")
[ please excuse me David, I don't know how to configure neither Gmail
nor Thunderbird to disable word wrapping ]
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/freescale/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/freescale/Makefile b/drivers/net/ethernet/freescale/Makefile
> index 6a93293d31e0..67c436400352 100644
> --- a/drivers/net/ethernet/freescale/Makefile
> +++ b/drivers/net/ethernet/freescale/Makefile
> @@ -25,4 +25,5 @@ obj-$(CONFIG_FSL_DPAA_ETH) += dpaa/
> obj-$(CONFIG_FSL_DPAA2_ETH) += dpaa2/
>
> obj-$(CONFIG_FSL_ENETC) += enetc/
> +obj-$(CONFIG_FSL_ENETC_MDIO) += enetc/
> obj-$(CONFIG_FSL_ENETC_VF) += enetc/
> --
> 2.20.0
>
next prev parent reply other threads:[~2020-01-08 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 12:48 [PATCH net-next] net: dsa: felix: fix link error Arnd Bergmann
2020-01-08 18:51 ` Vladimir Oltean [this message]
2020-01-09 0:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hqy6mK-Cy0VyXtDUtPqvqbTPGZ45aJ2eko+VQFzjDbtKg@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=arnd@arndb.de \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).