From: Sedat Dilek <sedat.dilek@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Shuah Khan" <shuah@kernel.org>,
"Nathan Chancellor" <natechancellor@gmail.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Quentin Monnet" <quentin@isovalent.com>,
"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
"Tobias Klauser" <tklauser@distanz.ch>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Yulia Kartseva" <hex@fb.com>, "Andrey Ignatov" <rdna@fb.com>,
"Thomas Hebb" <tommyhebb@gmail.com>,
"Stephane Eranian" <eranian@google.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Davide Caratti" <dcaratti@redhat.com>,
"Briana Oursler" <briana.oursler@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Clang-Built-Linux ML" <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions
Date: Thu, 21 Jan 2021 03:36:28 +0100 [thread overview]
Message-ID: <CA+icZUU=nVxcQpfVR6s9fGomY0zEx22a8Ge4Uw8rL84JNu+0oA@mail.gmail.com> (raw)
In-Reply-To: <20210120223546.GF1798087@krava>
On Wed, Jan 20, 2021 at 11:36 PM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote:
> > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool.
> >
> > While looking into the source code I found duplicate assignments
> > in misc tools for the LLVM eco system, e.g. clang and llvm-objcopy.
> >
> > Move the Clang, LLC and/or LLVM utils definitions to
> > tools/scripts/Makefile.include file and add missing
> > includes where needed.
> > Honestly, I was inspired by commit c8a950d0d3b9
> > ("tools: Factor HOSTCC, HOSTLD, HOSTAR definitions").
> >
> > I tested with bpftool and perf on Debian/testing AMD64 and
> > LLVM/Clang v11.1.0-rc1.
> >
> > Build instructions:
> >
> > [ make and make-options ]
> > MAKE="make V=1"
> > MAKE_OPTS="HOSTCC=clang HOSTCXX=clang++ HOSTLD=ld.lld CC=clang LD=ld.lld LLVM=1 LLVM_IAS=1"
> > MAKE_OPTS="$MAKE_OPTS PAHOLE=/opt/pahole/bin/pahole"
> >
> > [ clean-up ]
> > $MAKE $MAKE_OPTS -C tools/ clean
> >
> > [ bpftool ]
> > $MAKE $MAKE_OPTS -C tools/bpf/bpftool/
> >
> > [ perf ]
> > PYTHON=python3 $MAKE $MAKE_OPTS -C tools/perf/
> >
> > I was careful with respecting the user's wish to override custom compiler,
> > linker, GNU/binutils and/or LLVM utils settings.
> >
> > Some personal notes:
> > 1. I have NOT tested with cross-toolchain for other archs (cross compiler/linker etc.).
> > 2. This patch is on top of Linux v5.11-rc3.
> >
> > I hope to get some feedback from especially Linux-bpf folks.
> >
> > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> > ---
> > tools/bpf/bpftool/Makefile | 2 --
> > tools/bpf/runqslower/Makefile | 3 ---
> > tools/build/feature/Makefile | 4 ++--
> > tools/perf/Makefile.perf | 1 -
>
> for tools/build and tools/perf
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
>
Thanks Jiri for your feedback and ACK.
- Sedat -
> jirka
>
> > tools/scripts/Makefile.include | 7 +++++++
> > tools/testing/selftests/bpf/Makefile | 3 +--
> > tools/testing/selftests/tc-testing/Makefile | 3 +--
> > 7 files changed, 11 insertions(+), 12 deletions(-)
> >
> > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
> > index f897cb5fb12d..71c14efa6e91 100644
> > --- a/tools/bpf/bpftool/Makefile
> > +++ b/tools/bpf/bpftool/Makefile
>
> SNIP
>
next prev parent reply other threads:[~2021-01-21 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 9:54 [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions Sedat Dilek
2021-01-20 22:35 ` Jiri Olsa
2021-01-21 2:36 ` Sedat Dilek [this message]
2021-01-22 0:04 ` Andrii Nakryiko
2021-01-22 0:12 ` Sedat Dilek
2021-01-22 0:21 ` Sedat Dilek
2021-01-22 0:25 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+icZUU=nVxcQpfVR6s9fGomY0zEx22a8Ge4Uw8rL84JNu+0oA@mail.gmail.com' \
--to=sedat.dilek@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=briana.oursler@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=eranian@google.com \
--cc=fche@redhat.com \
--cc=hex@fb.com \
--cc=iii@linux.ibm.com \
--cc=jean-philippe@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=rdna@fb.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=tklauser@distanz.ch \
--cc=toke@redhat.com \
--cc=tommyhebb@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).