From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C26C4BA10 for ; Wed, 26 Feb 2020 12:59:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15CFD24684 for ; Wed, 26 Feb 2020 12:59:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G0gUbLLU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbgBZM7n (ORCPT ); Wed, 26 Feb 2020 07:59:43 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55433 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726592AbgBZM7m (ORCPT ); Wed, 26 Feb 2020 07:59:42 -0500 Received: by mail-wm1-f67.google.com with SMTP id q9so2952799wmj.5; Wed, 26 Feb 2020 04:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=TvwRMoMGJoOBW5U/G6Ov9OkglcVw7Zi5W3FAUCreUTE=; b=G0gUbLLUQ+kjHCC8gG63gzA/B5sX1xWkJ1OeXKwycE8dbb3G5FNjapOnAbOUohNpuI qwdE+5rBdulwvx8iIrraarXoT3rrKgcdPGsRJmhVdi52aZnwTkkc3ktLW4JVb4e+FKBZ yJMhIIVo2fI4ytDMxXwTWWP1BXU3M84Jy6duOBcJtuOhCFLQe7g5gSTJyz/8AVg8Yz6h dgYue9BOU5kruD1xV5vVaTXrFRRrbVZYPuHbvNvJmmzZ5EjHrT3tiv6jWuknR5BGmMU2 Iv62OdRPfBGlgcPhKVSqA8G5OrOWahXkcTZQO8dRW9AuC9dFVGiFV2vZgoeg2NO+a3S+ r5kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=TvwRMoMGJoOBW5U/G6Ov9OkglcVw7Zi5W3FAUCreUTE=; b=J6dwsxEARdozYOsM8ym9AthziEvIUFbm/lMRZPCzpntue8A45YC37Fb5/lRkXQQnfc CTjNgDomcNHiriGVTfoFPBLW2IQ8u1WVuhAQJcpCJjoURuonhbEWvOZOElf1+sJnyU9S dqptyJuPag1jJ6KP4F1Ko7tRRrc+J1lNHzWQHePUdAjmK6OCcJDh1w/IGzrA0/DN+bBl 0bcrLkdUPM3BRNLxYhJeQXSs0IslL9LUcKOBHywsJf5LCNRXf0p4bR4yaJVrRaawS9Tt zrYmZOTw9TBt0DAESI9Xbikumg4H+hRT4fXTqdtyd6xsnTn48ezbYQuIiNAbAiPGGM1G 5g7A== X-Gm-Message-State: APjAAAWXgZLuhNd0XNnwpqq+hj9sZDQwmyNcu9Iy9P9A8Fy0gJ++XU3D WaVCw3lA4YP4SYN8Fk0jLGinGGdifCQyY9EEv1A= X-Google-Smtp-Source: APXvYqzOXKr7YjubT2c2bwbdts/K1ziby/AC4aTEgXdbIhBFxKfLviVhitgx5pe+YIc3glYsAR7MV2AG+P48GF8sHwU= X-Received: by 2002:a7b:cc69:: with SMTP id n9mr5055395wmj.163.1582721980031; Wed, 26 Feb 2020 04:59:40 -0800 (PST) MIME-Version: 1.0 References: <20200224174129.2664-1-ndesaulniers@google.com> <20200225210250.64366-1-ndesaulniers@google.com> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Wed, 26 Feb 2020 14:02:09 +0100 Message-ID: Subject: Re: [PATCH v2] Documentation/llvm: add documentation on building w/ Clang/LLVM To: Masahiro Yamada Cc: Nick Desaulniers , Jonathan Corbet , Randy Dunlap , Kees Cook , Nathan Chancellor , Michal Marek , Linux Kbuild mailing list , "open list:DOCUMENTATION" , Linux Kernel Mailing List , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 1:39 PM Masahiro Yamada wrote: > > On Wed, Feb 26, 2020 at 9:26 PM Sedat Dilek wrote: > > > > On Wed, Feb 26, 2020 at 12:31 PM Masahiro Yamada wrote: > > > > > > Hi. > > > > > > > > > On Wed, Feb 26, 2020 at 6:02 AM Nick Desaulniers > > > wrote: > > > > > > > > Added to kbuild documentation. Provides more official info on building > > > > kernels with Clang and LLVM than our wiki. > > > > > > > > Suggested-by: Randy Dunlap > > > > Reviewed-by: Kees Cook > > > > Reviewed-by: Nathan Chancellor > > > > Reviewed-by: Sedat Dilek > > > > Signed-off-by: Nick Desaulniers > > > > --- > > > > Changes V1 -> V2: > > > > * s/On going/ongoing/ > > > > * add Randy's Suggested-by > > > > > > > > > I do not understand this tag update. > > > > > > As far as I saw the review process, > > > I do not think Randy deserves to have Suggested-by > > > because he just pointed out a typo (on going -> ongoing) : > > > https://patchwork.kernel.org/patch/11401189/#23179575 > > > > > > (or, was there off-line activity I had missed?) > > > > > > > Hi Masahiro, > > > > I got some credits from Nick for a review by seeing a typo - not on a > > review of the code - and H. Peter Anvin asked why. > > > > I am not sure what is here the correct credit to give. > > Depends a "Reviewed-by" and/or "Suggested-by" on a technical review? > > > > Documentation/process/submitting-patches.rst > > 13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes: > > is a helpful guideline. > Thanks for CCing Randy and the pointer to "Documentation/process/submitting-patches.rst" file. This document [1] is mostly focusing on technical handling. - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n584