From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755928Ab2FOJXG (ORCPT ); Fri, 15 Jun 2012 05:23:06 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:53829 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754978Ab2FOJXD convert rfc822-to-8bit (ORCPT ); Fri, 15 Jun 2012 05:23:03 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <20120615101407.369c754da872e18c854ab481@canb.auug.org.au> References: <20120614114722.0fd16fb906b6a5503cfbc51a@canb.auug.org.au> <20120614030606.GC27673@linux-sh.org> <20120614034036.GE27673@linux-sh.org> <20120615101407.369c754da872e18c854ab481@canb.auug.org.au> Date: Fri, 15 Jun 2012 11:23:02 +0200 Message-ID: Subject: Re: linux-next: build failure in Linus' tree From: Sedat Dilek To: Stephen Rothwell Cc: Paul Mundt , Linus Torvalds , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 15, 2012 at 2:14 AM, Stephen Rothwell wrote: > Hi Paul, > > On Thu, 14 Jun 2012 12:40:36 +0900 Paul Mundt wrote: >> >> (adding Arnd to Cc, who I forgot to include previously) >> >> On Thu, Jun 14, 2012 at 12:06:06PM +0900, Paul Mundt wrote: >> > On Thu, Jun 14, 2012 at 11:47:22AM +1000, Stephen Rothwell wrote: >> > > While building Linus' tree, today's linux-next build (powerpc >> > > ppc64_defconfig) failed like this: >> > > >> > > In file included from include/asm-generic/bug.h:5:0, >> > >                  from arch/powerpc/include/asm/bug.h:127, >> > >                  from arch/powerpc/kernel/head_64.S:31: >> > > include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default] >> > > include/linux/linkage.h:57:0: note: this is the location of the previous definition >> > > include/linux/sysinfo.h: Assembler messages: >> > > include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct' >> > > include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t' >> > > >> > > And it went downhill from there :-( >> > > >> > > Caused by commit 3777808873b0 ("bug.h: need linux/kernel.h for >> > > TAINT_WARN") which, unfortunately never made it into linux-next. >> > > >> > > I have reverted that commit for today (which presumably means that sh >> > > builds will be broken again). >> > >> > I'm still unsure as to the best way to fix this, and there was no >> > response to the original mail I posted about it either: >> > >> > http://marc.info/?l=linux-kernel&m=133879579014853&w=2 >> > >> > I'll fetch a powerpc cross compiler and see if I can figure out what went >> > wrong. >> > >> Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is >> completely bogus. This should hopefully fix it once and for all. >> Sorry for the trouble. >> >> Signed-off-by: Paul Mundt > > Tested-by: Stephen Rothwell > > Can you create a proper commit message and send this to Linus, please?  I > have included it in my fixes tree in linux-next for today. > Reference: commit 2a6f7f6bd7a9eb3c835c7e5a7d51b43675fb3881 ("fix bug.h's inclusion of kernel.h") - Sedat - [1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=2a6f7f6bd7a9eb3c835c7e5a7d51b43675fb3881 > -- > Cheers, > Stephen Rothwell                    sfr@canb.auug.org.au