From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC04DC54FCE for ; Mon, 23 Mar 2020 09:53:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 905662072D for ; Mon, 23 Mar 2020 09:53:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EI2zKktS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbgCWJxE (ORCPT ); Mon, 23 Mar 2020 05:53:04 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54624 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727752AbgCWJxE (ORCPT ); Mon, 23 Mar 2020 05:53:04 -0400 Received: by mail-wm1-f68.google.com with SMTP id c81so3434307wmd.4; Mon, 23 Mar 2020 02:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=Z+6XVznaFEON0f8iN5LEjyjFaUvEkyzSk7nWE3yhXyU=; b=EI2zKktST7siFx8D5JHNrQES9a9jniXP+LT73GIPnwoUwynj2pC0K7zDBxeclTGJPd Ph8+H9FavfKjZP6pI8Hi0CmWQEL/MPftc/U2L3C+p18DIQ1+iyhHT4+j6HbifIiMHX4F n9xX9O3Ezwi5B8b2ghTMjvwkvsjFrGnSpiA6gm5/aPNE4kX8Si6TOWD2ZmMXiVdcl1FB caSBR5D07nYH/Z1u6Z/lXFZqJ4w0hUeKJFKJhJV+eaKcz636ZIIYt9GvA8QRfjySGO19 hvbudMx9EzHxSiUAMkWYdOU9Yknh6DWpviuJJf1O5rQKGe16OB2+9ImoD5heJMyqASA6 PwKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=Z+6XVznaFEON0f8iN5LEjyjFaUvEkyzSk7nWE3yhXyU=; b=lAnBvXtB2dLALA0XbKxiW/Y4L/KIoHmx8ajbyvwnZMyO9Zb8JexmoXUsnVqLgLmzoc Y8iHRNPY/fGZQkagnz6hQpWgCt1WO2AElbMWgZdVfZY7mAxJ+jehXlXuqzG5C3KNAT2d as3LrYu/zE4x+I/n6D+RVTTDjhWD0zNGtdZJEjuQb1Yspsi6SeA7bpVqKFgfKM84k4Gr G1Ni9r4W55cpOOv6tuVN/6LlXkJq9FsKk5Mm9ayI/Q0xTC4ct++KJzLkUJz/5BBBlIRp cEJSEhRwPBJitRTRv69gSeWJdETL4pwCQATOWSmMzNZLf1Gcj9eB2X1xv5+Hhxr4tdJf Exqg== X-Gm-Message-State: ANhLgQ2PWHTvMkORYZeE6iXvW/yfur4Rw74xXZEe9VzA30KcyROmAlm6 /iWb3wlcrXuDKOACUDTZoRRHsbructhBnJ+O67c= X-Google-Smtp-Source: ADFU+vuntAywRjz8eiWGZawNNazTzcPLdLf5SbEvx4DOHezzFPANFDCW/hQE4Lrr5sX/Nd4jh6OidJJxI8X1Nyv+Bq0= X-Received: by 2002:a1c:4e0f:: with SMTP id g15mr12959874wmh.163.1584957182077; Mon, 23 Mar 2020 02:53:02 -0700 (PDT) MIME-Version: 1.0 References: <20200323020844.17064-1-masahiroy@kernel.org> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Mon, 23 Mar 2020 10:52:50 +0100 Message-ID: Subject: Re: [PATCH 0/7] x86: remove always-defined CONFIG_AS_* options To: "Jason A. Donenfeld" Cc: Masahiro Yamada , X86 ML , Ingo Molnar , Thomas Gleixner , Borislav Petkov , "H . Peter Anvin" , LKML , Allison Randal , Armijn Hemel , "David S. Miller" , Greg Kroah-Hartman , Herbert Xu , Ingo Molnar , Kate Stewart , Song Liu , Zhengyuan Liu , clang-built-linux , Linux Crypto Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2020 at 7:53 AM Jason A. Donenfeld wrote: > > On Mon, Mar 23, 2020 at 12:36 AM Masahiro Yamada wrote: > > > > Hi Jason, > > > > On Mon, Mar 23, 2020 at 1:28 PM Jason A. Donenfeld wrote: > > > > > > Hi again, > > > > > > I've consolidated your patches and rebased mine on top, and > > > incorporated your useful binutils comments. The result lives here: > > > > > > https://git.zx2c4.com/linux-dev/log/?h=jd/kconfig-assembler-support > > > > > > I can submit all of those to the list, if you want, or maybe you can > > > just pull them out of there, include them in your v2, and put them in > > > your tree for 5.7? However you want is fine with me. > > > > > > Your series does not work correctly. > > > > I will comment why later. > > Bummer, okay. Looking forward to learning what's up. Also, if some > parts of it are useful (like the resorting and organizing of > arch/x86/crypto/Makefile), feel free to cannibalize it, keeping what's > useful and discarding what's not. > Hi Jason, I have your patches on my radar. I have not checked your Kconfig changes are really working, especially I looked at [2] and comment on this. I would have expected your arch/x86/Kconfig.assembler file as arch/x86/crypto/Kconfig (source include needs to be adapted in arch/x86/Kconfig). What about a commit subject like "x86: crypto: Probe assembler options via Kconfig instead of makefile"? Not sure if the commit message needs some massage? Maybe this is all irrelevant when Masahiro has commented. Thanks. Regards, - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git/log/?h=jd/kconfig-assembler-support [2] https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git/commit/?h=jd/kconfig-assembler-support&id=ac483ff6fb4c785cd0b10d9756b71696829cd117