From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551AEC04AB1 for ; Thu, 9 May 2019 07:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27E4321019 for ; Thu, 9 May 2019 07:11:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dXfXVZOp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbfEIHLP (ORCPT ); Thu, 9 May 2019 03:11:15 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:56297 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726192AbfEIHLO (ORCPT ); Thu, 9 May 2019 03:11:14 -0400 Received: by mail-wm1-f67.google.com with SMTP id y2so1727484wmi.5; Thu, 09 May 2019 00:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=yeih5zxBtRqzhLwIXeQlFEwe+jl8VzzLNsf4IP3ROwA=; b=dXfXVZOpYbnXfmJSdxkI1o8u0QDAWtPiqHIh5zvHZEO4ZeRLxUw7hkEI+4noCdaf9I A++DCjT69jHpSy5bvIp6OxxTHCeQH8JS8aJtPc59yQPhgetaDXWhGlUXAITHWJa3Ehic uQwkQO7oOfXB7tYngUFD0kvD48AB5mnablTTKK8nFXhXCSN4FMssF7NR17MlfPvHUC7m SN7m0ca4gVh8bR91szeQM9JrirHqrkpnUw7L3U2d4xE+7RcLA2FkQwhoJu5ojCVmnWL9 7Kh1iXatVJKpd5geNCiRgVOlUnFq8HwTU6TxVOQqpOBqCQ93DU1/ToU77CTWCltHKQOB sMpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=yeih5zxBtRqzhLwIXeQlFEwe+jl8VzzLNsf4IP3ROwA=; b=tVaQPhI5An4+IueZMP8yLhb24npsXVYNcXEx0U7uGWv1R9TDk07I2gI1MShYOdmYKq rI9X0oPA2LkgrMss8hO+xTtc/eB80gCWsx0K5J6g5aJzMppR84kYDjiPaBEFIjR2Beo6 vRdgb2brR/fcxSpuc9/qywxAgLbp04s9PAH6pu94gS2ZeDJ94xvg4mPFBsGki5dKC+fH J0WPmbgC0ZUeieiEPZfvifxPBM9dGFfxz6eBZbr/8/NJ+fNiEUwLKHc3c/c7SBlA6hqz ua3aK+cZUrVTZ2FE+NuE03qedDsgdUraF/Uu1urvN/LbvvlvvLd+dT4z/uYs+1Z24d4V AWfA== X-Gm-Message-State: APjAAAUA34iUz2YZr1osVYlBIXeCIxsrD0M7DQETLBiaIQ3duKGYkdjX pGLyCGRzSMDVCkXHLlbYHCqutlUg7hqP06F+hFA= X-Google-Smtp-Source: APXvYqzrjaoDZ/XLiP+p9W7lN0KqpC7DK+suSZt20efzjxz+kllGXY/3cRWqyeQz5BYHkYrm8Et4SI0GPtSmH7DYZs0= X-Received: by 2002:a1c:dd44:: with SMTP id u65mr1546907wmg.109.1557385872835; Thu, 09 May 2019 00:11:12 -0700 (PDT) MIME-Version: 1.0 References: <20190509064635.1445-1-yamada.masahiro@socionext.com> In-Reply-To: <20190509064635.1445-1-yamada.masahiro@socionext.com> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Thu, 9 May 2019 09:11:02 +0200 Message-ID: Subject: Re: [PATCH] kbuild: add some extra warning flags unconditionally To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , Clang-Built-Linux ML , Michal Marek , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 9, 2019 at 8:47 AM Masahiro Yamada wrote: > > These flags are documented in the GCC 4.6 manual, and recognized by > Clang as well. Let's rip off the cc-option / cc-disable-warning switches. > BTW, is this a speedup when doing CC/LD FLAGS etc checks unconditionally? Asking in general - do you have any numbers :-)? - Sedat - > Signed-off-by: Masahiro Yamada > --- > > scripts/Makefile.extrawarn | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn > index 523c4cafe2dc..3ab8d1a303cd 100644 > --- a/scripts/Makefile.extrawarn > +++ b/scripts/Makefile.extrawarn > @@ -23,15 +23,16 @@ warning- := $(empty) > warning-1 := -Wextra -Wunused -Wno-unused-parameter > warning-1 += -Wmissing-declarations > warning-1 += -Wmissing-format-attribute > -warning-1 += $(call cc-option, -Wmissing-prototypes) > +warning-1 += -Wmissing-prototypes > warning-1 += -Wold-style-definition > -warning-1 += $(call cc-option, -Wmissing-include-dirs) > +warning-1 += -Wmissing-include-dirs > warning-1 += $(call cc-option, -Wunused-but-set-variable) > warning-1 += $(call cc-option, -Wunused-const-variable) > warning-1 += $(call cc-option, -Wpacked-not-aligned) > warning-1 += $(call cc-option, -Wstringop-truncation) > -warning-1 += $(call cc-disable-warning, missing-field-initializers) > -warning-1 += $(call cc-disable-warning, sign-compare) > +# The following turn off the warnings enabled by -Wextra > +warning-1 += -Wno-missing-field-initializers > +warning-1 += -Wno-sign-compare > > warning-2 := -Waggregate-return > warning-2 += -Wcast-align > @@ -39,8 +40,8 @@ warning-2 += -Wdisabled-optimization > warning-2 += -Wnested-externs > warning-2 += -Wshadow > warning-2 += $(call cc-option, -Wlogical-op) > -warning-2 += $(call cc-option, -Wmissing-field-initializers) > -warning-2 += $(call cc-option, -Wsign-compare) > +warning-2 += -Wmissing-field-initializers > +warning-2 += -Wsign-compare > warning-2 += $(call cc-option, -Wmaybe-uninitialized) > warning-2 += $(call cc-option, -Wunused-macros) > > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To post to this group, send email to clang-built-linux@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20190509064635.1445-1-yamada.masahiro%40socionext.com. > For more options, visit https://groups.google.com/d/optout.