From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D446AC433E0 for ; Sat, 6 Feb 2021 07:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A15B964FD4 for ; Sat, 6 Feb 2021 07:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhBFH05 (ORCPT ); Sat, 6 Feb 2021 02:26:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbhBFH0y (ORCPT ); Sat, 6 Feb 2021 02:26:54 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1802AC06174A; Fri, 5 Feb 2021 23:26:14 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id s24so9645122iob.6; Fri, 05 Feb 2021 23:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=WAkpmSceCQpOL9g/nb4W8z+4GPryDFavQAvOKJCZ4ec=; b=NwAb6V1G+IFXjDY2j2EcxBPzs6HFWtDkMW2mZRrYx3hC+p/bXbeP+RdECFiLUGbbQV dgwxhv7stlWzl3ZCYfBvptTMbLJdjgklbAY22It9SJlR67PxOQ9xDrtwAMyNqks19o5m iGsY1xKaN2W3l+FKCqLZENSHycmGH/eUc3WxclUWvT/dJX3V9Uugc9XbVBAzXFTIOBCf rWtViqSegeTtKjDJmtyTW2pgOnEWA9mv25ISVhYBprRJUApAIwwZVQnVDjp6diWfM1AC tIaqESU482JRtGdqPQEjf24k3qcRGRKfoA91Ab3nUvWcqxIafO388gfvdHrdBLP8JeQi cDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=WAkpmSceCQpOL9g/nb4W8z+4GPryDFavQAvOKJCZ4ec=; b=W6o/DzpuTNys9wOpjWlnnEsMQu80QZyLbUNT3R12f8gslZFXDcUaRUAASvjCpFguZw RW7hsaeJzXVjGs2we8u6ZpRxO/dqAaBvgFtFwUQ1ohH4S/XunZICyFgi+PANnK4xETON P7h9B51iS9m0VUIzktJ6hGts2dXGaZaQEPayqU0oyhKnrvwV//yU0ynzbkfZJgGEN+J/ fLpcU+BvAW6Rj5YNWY+aJZ/vlcoTYU0ATvYQsrgML6GkRQ6aHQBEh4qeVrx4/8yGdskS xxUEJbpdHuZkRkfD3j4fSF4TDikmn+mn0VGRScESTrKW1/Lu4CCK9v2iACVkucjX5QpS Nf/g== X-Gm-Message-State: AOAM531nU2g8lnxR+g09b4pBUmc80C/12HOEnpFJOl4jaVF4KSaOQBA+ ah4qB7V/sMUHm7wtikDBUhZj7lnEcHrqAbM8wP8= X-Google-Smtp-Source: ABdhPJxBD9o8SaZXUd2IGQs70eRnxmjnsa9ro/WLT3SvzYjbuE5LfuJ45b6mWetkQkmLI043G1Ku8Oyjb9KMFs2gvJA= X-Received: by 2002:a05:6638:251:: with SMTP id w17mr8479927jaq.138.1612596373526; Fri, 05 Feb 2021 23:26:13 -0800 (PST) MIME-Version: 1.0 References: <20210204220741.GA920417@kernel.org> <20210205152823.GD920417@kernel.org> <20210205192446.GH920417@kernel.org> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Sat, 6 Feb 2021 08:26:02 +0100 Message-ID: Subject: Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type To: Yonghong Song Cc: Arnaldo Carvalho de Melo , Arnaldo Carvalho de Melo , dwarves@vger.kernel.org, Linux Kernel Mailing List , bpf@vger.kernel.org, Jiri Olsa , Jan Engelhardt , Domenico Andreoli , Matthias Schwarzott , Andrii Nakryiko , Mark Wieelard , Paul Moore , Ondrej Mosnacek , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Tom Stellard Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 9:03 PM Yonghong Song wrote: > > > > On 2/5/21 11:24 AM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 05, 2021 at 11:10:08AM -0800, Yonghong Song escreveu: > >> On 2/5/21 11:06 AM, Sedat Dilek wrote: > >>> On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote: > >>> Grepping through linux.git/tools I guess some BTF tools/libs need to > >>> know what BTF_INT_UNSIGNED is? > > > >> BTF_INT_UNSIGNED needs kernel support. Maybe to teach pahole to > >> ignore this for now until kernel infrastructure is ready. > > > > Yeah, I thought about doing that. > > > >> Not sure whether this information will be useful or not > >> for BTF. This needs to be discussed separately. > > > > Maybe search for the rationale for its introduction in DWARF. > > In LLVM, we have: > uint8_t BTFEncoding; > switch (Encoding) { > case dwarf::DW_ATE_boolean: > BTFEncoding = BTF::INT_BOOL; > break; > case dwarf::DW_ATE_signed: > case dwarf::DW_ATE_signed_char: > BTFEncoding = BTF::INT_SIGNED; > break; > case dwarf::DW_ATE_unsigned: > case dwarf::DW_ATE_unsigned_char: > BTFEncoding = 0; > break; > > I think DW_ATE_unsigned can be ignored in pahole since > the default encoding = 0. A simple comment is enough. > For the followers (here: LLVM v12.0.0-rc1): [ llvm/lib/Target/BPF/BTFDebug.cpp ] BTFTypeInt::BTFTypeInt(uint32_t Encoding, uint32_t SizeInBits, uint32_t OffsetInBits, StringRef TypeName) : Name(TypeName) { // Translate IR int encoding to BTF int encoding. uint8_t BTFEncoding; switch (Encoding) { case dwarf::DW_ATE_boolean: BTFEncoding = BTF::INT_BOOL; break; case dwarf::DW_ATE_signed: case dwarf::DW_ATE_signed_char: BTFEncoding = BTF::INT_SIGNED; break; case dwarf::DW_ATE_unsigned: case dwarf::DW_ATE_unsigned_char: BTFEncoding = 0; break; default: llvm_unreachable("Unknown BTFTypeInt Encoding"); } - Sedat -