From: Sedat Dilek <sedat.dilek@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Sedat Dilek <sedat.dilek@googlemail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
maximilian attems <max@stro.at>, Thorsten Glaser <tg@debian.org>,
Alexander Wirt <formorer@debian.org>
Subject: Re: [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution
Date: Wed, 27 Feb 2013 15:09:28 +0100 [thread overview]
Message-ID: <CA+icZUV993buV4VYONW2xe=rkFYdnGUAKzOi9ftQfUHK4sFRjg@mail.gmail.com> (raw)
In-Reply-To: <512E1061.3030007@suse.cz>
On Wed, Feb 27, 2013 at 2:55 PM, Michal Marek <mmarek@suse.cz> wrote:
> Sorry I missed this series. Max, can you have a look? I don't know the
> policies for debian package changelogs. The full series is at
> http://lkml.indiana.edu/hypermail/linux/kernel/1204.2/index.html#04252,
> but the remaining two patches are obvious.
>
[ CC mirabilos and formorer ]
[PATCH 1/3] kbuild, deb-pkg: Try to determine distribution
...was discussed in (hehe, so long ago) April 2012 on #grml IRC (a
Linux live-system based on Debian) with Thorsten Glaser and Alexander
Wirt.
Both cool guys (longterm Debian maintainers and admins) gave me
several good hints to make this a "proper" solution.
Maybe, they won't remember :-).
I switched from Debian/unstable to Ubuntu/precise these days and that
was the reason I wanted the correct $distribution in my generated
Debian kernel packages.
Might be I come back when Debian/wheezy is released... you never know :-).
Or I get an Amiga-3000 with Debian/m68k running... with DirOpus and
DPaint-IV, hahaha.
I was simply too lazy to place a rock-solid changelog.
- Sedat -
> Michal
>
> On 24.4.2012 00:16, Sedat Dilek wrote:
>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>> ---
>> scripts/package/builddeb | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
>> index eee5f8e..f5b56ac 100644
>> --- a/scripts/package/builddeb
>> +++ b/scripts/package/builddeb
>> @@ -172,9 +172,22 @@ else
>> fi
>> maintainer="$name <$email>"
>>
>> +# Try to determine distribution
>> +if [ -e $(which lsb_release) ]; then
>> + codename=$(lsb_release --codename --short)
>> + if [ "$codename" != "" ]; then
>> + distribution=$codename
>> + else
>> + distribution="UNRELEASED"
>> + echo "WARNING: The distribution could NOT be determined!"
>> + fi
>> +else
>> + echo "HINT: Install lsb_release binary, this helps to identify your distribution!"
>> +fi
>> +
>> # Generate a simple changelog template
>> cat <<EOF > debian/changelog
>> -linux-upstream ($packageversion) unstable; urgency=low
>> +linux-upstream ($packageversion) $distribution; urgency=low
>>
>> * Custom built Linux kernel.
>>
>>
>
>
next prev parent reply other threads:[~2013-02-27 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 22:16 [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution Sedat Dilek
2012-04-23 22:16 ` [PATCH 2/3] kbuild, deb-pkg: Bump year in debian/copyright file Sedat Dilek
2012-04-23 22:16 ` [PATCH 3/3] kbuild, deb-pkg: Update git repository URL " Sedat Dilek
2013-02-27 13:55 ` [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution Michal Marek
2013-02-27 14:09 ` Sedat Dilek [this message]
2013-02-27 20:58 ` Thorsten Glaser
2013-02-28 7:32 ` maximilian attems
2013-02-28 9:45 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+icZUV993buV4VYONW2xe=rkFYdnGUAKzOi9ftQfUHK4sFRjg@mail.gmail.com' \
--to=sedat.dilek@gmail.com \
--cc=formorer@debian.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
--cc=mmarek@suse.cz \
--cc=sedat.dilek@googlemail.com \
--cc=tg@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).