From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C79BC433E0 for ; Fri, 5 Feb 2021 19:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C82E164E3D for ; Fri, 5 Feb 2021 19:24:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233728AbhBERlx (ORCPT ); Fri, 5 Feb 2021 12:41:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233446AbhBERjr (ORCPT ); Fri, 5 Feb 2021 12:39:47 -0500 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18FCBC06174A; Fri, 5 Feb 2021 11:21:30 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id e133so8262282iof.8; Fri, 05 Feb 2021 11:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=7zwM6AFEM1ZwlZuakpCJfAhsW39/fsUR7lAvfs6ogR8=; b=VByDAfMOPzY8M99CL0/hTXT2oGoQYqBsc/Dh2Gr50hZ+HricKakijoYArRRt7eB6OP pg1e1+iZTod8XQwsbOWK6GKZZEIIjcaGPaLgQM++M8yAXMRNeEta8isgPFuBgiV1G6rZ fkPKoOyBv/LpqXvS/X2ZSGNMKSWIHaEBkR5kBuCa/T0m6M+Qw+hjzqrJUkt0RM2dG45L c8JqDl1aGmBdq0tDKleP3Pqpmncjl+5T5ZvdZ7KtEbpzXgbJciBegCEPYMvUsZnYUlRM Npj0XT/nq2mddRZ51csVjKql5J+M8G3I30VSnSp2Eo4Ec6dfzLeo/hNayj+rRcmEvwHO R3/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=7zwM6AFEM1ZwlZuakpCJfAhsW39/fsUR7lAvfs6ogR8=; b=kUmNshb0UoR1hMfyXM82KSTMWZszrBD6+Epu6/U+fzp3Tx0OJVY6/LYIqbbomDVlTP or1fGcfsMSqOd/YkeOddhXnZPx1WnzDBoCs57G3n3RK5af8UsCona0oZzqEhyMLpbnp9 UiM70bdM7q1gXygz8s1Iw7C7dCxEsZS4rx/a2cjGGTE+lnmbjKrxMYInHi1NUZpEWGG4 eZQtMmxh1h544YTGWt+8k6+ZnmELYTtwqbomEID7GgVnPMHYs6WHo2dAcHvqO9EWwx+F dswOQ1PmSPWvlKzU/dxcfQoE5NA+N9QzHHBv+ggkZ3jVzD5DQR4HQBf1n8gLi2YtdziC TzuQ== X-Gm-Message-State: AOAM533AVoxs0t0lFQiHxjQS9jX77LIEC2rt0S1SQqUKaYMS54jOBfSU qugYlJL8T8dYb1L3HLEs06MqTsyiDnPIdjRY1QY= X-Google-Smtp-Source: ABdhPJxAe1QMFAbECHgRxLYYLfH7f7qCwK33kAHRdMfn3ZyL+FSkCt2Xb9IQrfSWqKGOZbz3/dV+APyLgNihHLRahlM= X-Received: by 2002:a05:6638:2694:: with SMTP id o20mr6506628jat.132.1612552889488; Fri, 05 Feb 2021 11:21:29 -0800 (PST) MIME-Version: 1.0 References: <20210204220741.GA920417@kernel.org> <20210205152823.GD920417@kernel.org> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Fri, 5 Feb 2021 20:21:18 +0100 Message-ID: Subject: Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type To: Yonghong Song Cc: Arnaldo Carvalho de Melo , dwarves@vger.kernel.org, Linux Kernel Mailing List , bpf@vger.kernel.org, Jiri Olsa , Jan Engelhardt , Domenico Andreoli , Matthias Schwarzott , Andrii Nakryiko , Mark Wieelard , Paul Moore , Ondrej Mosnacek , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Tom Stellard , Fangrui Song Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 8:15 PM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 8:10 PM Yonghong Song wrote: > > > > > > > > On 2/5/21 11:06 AM, Sedat Dilek wrote: > > > On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote: > > >> > > >> On Fri, Feb 5, 2021 at 6:48 PM Sedat Dilek wrote: > > >>> > > >>> On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de Melo > > >>> wrote: > > >>>> > > >>>> Em Fri, Feb 05, 2021 at 04:23:59PM +0100, Sedat Dilek escreveu: > > >>>>> On Fri, Feb 5, 2021 at 3:41 PM Sedat Dilek wrote: > > >>>>>> > > >>>>>> On Fri, Feb 5, 2021 at 3:37 PM Sedat Dilek wrote: > > >>>>>>> > > >>>>>>> Hi, > > >>>>>>> > > >>>>>>> when building with pahole v1.20 and binutils v2.35.2 plus Clang > > >>>>>>> v12.0.0-rc1 and DWARF-v5 I see: > > >>>>>>> ... > > >>>>>>> + info BTF .btf.vmlinux.bin.o > > >>>>>>> + [ != silent_ ] > > >>>>>>> + printf %-7s %s\n BTF .btf.vmlinux.bin.o > > >>>>>>> BTF .btf.vmlinux.bin.o > > >>>>>>> + LLVM_OBJCOPY=/opt/binutils/bin/objcopy /opt/pahole/bin/pahole -J > > >>>>>>> .tmp_vmlinux.btf > > >>>>>>> [115] INT DW_ATE_unsigned_1 Error emitting BTF type > > >>>>>>> Encountered error while encoding BTF. > > >>>>>> > > >>>>>> Grepping the pahole sources: > > >>>>>> > > >>>>>> $ git grep DW_ATE > > >>>>>> dwarf_loader.c: bt->is_bool = encoding == DW_ATE_boolean; > > >>>>>> dwarf_loader.c: bt->is_signed = encoding == DW_ATE_signed; > > >>>>>> > > >>>>>> Missing DW_ATE_unsigned encoding? > > >>>>>> > > >>>>> > > >>>>> Checked the LLVM sources: > > >>>>> > > >>>>> clang/lib/CodeGen/CGDebugInfo.cpp: Encoding = > > >>>>> llvm::dwarf::DW_ATE_unsigned_char; > > >>>>> clang/lib/CodeGen/CGDebugInfo.cpp: Encoding = llvm::dwarf::DW_ATE_unsigned; > > >>>>> clang/lib/CodeGen/CGDebugInfo.cpp: Encoding = > > >>>>> llvm::dwarf::DW_ATE_unsigned_fixed; > > >>>>> clang/lib/CodeGen/CGDebugInfo.cpp: > > >>>>> ? llvm::dwarf::DW_ATE_unsigned > > >>>>> ... > > >>>>> lld/test/wasm/debuginfo.test:CHECK-NEXT: DW_AT_encoding > > >>>>> (DW_ATE_unsigned) > > >>>>> > > >>>>> So, I will switch from GNU ld.bfd v2.35.2 to LLD-12. > > >>>> > > >>>> Thanks for the research, probably your conclusion is correct, can you go > > >>>> the next step and add that part and check if the end result is the > > >>>> expected one? > > >>>> > > >>> > > >>> Still building... > > >>> > > >>> Can you give me a hand on what has to be changed in dwarves/pahole? > > >>> > > >>> I guess switching from ld.bfd to ld.lld will show the same ERROR. > > >>> > > >> > > >> This builds successfully - untested: > > >> > > >> $ git diff > > >> diff --git a/btf_loader.c b/btf_loader.c > > >> index ec286f413f36..a39edd3362db 100644 > > >> --- a/btf_loader.c > > >> +++ b/btf_loader.c > > >> @@ -107,6 +107,7 @@ static struct base_type *base_type__new(strings_t > > >> name, uint32_t attrs, > > >> bt->bit_size = size; > > >> bt->is_signed = attrs & BTF_INT_SIGNED; > > >> bt->is_bool = attrs & BTF_INT_BOOL; > > >> + bt->is_unsigned = attrs & BTF_INT_UNSIGNED; > > >> bt->name_has_encoding = false; > > >> bt->float_type = float_type; > > >> } > > >> diff --git a/ctf.h b/ctf.h > > >> index 25b79892bde3..9e47c3c74677 100644 > > >> --- a/ctf.h > > >> +++ b/ctf.h > > >> @@ -100,6 +100,7 @@ struct ctf_full_type { > > >> #define CTF_TYPE_INT_CHAR 0x2 > > >> #define CTF_TYPE_INT_BOOL 0x4 > > >> #define CTF_TYPE_INT_VARARGS 0x8 > > >> +#define CTF_TYPE_INT_UNSIGNED 0x16 > > >> > > >> #define CTF_TYPE_FP_ATTRS(VAL) ((VAL) >> 24) > > >> #define CTF_TYPE_FP_OFFSET(VAL) (((VAL) >> 16) & 0xff) > > >> diff --git a/dwarf_loader.c b/dwarf_loader.c > > >> index b73d7867e1e6..79d40f183c24 100644 > > >> --- a/dwarf_loader.c > > >> +++ b/dwarf_loader.c > > >> @@ -473,6 +473,7 @@ static struct base_type *base_type__new(Dwarf_Die > > >> *die, struct cu *cu) > > >> bt->is_bool = encoding == DW_ATE_boolean; > > >> bt->is_signed = encoding == DW_ATE_signed; > > >> bt->is_varargs = false; > > >> + bt->is_unsigned = encoding == DW_ATE_unsigned; > > >> bt->name_has_encoding = true; > > >> } > > >> > > >> diff --git a/dwarves.h b/dwarves.h > > >> index 98caf1abc54d..edf32d2e6f80 100644 > > >> --- a/dwarves.h > > >> +++ b/dwarves.h > > >> @@ -1261,6 +1261,7 @@ struct base_type { > > >> uint8_t is_signed:1; > > >> uint8_t is_bool:1; > > >> uint8_t is_varargs:1; > > >> + uint8_t is_unsigned:1; > > >> uint8_t float_type:4; > > >> }; > > >> > > >> diff --git a/lib/bpf b/lib/bpf > > >> --- a/lib/bpf > > >> +++ b/lib/bpf > > >> @@ -1 +1 @@ > > >> -Subproject commit 5af3d86b5a2c5fecdc3ab83822d083edd32b4396 > > >> +Subproject commit 5af3d86b5a2c5fecdc3ab83822d083edd32b4396-dirty > > >> diff --git a/libbtf.c b/libbtf.c > > >> index 9f7628304495..a0661a7bbed9 100644 > > >> --- a/libbtf.c > > >> +++ b/libbtf.c > > >> @@ -247,6 +247,8 @@ static const char * > > >> btf_elf__int_encoding_str(uint8_t encoding) > > >> return "CHAR"; > > >> else if (encoding == BTF_INT_BOOL) > > >> return "BOOL"; > > >> + else if (encoding == BTF_INT_UNSIGNED) > > >> + return "UNSIGNED"; > > >> else > > >> return "UNKN"; > > >> } > > >> @@ -379,6 +381,8 @@ int32_t btf_elf__add_base_type(struct btf_elf > > >> *btfe, const struct base_type *bt, > > >> encoding = BTF_INT_SIGNED; > > >> } else if (bt->is_bool) { > > >> encoding = BTF_INT_BOOL; > > >> + } else if (bt->is_unsigned) { > > >> + encoding = BTF_INT_UNSIGNED; > > >> } else if (bt->float_type) { > > >> fprintf(stderr, "float_type is not supported\n"); > > >> return -1; > > >> > > >> Additionally - I cannot see it with `git diff`: > > >> > > >> [ lib/bpf/include/uapi/linux/btf.h ] > > >> > > >> /* Attributes stored in the BTF_INT_ENCODING */ > > >> #define BTF_INT_SIGNED (1 << 0) > > >> #define BTF_INT_CHAR (1 << 1) > > >> #define BTF_INT_BOOL (1 << 2) > > >> #define BTF_INT_UNSIGNED (1 << 3) > > >> > > >> Comments? > > >> > > > > > > Hmmm... > > > > > > + info BTF .btf.vmlinux.bin.o > > > + [ != silent_ ] > > > + printf %-7s %s\n BTF .btf.vmlinux.bin.o > > > BTF .btf.vmlinux.bin.o > > > + LLVM_OBJCOPY=llvm-objcopy /opt/pahole/bin/pahole -J .tmp_vmlinux.btf > > > [2] INT long unsigned int Error emitting BTF type > > > Encountered error while encoding BTF. > > > + llvm-objcopy --only-section=.BTF --set-section-flags > > > .BTF=alloc,readonly --strip-all .tmp_vmlinux.btf .btf.vmlinux.bin.o > > > ... > > > + info BTFIDS vmlinux > > > + [ != silent_ ] > > > + printf %-7s %s\n BTFIDS vmlinux > > > BTFIDS vmlinux > > > + ./tools/bpf/resolve_btfids/resolve_btfids vmlinux > > > FAILED: load BTF from vmlinux: Invalid argument > > > + on_exit > > > + [ 255 -ne 0 ] > > > + cleanup > > > + rm -f .btf.vmlinux.bin.o > > > + rm -f .tmp_System.map > > > + rm -f .tmp_vmlinux.btf .tmp_vmlinux.kallsyms1 > > > .tmp_vmlinux.kallsyms1.S .tmp_vmlinux.kallsyms1.o > > > .tmp_vmlinux.kallsyms2 .tmp_vmlinux.kallsyms2.S .tmp_vmlinux.kallsyms > > > 2.o > > > + rm -f System.map > > > + rm -f vmlinux > > > + rm -f vmlinux.o > > > make[3]: *** [Makefile:1166: vmlinux] Error 255 > > > > > > Grepping through linux.git/tools I guess some BTF tools/libs need to > > > know what BTF_INT_UNSIGNED is? > > > > BTF_INT_UNSIGNED needs kernel support. Maybe to teach pahole to > > ignore this for now until kernel infrastructure is ready. > > Not sure whether this information will be useful or not > > for BTF. This needs to be discussed separately. > > > > [ CC Fangrui ] > > How can I teach pahole to ignore BTF_INT_UNSIGNED? > > Another tryout might be to use "-fbinutils-version=..." which is > available for LLVM-12 according to Fangrui? > Fangrui, which binutils versions can I pass and how? > OK, I checked LLVM-12 sources: clang/docs/ReleaseNotes.rst:101:- New option ``-fbinutils-version=`` specifies the targeted binutils version. clang/docs/ReleaseNotes.rst:102: For example, ``-fbinutils-version=2.35`` means compatibility with GNU as/ld clang/docs/ReleaseNotes.rst-103- before 2.35 is not needed: new features can be used and there is no need to clang/docs/ReleaseNotes.rst-104- work around old GNU as/ld bugs. Can I pass (also patchlevel) like 2.35.2? Here I have Debian's v2.35.1 and a selfmade v2.35.2? - Sedat - - Sedat -