From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F80C4BA10 for ; Wed, 26 Feb 2020 12:26:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19FF324684 for ; Wed, 26 Feb 2020 12:26:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IHFSmI4j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727237AbgBZM0k (ORCPT ); Wed, 26 Feb 2020 07:26:40 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37979 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgBZM0k (ORCPT ); Wed, 26 Feb 2020 07:26:40 -0500 Received: by mail-wm1-f66.google.com with SMTP id a9so2838492wmj.3; Wed, 26 Feb 2020 04:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=V8gMewY634WDFQZep0rl6hNrs2zu+VbqsCL1SpOtlb0=; b=IHFSmI4juYhHMRYVx8UOXXzqtfXiwhzFC7fuLYcWeRdzpm1yfNt6Vj1prjQdPvMauM 4k9EKV+jiOb39j6DdIGSvb5pXlbn1bq8GqT3+LErN1gTmJs8y3yj7OxdMnvvAz571F+e wJRAdxNkBN9viXqrDaxGkI412mWjm2FKo5DRI1FN+YjKIt4bYbCrHXQ9XqPIAyzvEXPg 25O6rdrR7WjAlEAnXZHOVZizS3pRFp8TKDBPWJI4dKKh2xQvpJtOYWAiqahqwUrED96U LI15mWGVV6Or8+OUWgTXPnaiXE5JweGr4sygwTpyWhB4IJpzv5z3HtkgqMDIYcVH2U/F Ezyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=V8gMewY634WDFQZep0rl6hNrs2zu+VbqsCL1SpOtlb0=; b=Sdi5QLS6HhoJz/5akBkwhdjlX6GIDDxrAgplSjPXKdtxAmB+Xp52/dY7U8fKRDUZja D6ktpM1oUlxHJuZnBXyG9QxNEnqXGOVlCrBOtLuSTRHfDwA6Hf0ix0JHCZaecLYDR3Y0 27vsJKQdV14Vr3JZdTa1vRHHe89ZEZzgZ3QWLbmvPuzojUh5DRQemblZufyRJ2LgvKOW 1UaMG0KKYL7SlHXVB9rzKQ5aYuDZjVNmtjDJyLMNKMFbRH3nNKz52P7tUwN/yoTxy6jM z+wAq6oLb8e6CD7SPwbRb0fxmbx5hb1eiytVxRsxRhYEjQ9C9kcpUiaD5LAoz+ruIAej RHcQ== X-Gm-Message-State: APjAAAXDO+R5XDSGCvyHpNxQYNKC/Bgcbd7sFUSOLXwXbjxmMu+a/FvD UgWW18HHmdyXMC0Q2EJiw4VVQ7JpOW2YzbkDQdI= X-Google-Smtp-Source: APXvYqwJSp6y5t6j/YDSKsw2/NttcfYRM0gx0AAnvvsYnMrceEUhwETgdXNNCRvQxdUejjKm2ZwCaS32bGDuwAKf2os= X-Received: by 2002:a05:600c:2285:: with SMTP id 5mr5218941wmf.64.1582719997984; Wed, 26 Feb 2020 04:26:37 -0800 (PST) MIME-Version: 1.0 References: <20200224174129.2664-1-ndesaulniers@google.com> <20200225210250.64366-1-ndesaulniers@google.com> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Wed, 26 Feb 2020 13:29:07 +0100 Message-ID: Subject: Re: [PATCH v2] Documentation/llvm: add documentation on building w/ Clang/LLVM To: Masahiro Yamada Cc: Nick Desaulniers , Jonathan Corbet , Randy Dunlap , Kees Cook , Nathan Chancellor , Michal Marek , Linux Kbuild mailing list , "open list:DOCUMENTATION" , Linux Kernel Mailing List , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 12:31 PM Masahiro Yamada wrote: > > Hi. > > > On Wed, Feb 26, 2020 at 6:02 AM Nick Desaulniers > wrote: > > > > Added to kbuild documentation. Provides more official info on building > > kernels with Clang and LLVM than our wiki. > > > > Suggested-by: Randy Dunlap > > Reviewed-by: Kees Cook > > Reviewed-by: Nathan Chancellor > > Reviewed-by: Sedat Dilek > > Signed-off-by: Nick Desaulniers > > --- > > Changes V1 -> V2: > > * s/On going/ongoing/ > > * add Randy's Suggested-by > > > I do not understand this tag update. > > As far as I saw the review process, > I do not think Randy deserves to have Suggested-by > because he just pointed out a typo (on going -> ongoing) : > https://patchwork.kernel.org/patch/11401189/#23179575 > > (or, was there off-line activity I had missed?) > Hi Masahiro, I got some credits from Nick for a review by seeing a typo - not on a review of the code - and H. Peter Anvin asked why. I am not sure what is here the correct credit to give. Depends a "Reviewed-by" and/or "Suggested-by" on a technical review? My POV: When people take time to look over patches they should get credits - sort of esteem. Regards, - Sedat - P.S.: Tipp: Use codespell to find typos :-). [1] https://git.kernel.org/linus/0e2e160033283e20f688d8bad5b89460cc5bfcc4 "x86/asm: Add _ASM_ARG* constants for argument registers to "