From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751292AbbEBG5Q (ORCPT ); Sat, 2 May 2015 02:57:16 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:35455 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbbEBG5J (ORCPT ); Sat, 2 May 2015 02:57:09 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <1430516505-4812-1-git-send-email-aricart@memnix.com> Date: Sat, 2 May 2015 08:57:08 +0200 Message-ID: Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2] From: Sedat Dilek To: Linus Torvalds Cc: Abelardo Ricart III , Michal Marek , Linux Kernel Mailing List , David Howells , keyrings@linux-nfs.org, Rusty Russell , LSM List , James Morris , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 2, 2015 at 6:12 AM, Linus Torvalds wrote: > On Fri, May 1, 2015 at 2:41 PM, Abelardo Ricart III wrote: >> >> Here's my two-line patch strictly defining the build order, for your perusal. > > Ok, so this looks possible and sounds like it could explain the issues. > > But I'd like somebody who is much more familiar with these kinds of > subtleties in 'make' to take anothe rlook and ack it. Because I had > personally never even heard (much less used) about these magical GNU > make "order-only prerequisites". Live and learn. > >> -signing_key.priv signing_key.x509: x509.genkey >> +signing_key.priv signing_key.x509: | x509.genkey >> + $(warning *** X.509 module signing key pair not found in root of source tree ***) > > So we shouldn't warn about this. The "generate random key" should be > the normal action for just about everybody but actual preduction > vendor builds. It's definitely not an error condition. > > But that ": |" syntax is interesting. I quick grep does show that we > do have a few previous uses, so I guess we really *do* use just about > every possible feature of GNU make even if I wasn't aware of this > one.. > > The "generate random key" does seem to be a similar "prep" phase as > the __dtbs_install_prep thing we do in the dtb install. > > Adding Michal Marek to the cc, since I want an Ack from somebody who > knows the details of GNU make more than I do. Anybody else who is a > makefile God? > /me no GNU/make or Makefile guru. When dealing with .PHONY targets [2] within the Freetz router project I bookmarked the below links. So there exists ".NOTPARALLEL" [1]. Maybe its use can be a "hacky" possibility to workaround the issue (cannot tell you about version-prereqs of GNU/make). My 0,02cents. - Sedat - [1] https://www.gnu.org/software/make/manual/html_node/Special-Targets.html [2] https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html