From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A63C433DB for ; Fri, 29 Jan 2021 22:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CF7664E3A for ; Fri, 29 Jan 2021 22:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233525AbhA2WMo (ORCPT ); Fri, 29 Jan 2021 17:12:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhA2WMh (ORCPT ); Fri, 29 Jan 2021 17:12:37 -0500 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B55C061574; Fri, 29 Jan 2021 14:11:57 -0800 (PST) Received: by mail-io1-xd29.google.com with SMTP id d13so10957929ioy.4; Fri, 29 Jan 2021 14:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=+8OZzNek+pmYC0wT8G3ozIZ31/2ufP4f1prU8RslqD4=; b=mByCb7VgfLxGfewcvF1UUuS4SIxKxYlpjAtEqCTDdQ2tNo3GJNyM6iFYT4CPiN0bxc xW+FKR6NKOxUBr6VEK7kKXol9mudxJ1GjJL9iyVoqbf/Rnf/JtcZD+8QwUnlBUEjPJHC qyrPgEJYCTNnfEACcd9WccagC5i8lHWiFOuSIXons8EhDQcxyEyL3BGmk4cQVrMLTjkm ea3XyJe7a+ePwQYRRwtrhO6uuG0J73Qs+mN58DMYDf9GXrtf1dvhgOy+kLZG9s16+WCn S34KpDSYGH6Fhm4nFZZsMdo3qNyrj8nagsAj8GzAt5pYoTF3VPsxCnnKrzRBh1nsvW9Y yc+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=+8OZzNek+pmYC0wT8G3ozIZ31/2ufP4f1prU8RslqD4=; b=CXwh4C8dDkeBQ6DDq6Lul/YqCzeNQBhoPaCufcJbq6eNdHHch2D54cHIxGwIzQV5hX w9o1g+PWDkm69sQOmFlMeZKYeByW2thhRgpFve6VNJFvOrUOGKOHhOZp9Ok5Y6gZl14i tXj42XDRdb7otLYnacuji3jfEX/3OpMUMr7bNUKfyj/e+8YHSrviamNTL+xh9zg3Ykmb SY/4urdXvnBAdsjujE1+xBgO2KI/Mt9kbsmnjXyGFyNaailOc8upgfwg1l4vd/7pvyYf 9vkPChKYzwo8QKAvcj7HDC+tzgQA86qHQIgdfeJnge+Gn3kAaTh4+NgB+SD+3pFxa4Sr W2Uw== X-Gm-Message-State: AOAM533whnkT2h+JiR51Lb95W88a7ybOLN06djObL3yAc4G1MBZ4hcWs umpzpuQe50+erWJERWxO5qB0p6Nzcwrn3Zqgn74= X-Google-Smtp-Source: ABdhPJwIqAvW70PYChqabsitwi8rzXPM8Yo2W7GUzXnqPcj77R7md1jNHX1J5FeSt8eELhV+QFMaDxiuGridgml0D80= X-Received: by 2002:a02:b78e:: with SMTP id f14mr5654308jam.97.1611958316390; Fri, 29 Jan 2021 14:11:56 -0800 (PST) MIME-Version: 1.0 References: <20210129194318.2125748-1-ndesaulniers@google.com> <20210129194318.2125748-3-ndesaulniers@google.com> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Fri, 29 Jan 2021 23:11:44 +0100 Message-ID: Subject: Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5 To: Nick Desaulniers Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , LKML , Clang-Built-Linux ML , Linux Kbuild mailing list , linux-arch , Jakub Jelinek , Fangrui Song , Caroline Tice , Nick Clifton , Yonghong Song , Jiri Olsa , Andrii Nakryiko , Arnaldo Carvalho de Melo , Arvind Sankar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > > > > > > > > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > > > > > wrote: > > > > > > > > > > > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote: > > > > > > > > > > > > > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers > > > > > > > wrote: > > > > > > > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > > > > index 20141cd9319e..bed8b3b180b8 100644 > > > > > > > > --- a/Makefile > > > > > > > > +++ b/Makefile > > > > > > > > @@ -832,8 +832,20 @@ endif > > > > > > > > > > > > > > > > dwarf-version-$(CONFIG_DEBUG_INFO_DWARF2) := 2 > > > > > > > > dwarf-version-$(CONFIG_DEBUG_INFO_DWARF4) := 4 > > > > > > > > +dwarf-version-$(CONFIG_DEBUG_INFO_DWARF5) := 5 > > > > > > > > DEBUG_CFLAGS += -gdwarf-$(dwarf-version-y) > > > > > > > > > > > > > > > > +# If using clang without the integrated assembler, we need to explicitly tell > > > > > > > > +# GAS that we will be feeding it DWARF v5 assembler directives. Kconfig should > > > > > > > > +# detect whether the version of GAS supports DWARF v5. > > > > > > > > +ifdef CONFIG_CC_IS_CLANG > > > > > > > > +ifneq ($(LLVM_IAS),1) > > > > > > > > +ifeq ($(dwarf-version-y),5) > > > > > > > > +DEBUG_CFLAGS += -Wa,-gdwarf-5 > > > > > > > > > > > > > > I noticed double "-g -gdwarf-5 -g -gdwarf-5" (a different issue) and > > > > > > > that's why I looked again into the top-level Makefile. > > > > > > > > > > > > That's...unexpected. I don't see where that could be coming from. > > > > > > Can you tell me please what is the precise command line invocation of > > > > > > make and which source file you observed this on so that I can > > > > > > reproduce? > > > > > > > > > > > > > > > > That's everywhere... > > > > > > > > > > $ zstdgrep --color '\-g -gdwarf-5 -g -gdwarf-5' > > > > > build-log_5.11.0-rc5-8-amd64-clang12-lto.txt.zst > > > > > | wc -l > > > > > 29529 > > > > > > > > I'm not able to reproduce. > > > > > > > > $ make LLVM=1 -j72 V=1 2>&1 | grep dwarf > > > > ... > > > > clang ... -g -gdwarf-5 -Wa,-gdwarf-5 ... > > > > ... > > > > > > > > $ make LLVM=1 LLVM_IAS=1 -j72 V=1 2>&1 | grep dwarf > > > > ... > > > > clang ... -g -gdwarf-5 ... > > > > ... > > > > > > > > > > Hmm... > > > > > > I do not see in my current build "-Wa,-gdwarf-5" is passed with v6. > > > > > > $ grep '\-Wa,-gdwarf-5' build-log_5.11.0-rc5-10-amd64-clang12-lto-pgo.txt > > > [ empty ] > > > > > > > That's the diff v5 -> v6... > > > > There is no more a dwarf-aflag / KBUILD_AFLAGS += $(dwarf-aflag) used. > > Yep; not sure that's relevant though to duplicate flags? > > > > > Can you tell me please what is the precise command line invocation of > > > > make and which source file you observed this on so that I can > > > > reproduce? > > If you don't send me your invocation of `make`, I cannot help you. > /usr/bin/perf_5.10 stat make V=1 -j4 LLVM=1 LLVM_IAS=1 PAHOLE=/opt/pahole/bin/pahole LOCALVERSION=-10-amd64-clang12 -lto-pgo KBUILD_VERBOSE=1 KBUILD_BUILD_HOST=iniza KBUILD_BUILD_USER=sedat.dilek@gmail.com KBUILD_BUILD_TIMESTAMP=2021-01-29 bindeb-pkg KDEB_PKGVERSION=5.11.0~rc5-10~bullseye+dileks1 - Sedat -