From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D837C3A5A7 for ; Wed, 4 Sep 2019 06:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAC9222CED for ; Wed, 4 Sep 2019 06:58:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bEvfwzRj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729056AbfIDG6p (ORCPT ); Wed, 4 Sep 2019 02:58:45 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37749 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728209AbfIDG6o (ORCPT ); Wed, 4 Sep 2019 02:58:44 -0400 Received: by mail-wm1-f67.google.com with SMTP id r195so2198518wme.2; Tue, 03 Sep 2019 23:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=KWmW+oWQFGKi51bkdJL4MPU5H1s+9PExDQrlcRepgRE=; b=bEvfwzRjUKb4pM1HXpsZwPRD/ELavcFebHs36Gso+gqzfnGKmH/YqkP5Bm/by8doVX 4YpAasu544zbTRw2NLoLNpKTAkKmENHbAyUw8nkhadbR+jBvpOYb17fBt4KgEIp6QJsq /n6v6TWyxUYdMHuBAeDJoGnR4jYdfqaaN4x/anprZterJudD2e6sbaTXgfDNfOMFiaSr F6OJEPCQB521eKu8sQUb5mLDjWYSvLqvrST81Ey2ZrvBjKj1KUIe5CYmOtR5GRKhrDq1 LqKQ7i7OdUgdtgzHz3uXdeccIfgzei+EPSZoreXIo5Qg0aleH2M3HJ/1aIMDLdWQs8bD +MfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=KWmW+oWQFGKi51bkdJL4MPU5H1s+9PExDQrlcRepgRE=; b=TmFryg4fDirhQOex+QJRiEoU+Ro635Rf5DYAkXF0Tdk2AhR1rFnRRozIYqEeUu+UYv gWZ61tuVF4At+GnADmONvwAwzhhrg8WTHSsPCzkIsIwayRQFxwlvddmaRLo6c08G/cIu OilT4M/bC3OWOQXAw7KBmZ90PZkw3HJaWIl7h+6D+GHBX5erBE6dtQ/jYZbaMbSnTYxe /4AAlwkSzpbLDK9vkLKDpFNeCnc1C+ld6AxWK15zYON3gcyuEGNDh7hGUZXuVn7r8UIu UZ/T5jTC7WG5JpO3bROtoe94dN/2NVi17CeQuhGLNf2SslHi+YDiqzc8szzpfe13CE+3 it1Q== X-Gm-Message-State: APjAAAVBzh37BqeXrGENwaoJwKgWkgDNQfnq4jgzKjlYW8s53NOzwEB3 rXytunC44s1XyEcWzq8My+lz4RYVHIiDXwCyO98= X-Google-Smtp-Source: APXvYqymuiwnfI8bTIjyszWC545Ezi3MTAGcehZg62xYdM/qosto6J8AjtCgoXvMpLPRRuNwoVqbX0xqdgh1WiBySRo= X-Received: by 2002:a7b:c8ca:: with SMTP id f10mr2847649wml.36.1567580321590; Tue, 03 Sep 2019 23:58:41 -0700 (PDT) MIME-Version: 1.0 References: <20190831162555.31887-1-yamada.masahiro@socionext.com> <20190831162555.31887-2-yamada.masahiro@socionext.com> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Wed, 4 Sep 2019 08:58:30 +0200 Message-ID: Subject: Re: [PATCH v3 2/2] kbuild: rename KBUILD_ENABLE_EXTRA_GCC_CHECKS to KBUILD_EXTRA_WARN To: Nick Desaulniers Cc: Masahiro Yamada , Linux Kbuild mailing list , Nathan Chancellor , Jonathan Corbet , Michal Marek , clang-built-linux , linux-doc@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 3, 2019 at 11:50 PM Nick Desaulniers wrote: > > On Sat, Aug 31, 2019 at 9:26 AM Masahiro Yamada > wrote: > > > > KBUILD_ENABLE_EXTRA_GCC_CHECKS started as a switch to add extra warning > > options for GCC, but now it is a historical misnomer since we use it > > also for Clang, DTC, and even kernel-doc. > > Thanks for the patch! > Reviewed-by: Nick Desaulniers > Thanks for the patch. I like the backward compatibility and am OK with pointing to 'make --help' for the documentation part (KISS - Keep It Simple and Short/Stupid). Reviewed-by: Sedat Dilek - Sedat - > > > > Rename it to more sensible, and shorter KBUILD_EXTRA_WARN. > > > > For the backward compatibility, KBUILD_ENABLE_EXTRA_GCC_CHECKS is still > > supported (but not advertised in the documentation). > > > > I also fixed up 'make help', and updated the documentation. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > Changes in v3: > > - new patch > > > > Changes in v2: None > > > > Documentation/kbuild/kbuild.rst | 14 +++++++++----- > > Makefile | 2 +- > > scripts/Makefile.build | 2 +- > > scripts/Makefile.extrawarn | 13 +++++++++---- > > scripts/Makefile.lib | 4 ++-- > > scripts/genksyms/Makefile | 2 +- > > 6 files changed, 23 insertions(+), 14 deletions(-) > > > > diff --git a/Documentation/kbuild/kbuild.rst b/Documentation/kbuild/kbuild.rst > > index 62f9d86c082c..f1e5dce86af7 100644 > > --- a/Documentation/kbuild/kbuild.rst > > +++ b/Documentation/kbuild/kbuild.rst > > @@ -105,6 +105,15 @@ The output directory can also be specified using "O=...". > > > > Setting "O=..." takes precedence over KBUILD_OUTPUT. > > > > +KBUILD_EXTRA_WARN > > +----------------- > > +Specify the extra build checks. The same value can be assigned by passing > > +W=... from the command line. > > + > > +See `make help` for the list of the supported values. > > + > > +Setting "W=..." takes precedence over KBUILD_EXTRA_WARN. > > + > > KBUILD_DEBARCH > > -------------- > > For the deb-pkg target, allows overriding the normal heuristics deployed by > > @@ -241,11 +250,6 @@ To get all available archs you can also specify all. E.g.:: > > > > $ make ALLSOURCE_ARCHS=all tags > > > > -KBUILD_ENABLE_EXTRA_GCC_CHECKS > > ------------------------------- > > -If enabled over the make command line with "W=1", it turns on additional > > -gcc -W... options for more extensive build-time checking. > > - > > KBUILD_BUILD_TIMESTAMP > > ---------------------- > > Setting this to a date string overrides the timestamp used in the > > diff --git a/Makefile b/Makefile > > index 06e1e21c0f45..016d72eb3ddf 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1538,7 +1538,7 @@ help: > > @echo ' make C=1 [targets] Check re-compiled c source with $$CHECK (sparse by default)' > > @echo ' make C=2 [targets] Force check of all c source with $$CHECK' > > @echo ' make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections' > > - @echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where' > > + @echo ' make W=n [targets] Enable extra checks, n=1,2,3 where' > > @echo ' 1: warnings which may be relevant and do not occur too often' > > @echo ' 2: warnings which occur quite often but may still be relevant' > > @echo ' 3: more obscure warnings, can most likely be ignored' > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > > index 2a21ca86b720..f72aba64d611 100644 > > --- a/scripts/Makefile.build > > +++ b/scripts/Makefile.build > > @@ -85,7 +85,7 @@ else ifeq ($(KBUILD_CHECKSRC),2) > > cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< > > endif > > > > -ifneq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),) > > +ifneq ($(KBUILD_EXTRA_WARN),) > > cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< > > endif > > > > diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn > > index d226c5fb13e2..53eb7e0c6a5a 100644 > > --- a/scripts/Makefile.extrawarn > > +++ b/scripts/Makefile.extrawarn > > @@ -8,14 +8,19 @@ > > > > KBUILD_CFLAGS += $(call cc-disable-warning, packed-not-aligned) > > > > +# backward compatibility > > +KBUILD_EXTRA_WARN ?= $(KBUILD_ENABLE_EXTRA_GCC_CHECKS) > > + > > ifeq ("$(origin W)", "command line") > > - export KBUILD_ENABLE_EXTRA_GCC_CHECKS := $(W) > > + KBUILD_EXTRA_WARN := $(W) > > endif > > > > +export KBUILD_EXTRA_WARN > > + > > # > > # W=1 - warnings which may be relevant and do not occur too often > > # > > -ifneq ($(findstring 1, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) > > +ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),) > > > > KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter > > KBUILD_CFLAGS += -Wmissing-declarations > > @@ -48,7 +53,7 @@ endif > > # > > # W=2 - warnings which occur quite often but may still be relevant > > # > > -ifneq ($(findstring 2, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) > > +ifneq ($(findstring 2, $(KBUILD_EXTRA_WARN)),) > > > > KBUILD_CFLAGS += -Wcast-align > > KBUILD_CFLAGS += -Wdisabled-optimization > > @@ -65,7 +70,7 @@ endif > > # > > # W=3 - more obscure warnings, can most likely be ignored > > # > > -ifneq ($(findstring 3, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) > > +ifneq ($(findstring 3, $(KBUILD_EXTRA_WARN)),) > > > > KBUILD_CFLAGS += -Wbad-function-cast > > KBUILD_CFLAGS += -Wcast-qual > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > > index 7ab17712ab24..df83967268ba 100644 > > --- a/scripts/Makefile.lib > > +++ b/scripts/Makefile.lib > > @@ -248,7 +248,7 @@ quiet_cmd_gzip = GZIP $@ > > DTC ?= $(objtree)/scripts/dtc/dtc > > > > # Disable noisy checks by default > > -ifeq ($(findstring 1,$(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) > > +ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),) > > DTC_FLAGS += -Wno-unit_address_vs_reg \ > > -Wno-unit_address_format \ > > -Wno-avoid_unnecessary_addr_size \ > > @@ -259,7 +259,7 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \ > > -Wno-pci_device_reg > > endif > > > > -ifneq ($(findstring 2,$(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) > > +ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),) > > DTC_FLAGS += -Wnode_name_chars_strict \ > > -Wproperty_name_chars_strict > > endif > > diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile > > index baf44ed0a93a..78629f515e78 100644 > > --- a/scripts/genksyms/Makefile > > +++ b/scripts/genksyms/Makefile > > @@ -12,7 +12,7 @@ genksyms-objs := genksyms.o parse.tab.o lex.lex.o > > # > > # Just in case, run "$(YACC) --version" without suppressing stderr > > # so that 'bison: not found' will be displayed if it is missing. > > -ifeq ($(findstring 1,$(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) > > +ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),) > > > > quiet_cmd_bison_no_warn = $(quiet_cmd_bison) > > cmd_bison_no_warn = $(YACC) --version >/dev/null; \ > > -- > > 2.17.1 > > > > > -- > Thanks, > ~Nick Desaulniers