From: Sedat Dilek <sedat.dilek@gmail.com>
To: Doug Smythies <dsmythies@telus.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Huang Rui <ray.huang@amd.com>,
li.meng@amd.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
Date: Fri, 20 Jan 2023 17:06:45 +0100 [thread overview]
Message-ID: <CA+icZUX-JEPR0obhwNgvRM6u=ifn4KZHaEFVdwRL8WffGe8hAQ@mail.gmail.com> (raw)
In-Reply-To: <001201d92c93$98c8a040$ca59e0c0$@telus.net>
On Fri, Jan 20, 2023 at 6:54 AM Doug Smythies <dsmythies@telus.net> wrote:
>
> Revert the portion of a recent Makefile change that incorrectly
> deletes source files when doing "make clean".
>
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
Hi Doug,
Thanks for the patch!
Small nit, I saw this with:
$ make -C tools/ clean
Otherwise:
Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
BR,
-Sedat-
> ---
> tools/testing/selftests/amd-pstate/Makefile | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5f195ee756d6..5fd1424db37d 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -7,11 +7,6 @@ all:
> uname_M := $(shell uname -m 2>/dev/null || echo not)
> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> -ifeq (x86,$(ARCH))
> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> -endif
> -
> TEST_PROGS := run.sh
> TEST_FILES := basic.sh tbench.sh gitsource.sh
>
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2023-01-20 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 5:54 [PATCH] selftests: amd-pstate: Don't delete source files via Makefile Doug Smythies
2023-01-20 9:17 ` Huang Rui
2023-01-20 16:11 ` Sedat Dilek
2023-01-20 16:15 ` Shuah Khan
2023-01-20 16:20 ` Sedat Dilek
2023-01-20 16:23 ` Shuah Khan
2023-01-20 16:06 ` Sedat Dilek [this message]
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2023-01-21 16:58 ` Sedat Dilek
2023-01-25 17:03 ` Shuah Khan
2023-01-26 22:43 ` Doug Smythies
2023-02-03 15:15 ` Guillaume Tucker
2023-02-03 16:26 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+icZUX-JEPR0obhwNgvRM6u=ifn4KZHaEFVdwRL8WffGe8hAQ@mail.gmail.com' \
--to=sedat.dilek@gmail.com \
--cc=dsmythies@telus.net \
--cc=li.meng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).