From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0403C433DB for ; Sat, 30 Jan 2021 23:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B633B64E08 for ; Sat, 30 Jan 2021 23:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232139AbhA3XkG (ORCPT ); Sat, 30 Jan 2021 18:40:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbhA3XkD (ORCPT ); Sat, 30 Jan 2021 18:40:03 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61A9DC061573; Sat, 30 Jan 2021 15:39:23 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id q5so12107384ilc.10; Sat, 30 Jan 2021 15:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=CA+t1dL75EerdwPHdKGgU/V0NlU+y75OmzU0/LZVlt8=; b=OMQ32M6pyY4263/GzInAl226zRqxnFVU3IMQy9sAvnxQVMkgi41EdNWgI4KPnTRxpp R4ljQG5P61ARZOyEAzr5s1SYV7Ig8vsErZHWlXwW0HGLy+cJXovpVX+ehrk9tnH6J5p5 iNBaez/2yxP7b21OhjQMK6iZANh1FNLoG9ruF40KQ/OHOeA93u8YCqSodpyWPILulquQ Nfg0XtYQs+ONI8ky+xKFlNOFAwCyAisqoCS/L0xsrbL7m5ME4Q6XU7aWcbG1hQdyyja2 qY8CdyFNVOFNmCQPaDcddeZaFmIMpu94zoUZCjpIS194UmwqOZ4u3r0xhjFA4tEQcdcQ uSKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=CA+t1dL75EerdwPHdKGgU/V0NlU+y75OmzU0/LZVlt8=; b=kyoeh+Ia1YWtiJsW21RBRWIXlPT1eONiri6OmBkniibxNv6sa3vHL3c7umRuYYm8QE LrqUkkiKr3KDuY4N1r6QcZyqSVV8tPnxlHghMuFiEDj9W0BNVYZWqfrQPO0M5aPAGx2B LVvfC/L8iglZTL+uIdhLLwtPZ39Jj1gUZkyRmMD7yqGLYZjwApCMqUfjybfVIXBXmeHi liKmPMwrHmhIv8PETpaXIoipQkXJWdIAxdrrQbfcylyDN98/7fG5aANZcOqKRGb5BMjd notQKV72DOf7H43sEEZwIiNDk86yclYSshmWNf3+1ERc7xoinSNZJOIbBJi9CG4zc2qq xYTg== X-Gm-Message-State: AOAM532snHOHf5uVeMZkIUXhX3xa4dfiGv8C/1maf98a8kOWvABycIwe KP/rUtJYqsDU5oTwKM3odtn1d5xktC/uJ7h/0YrdPZErNZr8zw== X-Google-Smtp-Source: ABdhPJzPDBNYn+qKMcdj0LMtBkS+DqM6z1zLoRUviMNSTowrAg2jT7H/b00UG4h7XWLPxw+l0JOhG4kSHsXNLCZSu3c= X-Received: by 2002:a05:6e02:d0:: with SMTP id r16mr7786122ilq.112.1612049962550; Sat, 30 Jan 2021 15:39:22 -0800 (PST) MIME-Version: 1.0 References: <20210130004401.2528717-1-ndesaulniers@google.com> <20210130004401.2528717-3-ndesaulniers@google.com> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Sun, 31 Jan 2021 00:39:11 +0100 Message-ID: Subject: Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5 To: Nick Desaulniers Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , linux-kernel@vger.kernel.org, Clang-Built-Linux ML , linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, Jakub Jelinek , Fangrui Song , Caroline Tice , Nick Clifton , Yonghong Song , Jiri Olsa , Andrii Nakryiko , Arnaldo Carvalho de Melo , Arvind Sankar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 31, 2021 at 12:10 AM Sedat Dilek wrote: > > On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers > wrote: > > > > DWARF v5 is the latest standard of the DWARF debug info format. > > > > Feature detection of DWARF5 is onerous, especially given that we've > > removed $(AS), so we must query $(CC) for DWARF5 assembler directive > > support. > > > > The DWARF version of a binary can be validated with: > > $ llvm-dwarfdump vmlinux | head -n 4 | grep version > > or > > $ readelf --debug-dump=3Dinfo vmlinux 2>/dev/null | grep Version > > > > DWARF5 wins significantly in terms of size when mixed with compression > > (CONFIG_DEBUG_INFO_COMPRESSED). > > > > 363M vmlinux.clang12.dwarf5.compressed > > 434M vmlinux.clang12.dwarf4.compressed > > 439M vmlinux.clang12.dwarf2.compressed > > 457M vmlinux.clang12.dwarf5 > > 536M vmlinux.clang12.dwarf4 > > 548M vmlinux.clang12.dwarf2 > > > > 515M vmlinux.gcc10.2.dwarf5.compressed > > 599M vmlinux.gcc10.2.dwarf4.compressed > > 624M vmlinux.gcc10.2.dwarf2.compressed > > 630M vmlinux.gcc10.2.dwarf5 > > 765M vmlinux.gcc10.2.dwarf4 > > 809M vmlinux.gcc10.2.dwarf2 > > > > Though the quality of debug info is harder to quantify; size is not a > > proxy for quality. > > > > Jakub notes: > > All [GCC] 5.1 - 6.x did was start accepting -gdwarf-5 as experimental > > option that enabled some small DWARF subset (initially only a few > > DW_LANG_* codes newly added to DWARF5 drafts). Only GCC 7 (released > > after DWARF 5 has been finalized) started emitting DWARF5 section > > headers and got most of the DWARF5 changes in... > > > > Version check GCC so that we don't need to worry about the difference i= n > > command line args between GNU readelf and llvm-readelf/llvm-dwarfdump t= o > > validate the DWARF Version in the assembler feature detection script. > > > > GNU `as` only recently gained support for specifying -gdwarf-5, so when > > compiling with Clang but without Clang's integrated assembler > > (LLVM_IAS=3D1 is not set), explicitly add -Wa,-gdwarf-5 to DEBUG_CFLAGS= . > > > > Disabled for now if CONFIG_DEBUG_INFO_BTF is set; pahole doesn't yet > > recognize the new additions to the DWARF debug info. Thanks to Sedat fo= r > > the report. > > > > Link: http://www.dwarfstd.org/doc/DWARF5.pdf > > Reported-by: Sedat Dilek > > Suggested-by: Arvind Sankar > > Suggested-by: Caroline Tice > > Suggested-by: Fangrui Song > > Suggested-by: Jakub Jelinek > > Suggested-by: Masahiro Yamada > > Suggested-by: Nathan Chancellor > > Signed-off-by: Nick Desaulniers > > --- > > Makefile | 1 + > > include/asm-generic/vmlinux.lds.h | 7 ++++++- > > lib/Kconfig.debug | 18 ++++++++++++++++++ > > scripts/test_dwarf5_support.sh | 8 ++++++++ > > 4 files changed, 33 insertions(+), 1 deletion(-) > > create mode 100755 scripts/test_dwarf5_support.sh > > > > diff --git a/Makefile b/Makefile > > index d2b4980807e0..5387a6f2f62d 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -831,6 +831,7 @@ KBUILD_AFLAGS +=3D -Wa,-gdwarf-2 > > endif > > > > dwarf-version-$(CONFIG_DEBUG_INFO_DWARF4) :=3D 4 > > +dwarf-version-$(CONFIG_DEBUG_INFO_DWARF5) :=3D 5 > > DEBUG_CFLAGS +=3D -gdwarf-$(dwarf-version-y) > > > > ifdef CONFIG_DEBUG_INFO_REDUCED > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vm= linux.lds.h > > index 34b7e0d2346c..1e7cde4bd3f9 100644 > > --- a/include/asm-generic/vmlinux.lds.h > > +++ b/include/asm-generic/vmlinux.lds.h > > @@ -842,8 +842,13 @@ > > /* DWARF 4 */ = \ > > .debug_types 0 : { *(.debug_types) } = \ > > /* DWARF 5 */ = \ > > + .debug_addr 0 : { *(.debug_addr) } = \ > > + .debug_line_str 0 : { *(.debug_line_str) } = \ > > + .debug_loclists 0 : { *(.debug_loclists) } = \ > > .debug_macro 0 : { *(.debug_macro) } = \ > > - .debug_addr 0 : { *(.debug_addr) } > > + .debug_names 0 : { *(.debug_names) } = \ > > + .debug_rnglists 0 : { *(.debug_rnglists) } = \ > > + .debug_str_offsets 0 : { *(.debug_str_offsets) } > > > > I just looked at binutils 2.36 in the Debian/experimental repositories. > > [1] says: > > + PR ld/27230 > =EF=BF=BC+ * scripttempl/DWARF.sc: Add DWARF-5 .debug_* sections. > > ... > > - /* DWARF Extension. */ > =EF=BF=BC- .debug_macro 0 : { *(.debug_macro) } > + /* DWARF 5. */ > .debug_addr 0 : { *(.debug_addr) } > + .debug_line_str 0 : { *(.debug_line_str) } > + .debug_loclists 0 : { *(.debug_loclists) } > + .debug_macro 0 : { *(.debug_macro) } > + .debug_names 0 : { *(.debug_names) } > + .debug_rnglists 0 : { *(.debug_rnglists) } > + .debug_str_offsets 0 : { *(.debug_str_offsets) } > =EF=BF=BC+ .debug_sup 0 : { *(.debug_sup) } > > The list of DWARF-5 .debug_* sections is alphabetically sorted. > AFAICS .debug_sup section is missing? > Here the link to PR ld/27230 ("[PATCH] Add DWARF v5 sections and v4 .debug_types"). - Sedat - [1] https://sourceware.org/pipermail/binutils/2021-January/115064.html > - Sedat - > > [1] https://salsa.debian.org/toolchain-team/binutils/-/commit/f58f3308103= 5672b01a04326a9c8daadbd09a430 > > > /* Stabs debugging sections. */ > > #define STABS_DEBUG = \ > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 94c1a7ed6306..ad6f78989d4f 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -268,6 +268,24 @@ config DEBUG_INFO_DWARF4 > > It makes the debug information larger, but it significantly > > improves the success of resolving variables in gdb on optimiz= ed code. > > > > +config DEBUG_INFO_DWARF5 > > + bool "Generate DWARF Version 5 debuginfo" > > + depends on GCC_VERSION >=3D 50000 || CC_IS_CLANG > > + depends on CC_IS_GCC || $(success,$(srctree)/scripts/test_dwarf= 5_support.sh $(CC) $(CLANG_FLAGS)) > > + depends on !DEBUG_INFO_BTF > > + help > > + Generate DWARF v5 debug info. Requires binutils 2.35.2, gcc 5= .0+ (gcc > > + 5.0+ accepts the -gdwarf-5 flag but only had partial support = for some > > + draft features until 7.0), and gdb 8.0+. > > + > > + Changes to the structure of debug info in Version 5 allow for= around > > + 15-18% savings in resulting image and debug info section size= s as > > + compared to DWARF Version 4. DWARF Version 5 standardizes pre= vious > > + extensions such as accelerators for symbol indexing and the f= ormat > > + for fission (.dwo/.dwp) files. Users may not want to select t= his > > + config if they rely on tooling that has not yet been updated = to > > + support DWARF Version 5. > > + > > endchoice # "DWARF version" > > > > config DEBUG_INFO_BTF > > diff --git a/scripts/test_dwarf5_support.sh b/scripts/test_dwarf5_suppo= rt.sh > > new file mode 100755 > > index 000000000000..c46e2456b47a > > --- /dev/null > > +++ b/scripts/test_dwarf5_support.sh > > @@ -0,0 +1,8 @@ > > +#!/bin/sh > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +# Test that the assembler doesn't need -Wa,-gdwarf-5 when presented wi= th DWARF > > +# v5 input, such as `.file 0` and `md5 0x00`. Should be fixed in GNU b= inutils > > +# 2.35.2. https://sourceware.org/bugzilla/show_bug.cgi?id=3D25611 > > +echo '.file 0 "filename" md5 0x7a0b65214090b6693bd1dc24dd248245' | \ > > + $* -gdwarf-5 -Wno-unused-command-line-argument -c -x assembler -o /d= ev/null - > > -- > > 2.30.0.365.g02bc693789-goog > >