From: Sedat Dilek <sedat.dilek@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Michal Marek <michal.lkml@markovi.net>,
Sven Schnelle <svens@stackframe.org>,
Xiaozhou Liu <liuxiaozhou@bytedance.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] kbuild: allow Clang to find unused static inline functions for W=1 build
Date: Fri, 30 Aug 2019 11:52:24 +0200 [thread overview]
Message-ID: <CA+icZUXX6YG7=4n60A3_HiTYE0SkNXd8yr4-pqfOsqg66QvXzw@mail.gmail.com> (raw)
In-Reply-To: <CA+icZUWmmC7CruvXx6U0cdXMLaMWJadU=T61E0om1rOuW3==pw@mail.gmail.com>
Just as a sidenote:
From [PATCH v2] kbuild: enable unused-function warnings for W= build with Clang:
"Per the documentation [1], -Wno-unused-function will also disable
-Wunneeded-internal-declaration, which can help find bugs like
commit 8289c4b6f2e5 ("platform/x86: mlx-platform: Properly use
mlxplat_mlxcpld_msn201x_items"). (pointed out by Nathan Chancellor)
I added -Wunneeded-internal-declaration to address it.
If you contribute to code clean-up, please run "make CC=clang W=1"
and check -Wunused-function warnings. You will find lots of unused
functions."
Isn't that missing in your double?
- Sedat -
[1] https://lkml.org/lkml/2019/8/27/729
next prev parent reply other threads:[~2019-08-30 9:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 5:54 [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn Masahiro Yamada
2019-08-28 5:54 ` [PATCH 2/2] kbuild: allow Clang to find unused static inline functions for W=1 build Masahiro Yamada
2019-08-28 18:20 ` Nathan Chancellor
2019-08-28 23:28 ` Nick Desaulniers
2019-08-29 0:05 ` Nathan Chancellor
2019-09-03 15:38 ` Masahiro Yamada
2019-08-30 7:07 ` Sedat Dilek
2019-08-30 9:52 ` Sedat Dilek [this message]
2019-09-03 15:39 ` Masahiro Yamada
2019-08-28 7:20 ` [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn Sedat Dilek
2019-08-28 14:18 ` Sedat Dilek
2019-08-28 14:21 ` Sedat Dilek
2019-08-28 15:59 ` Sedat Dilek
2019-08-29 17:56 ` Masahiro Yamada
2019-08-28 18:26 ` Nick Desaulniers
2019-08-28 18:17 ` Nathan Chancellor
2019-08-28 22:38 ` Nick Desaulniers
2019-08-29 8:49 ` Sedat Dilek
2019-08-29 9:54 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+icZUXX6YG7=4n60A3_HiTYE0SkNXd8yr4-pqfOsqg66QvXzw@mail.gmail.com' \
--to=sedat.dilek@gmail.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxiaozhou@bytedance.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=michal.lkml@markovi.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=svens@stackframe.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).