From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A29C433FE for ; Wed, 27 Apr 2022 23:07:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233585AbiD0XKx (ORCPT ); Wed, 27 Apr 2022 19:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232140AbiD0XKu (ORCPT ); Wed, 27 Apr 2022 19:10:50 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04A9E4F9FD for ; Wed, 27 Apr 2022 16:07:38 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id m62so1941784wme.5 for ; Wed, 27 Apr 2022 16:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yCMuMxFVDueXSdsssZ7NkvR2GebkCDSm3O2foS8iyt0=; b=lI03Sf6n1sFHiTmB3QuhD2zTIpq2cQaW9ilXhtkjF+ugvzsH8im7FgHQByrq960XNv +PudeiasGjWqQsZ9eq9+aUe1TDWptD89pBn7jXPIU5iELE5eIYaLjgSEX71trF6mkMeA 1ZmaWbOLmZwXk0K+jfK3C98Duq0l+wREvqWA8T1e5JBN9z6zU0H7+n1KHHchR7rkVzIj LpNhgP0SAGX2MQ2n9MLo9azwBX78Vvn4Jo1xmitsUBQljGQkdd76ga29sQx3ZvVWkM+S UMjFrTKITNp+wJ9AYUuTJ3i+g5mMCyJntgDRBihhidQUDBtuKVrUrxH663Zj5y02z/ds q15Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yCMuMxFVDueXSdsssZ7NkvR2GebkCDSm3O2foS8iyt0=; b=FotYyi+TpK7v+SXMzsUR8Erv3c/qQXRixHh61tE3xKvMvsZmWaR6nVqJCAk5I7wF1h 8jYGRIjS1z7siV5ulxiVKkUkgG2tsKftZI8kj8ksmEFsawVpv8r096Wu8/zrPHBuxiJn UsGwuR4FI4szWOvzX8PKUtPl07MUtkMKiV6H4VjBryTsgMzR2M/BNeEQtuoYePM3Rnf2 Gy1jN+B/QGaBAdYnvYFo9DvD5aD4ANYif/LBWzBD2H3XhCKlCM75qz4zV9eZqiwNqGTd NTOKiAlnfp2tLtnfUytMPiWi+UJCe1MVUtLdqrxCOFyfbAz5yjmIyPXWZnCOSWv74Yhd AZUg== X-Gm-Message-State: AOAM5337stk1QYLAT4Z7AlaS5Z61e1PoSYuSdXNH6qviJbu7/6ZkAzVh k6owAhLZh+f332vh+YVwHzW9x2RzTdgVgpKqcCjc512kggM= X-Google-Smtp-Source: ABdhPJz76n8vrNwnrnWIGpRemBC6D8/Dji5ku3bVo0ANrd/hiH+XDReSHjhODQT92FyrlaNmynjVZKLvV0H/Zhl2w5I= X-Received: by 2002:a1c:f605:0:b0:37b:b5de:89a0 with SMTP id w5-20020a1cf605000000b0037bb5de89a0mr27476548wmc.88.1651100856343; Wed, 27 Apr 2022 16:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20220422150507.222488-1-namhyung@kernel.org> <20220422150507.222488-3-namhyung@kernel.org> In-Reply-To: <20220422150507.222488-3-namhyung@kernel.org> From: Hao Luo Date: Wed, 27 Apr 2022 16:07:25 -0700 Message-ID: Subject: Re: [PATCH 2/4] perf record: Enable off-cpu analysis with BPF To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Andi Kleen , Ian Rogers , Song Liu , bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, Blake Jones Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Namhyung, On Fri, Apr 22, 2022 at 8:05 AM Namhyung Kim wrote: > [...] > > Signed-off-by: Namhyung Kim > --- > tools/perf/Makefile.perf | 1 + > tools/perf/builtin-record.c | 21 +++ > tools/perf/util/Build | 1 + > tools/perf/util/bpf_off_cpu.c | 208 +++++++++++++++++++++++++ > tools/perf/util/bpf_skel/off_cpu.bpf.c | 137 ++++++++++++++++ > tools/perf/util/off_cpu.h | 22 +++ > 6 files changed, 390 insertions(+) > create mode 100644 tools/perf/util/bpf_off_cpu.c > create mode 100644 tools/perf/util/bpf_skel/off_cpu.bpf.c > create mode 100644 tools/perf/util/off_cpu.h > [...] > diff --git a/tools/perf/util/bpf_skel/off_cpu.bpf.c b/tools/perf/util/bpf_skel/off_cpu.bpf.c > new file mode 100644 > index 000000000000..2bc6f7cc59ea > --- /dev/null > +++ b/tools/perf/util/bpf_skel/off_cpu.bpf.c > > +struct { > + __uint(type, BPF_MAP_TYPE_HASH); > + __uint(key_size, sizeof(__u32)); > + __uint(value_size, sizeof(struct tstamp_data)); > + __uint(max_entries, MAX_ENTRIES); > +} tstamp SEC(".maps"); I think using task local storage for this tstamp would be more efficient. There is an example in tools/bpf/runqslower/runqslower.bpf.c