From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F2AC433F5 for ; Tue, 10 May 2022 18:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348858AbiEJS0E (ORCPT ); Tue, 10 May 2022 14:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348849AbiEJSZ5 (ORCPT ); Tue, 10 May 2022 14:25:57 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1856F5373E for ; Tue, 10 May 2022 11:25:54 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id e24so24981727wrc.9 for ; Tue, 10 May 2022 11:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yHb/t4sJWtaUrfKkQwH3/sfbd07PYe3PiYuK/lpKKSM=; b=XF0oB5IuvA6vJGEyZOrGfxGamHtbVLL4rlc9UC4pYza1Scg0lYG1lQjzP2+uF4mYKg k5SqANXoXiMKqwfOjo/kCTJ1wE2u5Oh0t5b3zwwBN12RRjqZg2eGmMtC3vO29ME5jttc u8/DTuiEBDHhQ3IT3Tvh+OgaSJhVvk4AxYOiHIHpE+HqpB/QvLCevvw26Hs3WYNOUuT8 UOHVIWJy37iQItWWuiSHZ2v0tMF5ao8PrVU9FwmB+Edemgi4WxwESF85LNNfolrVn0C0 BS5Fyo4ODK6JUclQ/DNpWR7V60B/ysAFObHrRLJmgpUAivLmKv3mmULFcV+xH5hnIiyS zx2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yHb/t4sJWtaUrfKkQwH3/sfbd07PYe3PiYuK/lpKKSM=; b=vh8TN5hXqFM1kUi//qqXfhbV7CYMBm/fsKpR+ZrbUuA/sFG+EykUtyaD1T/Lq47yaM TJrP7Ku1Y40HWajUQOTmocg3+2Y8NibOKz3camy0NvoEVjjxybyduf/PvbqBfZ46/x6W sIwi80Z7s3dLdi1eBGbKEpDL68BEceDoHXSnkSdfk2b/K9iOGOHhyUVotvJJm0bjj8uS w+3pYCZ4WzwHms4ov46tiwdCoLvdLvcYs0musMcAjviCCiRUFIFL32MeElJOqmUZJDbH wYi36FHh/PnG7RCmCVb5HAbem+xmp8bNXdkc9qEcP9Dvfdy9ucmPVcsmfPQzeCK0WlJF RXXQ== X-Gm-Message-State: AOAM533KVk97r7jbaamleshdykamotBlvDZxEbZMjd+7EDRjYjjQj1pX a+QBJH96BcTVOakSOqkCC1tNCfdcn108y+HSAU8Ayg== X-Google-Smtp-Source: ABdhPJwgIj7vziuYge7EQKcTCuMZUyByhn/rKEmnyQnFeLeWkydhYLQUs4H82FaqklGewSSKA0AQYRbJD/88/K0apEs= X-Received: by 2002:a5d:564c:0:b0:20a:d53c:70e3 with SMTP id j12-20020a5d564c000000b0020ad53c70e3mr20132500wrw.0.1652207152934; Tue, 10 May 2022 11:25:52 -0700 (PDT) MIME-Version: 1.0 References: <20220510001807.4132027-1-yosryahmed@google.com> <20220510001807.4132027-8-yosryahmed@google.com> In-Reply-To: <20220510001807.4132027-8-yosryahmed@google.com> From: Hao Luo Date: Tue, 10 May 2022 11:25:42 -0700 Message-ID: Subject: Re: [RFC PATCH bpf-next 7/9] cgroup: Add cgroup_put() in !CONFIG_CGROUPS case To: Yosry Ahmed Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Tejun Heo , Zefan Li , Johannes Weiner , Shuah Khan , Roman Gushchin , Michal Hocko , Stanislav Fomichev , David Rientjes , Greg Thelen , Shakeel Butt , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 9, 2022 at 5:18 PM Yosry Ahmed wrote: > > From: Hao Luo > > There is already a cgroup_get_from_id() in the !CONFIG_CGROUPS case, > let's have a matching cgroup_put() in !CONFIG_CGROUPS too. > > Signed-off-by: Hao Luo > Signed-off-by: Yosry Ahmed > --- > include/linux/cgroup.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h > index 5408c74d5c44..4f1d8febb9fd 100644 > --- a/include/linux/cgroup.h > +++ b/include/linux/cgroup.h [...] > + > +static inline struct cgroup *cgroup_put(void) > +{} Sorry Yosry, the return type and parameter type are mixed up. I will fix it and send you an updated version.