From: Slade Watkins <srw@sladewatkins.net>
To: frank@oltmanns.dev
Cc: "Guido Günther" <agx@sigxcpu.org>,
"Purism Kernel Team" <kernel@puri.sm>,
"Ondrej Jirman" <megous@megous.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] drm/panel: st7703: Fix vertical refresh rate of XBD599
Date: Sun, 26 Feb 2023 11:54:57 -0500 [thread overview]
Message-ID: <CA+pv=HPY1HCDJ=sHeg_S7ZusS1RqiYvGOUf2bPVZK7Rq_EfHUg@mail.gmail.com> (raw)
In-Reply-To: <20230219114553.288057-2-frank@oltmanns.dev>
On Sun, Feb 19, 2023 at 6:46 AM Frank Oltmanns <frank@oltmanns.dev> wrote:
>
> Fix the XBD599 panel's slight visual stutter by correcting the pixel
> clock speed so that the panel's 60Hz vertical refresh rate is met.
>
> Set the clock speed using the underlying formula instead of a magic
> number. To have a consistent procedure for both panels, set the JH057N
> panel's clock also as a formula.
> ---
Hi Frank,
Just wanted to let you know that this appears to be missing your Signed-off-by:.
Thanks,
-- Slade
> drivers/gpu/drm/panel/panel-sitronix-st7703.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> index 6747ca237ced..cd7d631f7573 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -139,7 +139,7 @@ static const struct drm_display_mode jh057n00900_mode = {
> .vsync_start = 1440 + 20,
> .vsync_end = 1440 + 20 + 4,
> .vtotal = 1440 + 20 + 4 + 12,
> - .clock = 75276,
> + .clock = (720 + 90 + 20 + 20) * (1440 + 20 + 4 + 12) * 60 / 1000,
> .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> .width_mm = 65,
> .height_mm = 130,
> @@ -324,7 +324,7 @@ static const struct drm_display_mode xbd599_mode = {
> .vsync_start = 1440 + 18,
> .vsync_end = 1440 + 18 + 10,
> .vtotal = 1440 + 18 + 10 + 17,
> - .clock = 69000,
> + .clock = (720 + 40 + 40 + 40) * (1440 + 18 + 10 + 17) * 60 / 1000,
> .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> .width_mm = 68,
> .height_mm = 136,
> --
> 2.39.1
>
prev parent reply other threads:[~2023-02-26 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 11:45 [PATCH 0/1] drm/panel: st7703: Fix vertical refresh rate of XBD599 Frank Oltmanns
2023-02-19 11:45 ` [PATCH 1/1] " Frank Oltmanns
2023-02-19 12:00 ` Guido Günther
2023-02-19 12:35 ` Ondřej Jirman
2023-02-20 7:40 ` Frank Oltmanns
2023-02-26 15:17 ` Frank Oltmanns
2023-02-26 17:17 ` Ondřej Jirman
2023-02-26 16:54 ` Slade Watkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+pv=HPY1HCDJ=sHeg_S7ZusS1RqiYvGOUf2bPVZK7Rq_EfHUg@mail.gmail.com' \
--to=srw@sladewatkins.net \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank@oltmanns.dev \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=megous@megous.com \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).