From: Mathias Krause <minipli@googlemail.com>
To: Joe Perches <joe@perches.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC PATCH 0/3] Mark literal strings in __init / __exit code
Date: Wed, 25 Jun 2014 10:34:25 +0200 [thread overview]
Message-ID: <CA+rthh83g7W2UVbGGENmTOtamRoQvo_UD_04C2Ux5fAhvX2b9Q@mail.gmail.com> (raw)
In-Reply-To: <1403682511.17451.21.camel@joe-AO725>
On 25 June 2014 09:48, Joe Perches <joe@perches.com> wrote:
> On Wed, 2014-06-25 at 09:35 +0200, Rasmus Villemoes wrote:
>> Speaking of dangling pointers: A similar disaster would happen if some
>> code containing pi_* calls gets copy-pasted to some non-__init
>> function.
>
> This is my biggest issue with adding these new,
> somewhat obscure macros.
modpost will handle these cases.
>> Could checkpatch learn to warn about calling these functions
>> from the wrong context?
>
> It's not possible. checkpatch works on patch chunks.
> Any patch chunk may not contain the function attributes.
checkpatch.pl -f might detect them, though :/
Thanks,
Mathias
next prev parent reply other threads:[~2014-06-25 8:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 22:46 [RFC PATCH 0/3] Mark literal strings in __init / __exit code Mathias Krause
2014-06-22 22:46 ` [RFC PATCH 1/3] init.h: Add __init_str / __exit_str macros Mathias Krause
2014-06-24 19:43 ` Joe Perches
2014-06-24 20:13 ` Mathias Krause
2014-06-22 22:46 ` [RFC PATCH 2/3] printk: Provide pi_<level> / pe_<level> macros for __init / __exit code Mathias Krause
2014-06-22 22:46 ` [RFC PATCH 3/3] x86, acpi: Mark __init strings as such Mathias Krause
2014-06-22 22:56 ` [RFC PATCH 0/3] Mark literal strings in __init / __exit code Joe Perches
2014-06-23 6:23 ` Mathias Krause
2014-06-23 6:33 ` Joe Perches
2014-06-24 14:31 ` Rasmus Villemoes
2014-06-24 19:13 ` Mathias Krause
2014-06-24 19:37 ` Joe Perches
2014-06-24 20:10 ` Mathias Krause
2014-06-24 20:30 ` Joe Perches
2014-06-24 20:41 ` Mathias Krause
2014-06-24 20:57 ` Joe Perches
2014-06-24 21:06 ` Mathias Krause
2014-06-24 21:45 ` Joe Perches
2014-06-25 5:55 ` Mathias Krause
2014-06-25 7:35 ` Rasmus Villemoes
2014-06-25 7:48 ` Joe Perches
2014-06-25 8:34 ` Mathias Krause [this message]
2014-06-25 11:22 ` Joe Perches
2014-06-25 8:17 ` Mathias Krause
2014-06-23 1:30 ` Joe Perches
2014-06-23 6:29 ` Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+rthh83g7W2UVbGGENmTOtamRoQvo_UD_04C2Ux5fAhvX2b9Q@mail.gmail.com \
--to=minipli@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).