From: Mathias Krause <firstname.lastname@example.org> To: Avi Kivity <email@example.com> Cc: Marcelo Tosatti <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH 2/8] KVM: x86 emulator: use aligned variants of SSE register ops Date: Tue, 4 Sep 2012 14:51:06 +0200 [thread overview] Message-ID: <CA+rthh8T3Y9XAz+J3C7KfeJa_0d9if9GSrhwTNYhPR+RgEnXKg@mail.gmail.com> (raw) In-Reply-To: <5045F06F.email@example.com> On Tue, Sep 4, 2012 at 2:13 PM, Avi Kivity <firstname.lastname@example.org> wrote: > On 09/04/2012 03:09 PM, Avi Kivity wrote: >> On 08/30/2012 02:30 AM, Mathias Krause wrote: >>> As the the compiler ensures that the memory operand is always aligned >>> to a 16 byte memory location, >> >> I'm not sure it does. Is V4SI aligned? Do we use alignof() to >> propagate the alignment to the vcpu allocation code? I checked that to by introducing a dummy char member in struct operand that would have misaligned vec_val but, indeed, the compiler ensured it's still 16 byte aligned. > > We actually do. But please rebase the series against next, I got some > conflicts while applying. If "next" means kvm/next (i.e.git://git.kernel.org/pub/scm/virt/kvm/kvm.git#next) here, the whole series applies cleanly for me. HEAD in kvm/next is 9a78197 "KVM: x86: remove unused variable from kvm_task_switch()" here. Albeit the series was build against kvm/next at the time as a81aba1 "KVM: VMX: Ignore segment G and D bits when considering whether we can virtualize" was HEAD in this branch. Could you please retry and show me the conflicts you get? Regards, Mathias
next prev parent reply other threads:[~2012-09-04 12:51 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-29 23:30 [PATCH 0/8] KVM: minor cleanups and optimizations Mathias Krause 2012-08-29 23:30 ` [PATCH 1/8] KVM: x86: minor size optimization Mathias Krause 2012-08-29 23:30 ` [PATCH 2/8] KVM: x86 emulator: use aligned variants of SSE register ops Mathias Krause 2012-09-04 12:09 ` Avi Kivity 2012-09-04 12:13 ` Avi Kivity 2012-09-04 12:51 ` Mathias Krause [this message] 2012-09-05 9:43 ` Avi Kivity 2012-08-29 23:30 ` [PATCH 3/8] KVM: x86: mark opcode tables const Mathias Krause 2012-08-29 23:30 ` [PATCH 4/8] KVM: x86: constify emulate_ops Mathias Krause 2012-08-29 23:30 ` [PATCH 5/8] KVM: x86: constify read_write_emulator_ops Mathias Krause 2012-08-29 23:30 ` [PATCH 6/8] KVM: x86: more constification Mathias Krause 2012-08-29 23:30 ` [PATCH 7/8] KVM: VMX: constify lookup tables Mathias Krause 2012-08-29 23:30 ` [PATCH 8/8] KVM: SVM: " Mathias Krause
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+rthh8T3Y9XAz+J3C7KfeJa_0d9if9GSrhwTNYhPR+RgEnXKg@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/8] KVM: x86 emulator: use aligned variants of SSE register ops' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).