From: Sunil Kovvuri <sunil.kovvuri@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
olof@lixom.net, LAKML <linux-arm-kernel@lists.infradead.org>,
linux-soc@vger.kernel.org, Sunil Goutham <sgoutham@marvell.com>,
Linux Netdev List <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 00/15] soc: octeontx2: Add RVU admin function driver
Date: Fri, 31 Aug 2018 00:01:11 +0530 [thread overview]
Message-ID: <CA+sq2CfX+BGE1Ub0H9G21Vqg+vmQSukZj4gwz=B8wsqTLgE7mg@mail.gmail.com> (raw)
In-Reply-To: <20180830132658.GA27566@lunn.ch>
On Thu, Aug 30, 2018 at 6:57 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > > > My feeling overall is that we need a review from the network driver
> > > > folks more than the arm-soc team etc, and that maybe the driver
> > > > as a whole should go into drivers/net/ethernet.
> > >
> > > This driver doesn't handle any network IO and moreever this driver has to handle
> > > configuration requests from crypto driver as well. There will be
> > > separate network and
> > > crypto drivers which will be upstreamed into drivers/net/ethernet and
> > > drivers/crypto.
> > > And in future silicons there will be different types of functional
> > > blocks which will be
> > > added into this resource virtualization unit (RVU). Hence i thought
> > > this driver is not a
> > > right fit in drivers/net/ethernet.
>
> Hi Sunil
>
> Do you have a git branch for everything? I would like to look at the
> actual Ethernet driver, and the full API this driver exports to other
> drivers.
Hi Andrew,
I have pushed all patches into a github repo for your reference.
These are not the final patches, i still need to do some minor changes
before submitting
(i mean otherthan the ones i already submitted).
AF driver & CGX drivers:
https://github.com/sunilkovvuri/rvu_drivers/tree/master/drivers/soc/marvell/octeontx2
Ethernet drivers PF and VF
https://github.com/sunilkovvuri/rvu_drivers/tree/master/drivers/net/ethernet/marvell/octeontx2
Info exported/shared by AF driver with other drivers is
# Mailbox communication APIs, message IDs, message structs e.t.c
https://github.com/sunilkovvuri/rvu_drivers/blob/master/drivers/soc/marvell/octeontx2/mbox.c
https://github.com/sunilkovvuri/rvu_drivers/blob/master/drivers/soc/marvell/octeontx2/mbox.h
# Other structs and APIs
https://github.com/sunilkovvuri/rvu_drivers/blob/master/drivers/soc/marvell/octeontx2/common.h
https://github.com/sunilkovvuri/rvu_drivers/blob/master/drivers/soc/marvell/octeontx2/rvu_struct.h
>
> I think there real question here is, do you have split between this
> driver and the actual device drivers in the right place? For me, link
> up/down detection should be in the Ethernet driver, since it is not
> shared with the crypto driver.
>
As mentioned in the patch '[PATCH 13/15] soc: octeontx2: Add support
for CGX link management',
link up/down is detected by firmware. And firmware triggers a IRQ to
CGX driver, which then
takes the new status and sends a update to ethernet driver via a
mailbox communication.
Ethernet driver detects the link change and does the necessary stuff.
https://github.com/sunilkovvuri/rvu_drivers/blob/master/drivers/net/ethernet/marvell/octeontx2/otx2_pf.c#L116
> Thanks
> Andrew
prev parent reply other threads:[~2018-08-30 18:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 10:57 [PATCH 00/15] soc: octeontx2: Add RVU admin function driver sunil.kovvuri
2018-08-28 10:57 ` [PATCH 01/15] soc: octeontx2: Add Marvell OcteonTX2 RVU AF driver sunil.kovvuri
2018-08-28 10:57 ` [PATCH 02/15] soc: octeontx2: Reset all RVU blocks sunil.kovvuri
2018-08-28 10:57 ` [PATCH 03/15] soc: octeontx2: Gather RVU blocks HW info sunil.kovvuri
2018-08-28 10:57 ` [PATCH 04/15] soc: octeontx2: Add mailbox support infra sunil.kovvuri
2018-08-28 12:03 ` Arnd Bergmann
2018-08-28 12:47 ` Sunil Kovvuri
2018-08-28 12:52 ` Arnd Bergmann
2018-08-28 13:23 ` Sunil Kovvuri
2018-08-30 13:56 ` Arnd Bergmann
2018-08-30 18:36 ` Sunil Kovvuri
2018-08-31 14:16 ` Arnd Bergmann
2018-08-31 17:25 ` Sunil Kovvuri
2018-08-28 10:57 ` [PATCH 05/15] soc: octeontx2: Add mailbox IRQ and msg handlers sunil.kovvuri
2018-08-28 10:57 ` [PATCH 06/15] soc: octeontx2: Convert mbox msg id check to a macro sunil.kovvuri
2018-08-28 10:57 ` [PATCH 07/15] soc: octeontx2: Scan blocks for LFs provisioned to PF/VF sunil.kovvuri
2018-08-28 10:57 ` [PATCH 08/15] soc: octeontx2: Add RVU block LF provisioning support sunil.kovvuri
2018-08-28 10:57 ` [PATCH 09/15] soc: octeontx2: Configure block LF's MSIX vector offset sunil.kovvuri
2018-08-28 10:57 ` [PATCH 10/15] soc: octeontx2: Reconfig MSIX base with IOVA sunil.kovvuri
2018-08-28 12:08 ` Arnd Bergmann
2018-08-28 12:42 ` Sunil Kovvuri
2018-08-28 12:57 ` Arnd Bergmann
2018-08-28 13:17 ` Sunil Kovvuri
2018-08-30 13:53 ` Arnd Bergmann
2018-08-30 18:39 ` Sunil Kovvuri
2018-08-28 10:57 ` [PATCH 11/15] soc: octeontx2: Add Marvell OcteonTX2 CGX driver sunil.kovvuri
2018-08-28 12:10 ` Arnd Bergmann
2018-08-28 12:30 ` Sunil Kovvuri
2018-08-28 12:48 ` Arnd Bergmann
2018-08-28 13:09 ` Sunil Kovvuri
2018-08-30 14:07 ` Arnd Bergmann
2018-08-30 17:55 ` Sunil Kovvuri
2018-08-31 14:20 ` Arnd Bergmann
2018-08-31 16:00 ` Sunil Kovvuri
2018-08-31 18:29 ` Arnd Bergmann
2018-08-31 18:35 ` Sunil Kovvuri
2018-08-28 10:57 ` [PATCH 12/15] soc: octeontx2: Set RVU PFs to CGX LMACs mapping sunil.kovvuri
2018-08-28 10:57 ` [PATCH 13/15] soc: octeontx2: Add support for CGX link management sunil.kovvuri
2018-08-28 10:57 ` [PATCH 14/15] soc: octeontx2: Register for CGX lmac events sunil.kovvuri
2018-08-28 10:57 ` [PATCH 15/15] MAINTAINERS: Add entry for Marvell OcteonTX2 Admin Function driver sunil.kovvuri
2018-08-28 12:23 ` [PATCH 00/15] soc: octeontx2: Add RVU admin function driver Arnd Bergmann
2018-08-28 13:24 ` Sunil Kovvuri
2018-08-30 9:40 ` Sunil Kovvuri
2018-08-30 13:26 ` Andrew Lunn
2018-08-30 18:31 ` Sunil Kovvuri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+sq2CfX+BGE1Ub0H9G21Vqg+vmQSukZj4gwz=B8wsqTLgE7mg@mail.gmail.com' \
--to=sunil.kovvuri@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).