From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750930AbdEBCQm (ORCPT ); Mon, 1 May 2017 22:16:42 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:35905 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbdEBCQj (ORCPT ); Mon, 1 May 2017 22:16:39 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170501212730.774855694@linuxfoundation.org> <20170501212732.861897612@linuxfoundation.org> From: Ed Bordin Date: Tue, 2 May 2017 12:16:18 +1000 Message-ID: Subject: Re: [PATCH 4.10 54/62] Input: i8042 - add Clevo P650RS to the i8042 reset list To: Dmitry Torokhov Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?UTF-8?Q?Pawe=C5=82_Bylica?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v422INat005876 On 2 May 2017 at 11:22, Dmitry Torokhov wrote: > On May 1, 2017 6:14:54 PM PDT, Ed Bordin wrote: >>On 2 May 2017 at 07:35, Greg Kroah-Hartman >>wrote: >>> 4.10-stable review patch. If anyone has any objections, please let >>me know. >> >>Minor query (that I probably should have raised earlier): is there any >>data to support the comment that the DMI_PRODUCT_NAME "P65xRP" matches >>all of "P650RS, 650RP6, Sager NP8152-S"? I have only tested on a >>P650RP variant. > > I pulled the product names from dmi data from the Launchpad bug referenced in bugzilla. > > > Thanks. > > -- > Dmitry I guess what I was getting at is that it seemed a little odd that the RS variant from the original bug report would only have "RP" in its product string. Just did some more digging and it looks like DMI_PRODUCT_NAME for the RS model in the original bug report is "P65_67RSRP" [1] but we probably have no way of testing it unless Paweł Bylica or someone else is able to help. Don't get me wrong, I'm happy if this goes through as-is! But thought it would be best to note that in case it causes any future confusion. [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1645322