From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbeCMPAg (ORCPT ); Tue, 13 Mar 2018 11:00:36 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:52689 "EHLO mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbeCMPAe (ORCPT ); Tue, 13 Mar 2018 11:00:34 -0400 X-Google-Smtp-Source: AG47ELvpdbivCFLja5+HAJBoCFgUHPmwX4qkd9WVaDlR+iY15QnT4nLiWEiHnsJQpF3JWFEGr6NuyHN9tsIzgzNOip0= MIME-Version: 1.0 References: <01000161fc0b4755-df0621f4-ab5d-479a-b425-adf98427a308-000000@email.amazonses.com> <010001620bafa06b-41525407-603e-40a9-ba11-6033b2f5dcc7-000000@email.amazonses.com> <010001621a9e5069-0b1a6328-97e4-4396-9438-b90f5b8c82a4-000000@email.amazonses.com> <010001621b287e42-58955302-cc14-4212-b7b0-e6e358633dab-000000@email.amazonses.com> <010001621b7ce5a3-b80c55b8-be68-4b44-ab52-4949e8ddb8d0-000000@email.amazonses.com> <010001621f97c0bb-898ceaeb-668d-4543-8835-dc374ba02539-000000@email.amazonses.com> In-Reply-To: From: Thiebaud Weksteen Date: Tue, 13 Mar 2018 15:00:22 +0000 Message-ID: Subject: Re: Regression from efi: call get_event_log before ExitBootServices To: Ard Biesheuvel , hdegoede@redhat.com, Jeremy Cline Cc: Javier Martinez Canillas , Jarkko Sakkinen , linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2018 at 2:43 PM Ard Biesheuvel wrote: > On 13 March 2018 at 13:41, Jeremy Cline wrote: > > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: > >>> Hi, > >>> > >>> > >>> On 12-03-18 20:55, Thiebaud Weksteen wrote: > >>>> > >> ... > >>>> > >>>> Hans, you said you configured the tablet to use the 32-bit version of grub > >>>> instead > >>>> of 64. Why's that? > >>> > >>> > >>> Because this tablet, like (almost?) all Bay Trail hardware has a 32 bit > >>> UEFI, > >>> even though the processor is 64 bit capable (AFAIK 64 bit Windows drivers > >>> were > >>> not ready in time so all Bay Trail devices shipped with a 32 bit Windows). > >>> > >>> So this is running a 32 bit grub which boots a 64 bit kernel. > >>> > >>>> Jeremy, could you confirm if you are building the kernel in 64bit mode? Is > >>>> your Android install working? (that is, what happens if you boot > >>>> Boot0000)? > >>> > >>> > >>> AFAIK the kernel on Jeremy's tablet (which I initially installed) is 64 bit. > >>> > >>> Could the problem perhaps be that the new code for the TPM event-log is > >>> missing some handling to deal with running on a 32 bit firmware? I know the > >>> rest of the kernel has special code to deal with this. > >>> > >> > >> That is a very good point, and I missed that this is a 64-bit kernel > >> running on 32-bit UEFI. > >> > >> The TPM code does use efi_call_proto() directly, and now I am thinking > >> it is perhaps the allocate_pages() call that simply only initializes > >> the low 32-bits of log_tbl. > >> > >> Jeremy, could you please try initializing tcg2_protocol and log_tbl to > >> NULL at the start of the function? > >> > > > > That was it, it boots when those are initialized to NULL. > > > Thanks for confirming. I'll send out a patch. Sweet! Jeremy, Hans, thanks for the help debugging! Ard, thanks for the help fixing the issue!