From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 179F9C10F00 for ; Sat, 7 Mar 2020 03:24:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFDB4206CC for ; Sat, 7 Mar 2020 03:24:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V6CTG2Bc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726633AbgCGDYo (ORCPT ); Fri, 6 Mar 2020 22:24:44 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:36703 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbgCGDYn (ORCPT ); Fri, 6 Mar 2020 22:24:43 -0500 Received: by mail-qk1-f195.google.com with SMTP id u25so4352951qkk.3; Fri, 06 Mar 2020 19:24:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xx47FJX+QZbsjpJJ8x5FoZzQPuJdzEkyLKKPH7vo5sk=; b=V6CTG2BcTle4ax3VW2GMHUYNQikRPHCX4W8GrQB30I7oTu+yciihautJPRVRVjQ/Fc 4kw1eamGfYWI+0JA2+f4WTC0j66nFLcnd99j+u/JabWCi3MKzZqlGYpUGHSL2uG7mtIF BfhUwv1spkZ3ujZfrr3fUBm8ngmoJQzhDuiHuJu/QP0GKueGBjshtLXt46XuOmZgKx/k JuhzFIkghSF56z6430kkDS6XYJ9RA+oqlafgd4aUUnS5t52RLf0rttvgMrL1JBERiRYX RpwRRbLrCwoL2EWUcYPnjqPBEq6rHC9UTbskZJ/gSdsjmpVPKgwIbE0mfl05KL3hJagt G8jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xx47FJX+QZbsjpJJ8x5FoZzQPuJdzEkyLKKPH7vo5sk=; b=ZtNJrkPrOYNUvLBuBSYru29cikjWe24CmuHm7vdRHvcqmzpb77S1/X3tEhepW2hMkP /nTV9rt0PJwKWaXJ59SV7tHIdkdBgJPdVedeWVQ0+ivDwc/s3JS+1Jm2u6xqMY2aF20k /5JEdNiQAO4dBJk/8xuwWqmcQIJRfU410oMylwR2EJvLUsOkSJM17jZBXOC9/RnnKEXW QIpR3ZXLTGGwkp/kLDFKiec+aZUDq56VXEKncMErOi1cl6mg6miXlhYTc9qVDTKCWkpB 1Z15ZtIa7OrhhjihDWIem7/h/NyzQElJQLhyWKYVdxNpG+Lzr+jseaWDewDR0b8QSyYA cO3A== X-Gm-Message-State: ANhLgQ2mWJQW63OGtyC95nD/emT9nKXhb900gy40S3fsakI1eAO57y4Y 0+SIJsKOt7OoxFocaq3k/yI+JxwwcoicDHid1ug= X-Google-Smtp-Source: ADFU+vsrgn/I7/3yq0U87aezc5EPcL/v/ioSyi8uCEcZqO8JoZIjCstooShLZGMYvgHn2vn/uc1R6Au9Gus47NWljDo= X-Received: by 2002:a37:a50d:: with SMTP id o13mr5736750qke.37.1583551482955; Fri, 06 Mar 2020 19:24:42 -0800 (PST) MIME-Version: 1.0 References: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com> <20200303014133.GA24596@bogus> <20200303124739.GE3866@sirena.org.uk> In-Reply-To: <20200303124739.GE3866@sirena.org.uk> From: Shengjiu Wang Date: Sat, 7 Mar 2020 11:24:32 +0800 Message-ID: Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format To: Mark Brown Cc: Rob Herring , Shengjiu Wang , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel , Timur Tabi , Xiubo Li , shawnguo@kernel.org, s.hauer@pengutronix.de, Takashi Iwai , Liam Girdwood , Nicolin Chen , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Tue, Mar 3, 2020 at 8:47 PM Mark Brown wrote: > > On Tue, Mar 03, 2020 at 11:59:30AM +0800, Shengjiu Wang wrote: > > On Tue, Mar 3, 2020 at 9:43 AM Rob Herring wrote: > > > > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. > > > > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > > > > + Ends. The value is one of SNDRV_PCM_FORMAT_XX in > > > > + "include/uapi/sound/asound.h" > > > > You can't just change properties. They are an ABI. > > > I have updated all the things related with this ABI in this patch series. > > What else should I do? > > Like Nicolin says you should continue to support the old stuff. The > kernel should work with people's out of tree DTs too so simply updating > everything in the tree isn't enough. Thanks for review, I will update patch in next version. best regards wang shengjiu